Received-SPF: pass (google.com: domain of linux-kernel+bounces-162829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
To: Kees Cook <keescook@chromium.org>
Cc: Erick Archer <erick.archer@outlook.com>,
        "James E.J. Bottomley"
 <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Justin Stitt
 <justinstitt@google.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3] scsi: csiostor: Use kcalloc() instead of kzalloc()
From: "Martin K. Petersen" <martin.petersen@oracle.com>
In-Reply-To: <202404291019.5AC903A@keescook> (Kees Cook's message of "Mon, 29
	Apr 2024 10:20:15 -0700")
Organization: Oracle Corporation
Message-ID: <yq17cgg58sp.fsf@ca-mkp.ca.oracle.com>
References: <AS8PR02MB7237BA2BBAA646DFDB21C63B8B392@AS8PR02MB7237.eurprd02.prod.outlook.com>
	<202404291019.5AC903A@keescook>
Date: Mon, 29 Apr 2024 14:31:19 -0400
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Ay7bIVTwUwa612GJFK1pp4JS3CZUlwQLhQQcROhlnk5SGL/B3yjJhzQHcCfh?=
 =?us-ascii?Q?bsA9WtGjqUcy66La4YwyhxjZkr528VGgVGM8wNnesLvuD427TwlRn7wlqzEJ?=
 =?us-ascii?Q?X9gWVArbD17g4nt94MOoaU9MnaSPNvBBOi4u/WP/AYZ04ZJ6VrmYJ8J/syJn?=
 =?us-ascii?Q?jnpj0fCwu0Zjar3cWaAdagVKNsf9hZNVw3j6kaBF4taH+PNfwl0eZkxyK5Rs?=
 =?us-ascii?Q?xAHuD24VsT0yW7W0B8gHKKm6+zbKe73zNDB0uQjtBrNxyHJcd8qSJF5/BRqK?=
 =?us-ascii?Q?taI6MqTiYjIrtavBjZe/58pLs1zgkg+7IIdIA2nbQgE4MhKxGXnd5ZuPXmvC?=
 =?us-ascii?Q?07NrSAJgxupPtN90oU2HImBB3yw6HoO55TUshbxmH3jDbRZnWGGB65EZb15M?=
 =?us-ascii?Q?ZVG/mVmcnrkByANWkb6xYevLoCtVit5sRDsVkVA97rbasUDj8XtWRMkkUfL/?=
 =?us-ascii?Q?LOwFHqNYSD4PBXgNL02JUuZ09l40Bakhfllb/D3T2MXMlh5cBs+OLh0pXNhr?=
 =?us-ascii?Q?xVTAXaNmkuBEFiuxlx621l2SyveT3CbMGrS6uwafYnRNiNqiPv3Rq2E8YOWN?=
 =?us-ascii?Q?ehWUgdFwPYW96yWHDTaqQ4qFaH5NSLzQmk2OT606NAQdUYIlFico8TNdm3kR?=
 =?us-ascii?Q?DCYN16N6fib+5n3TZPc1j1/5VPVxbo1kXJnqvtyDEo72PKL8xwW83nX2V09F?=
 =?us-ascii?Q?QLXSFW+GNqwAcnhGbqf/Csgc9riXYx3ZA0HQLG0wwQ69Oq7xTfCFSt3YNBMs?=
 =?us-ascii?Q?760iOTGZ61Lm56EqZz50KH789c8qk9cxGFPB2UGRNMgdU7rq1dxLxADHzrqU?=
 =?us-ascii?Q?qt6vXGsWKUSFUzWthnKri2dbSOKO7UM1HbQdKi/JS2l0AkTB0Mv3eva4bLpS?=
 =?us-ascii?Q?oXJDOVMR4vmsqf8pmy9u+vX5e5x8W+ybstBtnexBgYNtPH20nQAbqXwg0u0d?=
 =?us-ascii?Q?e4PBQpNpOD5Ao7MaDwQ8RKYsgY9DTBaLpWlclbL94w9kT2bInFdxW2vfz36R?=
 =?us-ascii?Q?NMmk3D2iZcfZjtZtop7Z0wJBOkc2alfrxQ4aImZnZl0Pnvc4nbbTLzqEHkga?=
 =?us-ascii?Q?jMGjwT1YiIQJW2A7Ew5/Hmfg4vL+G5kLJ2mfiT03/ph1x71hqe+VxmLzeXw3?=
 =?us-ascii?Q?u8BTYkWkX+8/TC30oZtSz0nOswAxvWf4mVqP0NIS2zlJXBA5q05DgfPASc0N?=
 =?us-ascii?Q?xHMUiiNYhjs4MaJy/yXjDH/iOV37v9DBLFXLdtofG5pS4dKWwDjuo6Vcqm+S?=
 =?us-ascii?Q?K0u7XSVUdTD3rjM1sbBre8ArG5K26A0UhfRElRwOeUo8FLTduJVYdBD3Zuv4?=
 =?us-ascii?Q?rVjDCJth2mMhGo4ZEnXZRdZd5S/vRpw3ySvGWD/hpy+KDBRgRwYrOnc5hUcc?=
 =?us-ascii?Q?AC93CWtGNWn1nWGVSSw7logr+0Z5W7lhFeeVb5TgkLGkMGe6rmgDHKespTgH?=
 =?us-ascii?Q?6nHsdyAddOqz0JJv10u0hoCF+i5XTqg97MrFJoCGHHdQYO384udh4GaBrRx2?=
 =?us-ascii?Q?vvNyRaWL8sinvZVQerSRqLlIXyapn8/x7kS8tHtra8/iolk5mWjeD+lCkniS?=
 =?us-ascii?Q?IoixAcULzRFOMYNBdfHakjJ/Z2w3WYhGFB5wvXlruCYww/Wx40ta+PSnluKb?=
 =?us-ascii?Q?sg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	pdfJDmhErYPbz49RQwa6Us2VON+0vAs8OScRccPrsosUjVYJF5tSX+xd8rmqI+4CNdLCfv0nzR1L2qm9z7doL+lG16sHHid9wumozx5kR+TMl9xA1sAEvJvocjhGh+YsaFE3N6SKV3c5i+K3IHqijDuodmLEs81+LDHH0qdPJfGo5v6yUlKPqRuBH8A5yj2l7uNCVZcEg3apCW4c473M/J+ZTTC8Y8vf179XQc1a9Y8xmaXVrOUYrwLfbSg1hLJwbESm3gnI5UfsKyTK/xnKfNPUirqNbGxaLiR0qQE4NtSMEenVteFmpzJevkcYPyTfLI7nTjo4Aly3jQDpL6GQjcLeQTc8K5bopZSuCP4yX9euzLXjrL9yav6g/PXZxnP3oSfM66OFPBUwojTqtefwziiKTkmwQoseFjvar+8T0IwaJurH6AOZ+1yDN/YSArfx7hf2j/irjTvECLeYbkEKRXFdQIX8cJoh8bKAbI7+rOBOKiiqFN+eqd9zk/ZKkt2KycE93yhuodEwZIos2loOY+PkrVgefzVt1R4sVgrT+TiD9mBvarLEotvXK+il261Gv1vIUveA6EyiInWlFIFqVP4QT0rJrb6/Qz7LlrZRJDM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71c2bf7c-5a0c-49a8-61c0-08dc687a918a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 18:31:21.7762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F654BG1i1AfzDL4H4QpesMkoIZlwCZj2OEgbhyXLyFSTqypYCbTzuzCtLDOJI64Qe8V0euwIBME5QYHph0kN2WpOyAtWYZD9rWmRG5IRDNM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6887
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-29_16,2024-04-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 bulkscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=632
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404290120
X-Proofpoint-GUID: KPDElFbpYCpsg7Bgm4dTRpGzEWPyMiN0
X-Proofpoint-ORIG-GUID: KPDElFbpYCpsg7Bgm4dTRpGzEWPyMiN0


Kees,

>> This patch seems to be lost. Gustavo reviewed it on January 15, 2024
>> but the patch has not been applied since.
>
> This looks correct to me. I can pick this up if no one else snags it?

I guess my original reply didn't make it out, I don't see it in the
archives.

My objections were:

 1. The original code is more readable to me than the proposed
    replacement.

 2. The original code has worked since introduced in 2012. Nobody has
    touched it since, presumably it's fine.

 3. I don't have the hardware and thus no way of validating the proposed
    changes.

So what is the benefit of me accepting this patch? We have had several
regressions in these conversions. Had one just last week, almost
identical in nature to the one at hand.

I am all for fixing code which is undergoing active use and development.
But I really don't see the benefit of updating a legacy driver which
hasn't seen updates in ages. Why risk introducing a regression?

-- 
Martin K. Petersen	Oracle Linux Engineering