Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1549577lqa; Mon, 29 Apr 2024 11:34:00 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUA4dUFCgXwcrlIobtdVrfapm3OUHuIKunBpvoJOMT+kuG1haJbFyLOvmmOo+j3d8RMuBCOxrz6kzt0bJi7QwY4VJGDhFRvMWY6xH7dyA== X-Google-Smtp-Source: AGHT+IFQXdpucGp+vOqA52S2+99j40j/KKJ9kMpP2fZQ8uYTEEZNcf6INMp4Jp9nFwXW293PresJ X-Received: by 2002:a17:902:d648:b0:1e7:89af:f267 with SMTP id y8-20020a170902d64800b001e789aff267mr9810897plh.37.1714415639687; Mon, 29 Apr 2024 11:33:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714415639; cv=pass; d=google.com; s=arc-20160816; b=ZIcO2j5UKy3Is2CHOUGbEW4pS8Wdw4G3izp1xjEmCf8sUTs50ErNlHfUL1nc7kkuxd sSG3het2r3Tbb329864CXbXCNWULmc3pQNnn0k9y9M3gSUhVry9jRvzSs2ObDIK3mlfS QHAgGO8aQkrDvXdALwdINjzOqVIDM+iGWiC3p2GAudACTzVrdYhHN4ZEFJnkVgA2Myov /MTlARE5NrpzzdORmq8BlD0BCFIFwzfW5zV/XSS98vTWp5wi9TzWbQY7gcMFH0D+VL/1 POYn8rugmgAwLw6Uu8B8jRCVue9/pkMNV0gzXN9bOlvxJi3qEbHiia4Bv5Ctd2u8kQuU Ur2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=2kpOLjd1RsRGoMgjZcS9EsszKwG0ZQhgAo+c26was84=; fh=HLfUndBFaPoSEq5ZsnLQY84lsMExs/2VlV1ZdXkAzLg=; b=lAi0tUCBD1xL+i672hF194zCjBP4igT08SFpDy+6oXyuCahMesVEXTZjH6hFrFKJ9j WadMWVFmPoBmW8MEZrGIg7x4+JqsOHGsmTKvm0QPs2UAXBzTpcRS+fWgTep8JH8aW6C/ HLHtNBHpdr+JqOCYX02BEzID+a97bJ28KBm9hfGJ6JUSBCeNpKr1IYV28yf0QRecNBtj H/X71fi8oRo37CxovR/g/KcYxABVJY4A2Y2OJS9sfPzYlpBsQ3wvr5CBcV9TPJ/67Sk5 FXyIhwmPoWUufNlzlgW9mFl4/63usENxGwDCglcOfxm9q0nma4uFagxs7HIVtL1p5C9E wVfQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=amzwYIlz; arc=pass (i=1 spf=pass spfdomain=wanadoo.fr dkim=pass dkdomain=wanadoo.fr dmarc=pass fromdomain=wanadoo.fr); spf=pass (google.com: domain of linux-kernel+bounces-162830-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162830-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=wanadoo.fr Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id k5-20020a170902ce0500b001e9043deab4si17817693plg.611.2024.04.29.11.33.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 11:33:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-162830-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=amzwYIlz; arc=pass (i=1 spf=pass spfdomain=wanadoo.fr dkim=pass dkdomain=wanadoo.fr dmarc=pass fromdomain=wanadoo.fr); spf=pass (google.com: domain of linux-kernel+bounces-162830-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-162830-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3C638281C17 for ; Mon, 29 Apr 2024 18:33:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1732E12A15A; Mon, 29 Apr 2024 18:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b="amzwYIlz" Received: from smtp.smtpout.orange.fr (smtp-20.smtpout.orange.fr [80.12.242.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53FB683CBA; Mon, 29 Apr 2024 18:32:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.12.242.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714415577; cv=none; b=s5TKqHFJh0MoNh2GkNeXPm4qv7saVxUj2RG0/LQHj8TA27/3dzejdj+XaiheW0JLv74xkEDzBuVqvdCQp1yKvTqFs6ZBTRNmklRn5l4nzI+Vp1dVD8HrEbCzGek9IlASfhthLqVWwD2n/SxH3wJHd/dmCT+TGsN2iIj0QyXNEPs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714415577; c=relaxed/simple; bh=km++YSXFjLJWolJR5xpxNqeUcqNq1cJFCz/rYworjU8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AAw0SRRp/lJ/4TsrOkmpbjXMdCBO6UptcWnHrGgmAK53DlB4O2bq7hqdDG+/VmdNK5lyeaWa60YD7biVfcwgXdyqcK7vxQowx4t8j8rbqs8VvarZsHeZOJGdTatACHlHWX4auFS9urTivU3OKQY9362YjtluLyEa4j+AK7saCPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr; spf=pass smtp.mailfrom=wanadoo.fr; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b=amzwYIlz; arc=none smtp.client-ip=80.12.242.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wanadoo.fr Received: from [192.168.1.37] ([86.243.17.157]) by smtp.orange.fr with ESMTPA id 1VmksUnBSiGtU1VmlsQI2r; Mon, 29 Apr 2024 20:31:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1714415492; bh=2kpOLjd1RsRGoMgjZcS9EsszKwG0ZQhgAo+c26was84=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=amzwYIlzPbcKaAQJXOdD545sUIppqdGaR/8v1JITt97n7KazHFyAzCgHaFyuN7LWe iOxrYE7qhUuW20IWvMWtioSxORH+y48F7Q3yy2cc5F8Ql6FpEHY36vMboQ7ufkO/3L y5wn2hGZUXQFKtjaxzi9v+1LQWJ0BJMiS4rtAlQV0lV+PtY2Y2gC2albLo0NqR9qTL a7xYq7aH5nQyi17j1wkrFAaJM6Ji3qPAjctofHLJqOOn5Nv78NuwmeoEpzOTULElV4 lWsBbCy/xzDvcn0ZjBZdOpSXbi3nLsrYiyD4aSiW9unMNxET/z90DHbWfn96WEgGvk IZJdstbFJyloQ== X-ME-Helo: [192.168.1.37] X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 29 Apr 2024 20:31:32 +0200 X-ME-IP: 86.243.17.157 Message-ID: Date: Mon, 29 Apr 2024 20:31:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv To: AngeloGioacchino Del Regno , Pavel Machek , Lee Jones , Matthias Brugger Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <16df315e-8a05-49a4-ac07-d1ed150c9317@collabora.com> Content-Language: en-MW From: Christophe JAILLET In-Reply-To: <16df315e-8a05-49a4-ac07-d1ed150c9317@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 29/04/2024 à 10:13, AngeloGioacchino Del Regno a écrit : > Il 28/04/24 20:27, Christophe JAILLET ha scritto: >> In "struct mt6370_priv", the 'reg_cfgs' field is unused. >> >> Moreover the "struct reg_cfg" is defined nowhere. Neither in this >> file, nor >> in a global .h file, so it is completely pointless. >> >> Remove it. > > Sure > >> >> Found with cppcheck, unusedStructMember. >> >> So, remove it. > > Again?! :-P Yes. This way we safe twice the memory space :). > >> >> Signed-off-by: Christophe JAILLET > > > Anyway, this commit misses a Fixes tag; please add the relevant one, > after which, Will do, but this patch does not fix anything. It is just a clean-up. CJ > > Reviewed-by: AngeloGioacchino Del Regno >