Received-SPF: pass (google.com: domain of linux-kernel+bounces-162834-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 29 Apr 2024 11:35:13 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, PJ Waskiewicz <ppwaskie@kernel.org>
CC: Dan Williams <dan.j.williams@intel.com>, <linux-cxl@vger.kernel.org>,
	<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] cxl/acpi.c: Add buggy BIOS hint for CXL ACPI lookup
 failure
Message-ID: <662fe860eb889_1487294e8@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <ce49c67c24f57ffab166d688a1c9e3139733f412.camel@kernel.org>
 <20240429153138.GA681245@bhelgaas>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240429153138.GA681245@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?qcbsXCv9/d+2QV3ejE4Yj7SI/fiZ4/UEF1TAXE39o59yolx2DW7bQjtjTu?=
 =?iso-8859-1?Q?A5qEcmwu8Euy0GR3URHdt31Mp3GCQhitJgTzrzchOIsd4+De4/Z/5zzj0T?=
 =?iso-8859-1?Q?CRK4BCP2X0SlYVOZHcfUmDca+t9k5TLP0ifW5QIyv0B2XmX0NfKZMecv0p?=
 =?iso-8859-1?Q?uAu+vg3XwFZJACoQb4S0Swbv6aMnY/cblX61oU60EUhlsIGuYRzvlW+OYS?=
 =?iso-8859-1?Q?rPUC1SJwslsoR4NZizKOBdhBZqJ90r8UJzMAdsX7V0vWfMpfv0Cfj3LPhQ?=
 =?iso-8859-1?Q?T2okU8FNm2PCYo816vpW7yD6ux9fIVSKn+FEaYx/jaYp4/oWxQiWGBLTUj?=
 =?iso-8859-1?Q?Gcs2Qo3/ztRkkuMnuWPTtyBaq1wdFijt4PXcLJlWekQEA75NoFXlkOs2F6?=
 =?iso-8859-1?Q?StyT0Yo8FALDt/evvAkNT9ZgSajxy8jS+9vAASjb2IazWWatqzoeegjjBK?=
 =?iso-8859-1?Q?IhfgB+bUXSzwOQAeoHpI6mOKr0RIi424lblJZd1o3/o2qbF+E/zU5Mv/eP?=
 =?iso-8859-1?Q?+zNj9C2fiqe1rTkGcn05ityWucTkVHtn/nT257pPAw6s1LxzaZgF8PunjK?=
 =?iso-8859-1?Q?QLg9TOnPeZ/ttOyqpX3UPlVKRYJAtYKZdLx1rBApBPhwARXY5nYRQTqkBa?=
 =?iso-8859-1?Q?i4SMDlDrUY3jcVxHeHYTCz77R9SFsvoBHA/3alsKpB3sOxa3F8SrU3HeAc?=
 =?iso-8859-1?Q?PeFAOHOxUCplAkoynRLMWpOd4HA15MQ2RJva/buAwBJV26sAx6hcQvlu1m?=
 =?iso-8859-1?Q?bX2fHmlfNhKYd5vL/UHSDufehAe09tAm2GhlNtnCU4UYu8S06ceg/qixDt?=
 =?iso-8859-1?Q?ygOnuIWdlqONZHVFxpO/ULbD8/3hT6tY0A2v1x7rkMYqWUtlx0i3yLjhZb?=
 =?iso-8859-1?Q?3/wu9RTgWbBIIBJfQvF2XZ/s4Z/DaTWt31voDYAKuy7fa9/RFWN2Qhm8tG?=
 =?iso-8859-1?Q?LCMo9xBStn/iL2GYJUVWn9yVp4SFcV3judIUKuFeWhjFzOvCzKyCjITciV?=
 =?iso-8859-1?Q?FgeeBFxv+JuCtdtUWEggXM5Cm8nlkqJ4r2x0N7JE8etLfkJKrF5sa3QwW2?=
 =?iso-8859-1?Q?hNtpxd2nPvdlluqRMxdydOG3pq1uTWo3Ajld4rdOTRa5tgj8+ISFWppJjS?=
 =?iso-8859-1?Q?6QOWY2BJ2PC/n7ZKxVZ486YS3SyA6275xZ7RDTHxBnMdsXTOON4UqI7mnX?=
 =?iso-8859-1?Q?dBgJJ+3KJPvpKYnaDtBvlQQJVANh3mR+30fsakzGrXE3ScQFSGrqOoqBX4?=
 =?iso-8859-1?Q?B+9riPgpUPuT8fk/mlfo72cLtlyGzITFRhwY+CWxdESAp8H7F96v4A4xQQ?=
 =?iso-8859-1?Q?09m7JYYz9PVM2LFAwweKE0d/KGD0Q83VvUYicLyOewpjujg5Q3jFY0fVLS?=
 =?iso-8859-1?Q?0EdbNTsfqAGCJcoNHnh8I7lNpPQgdlovU36w0IKJwzb51cwDh1qUxbut5i?=
 =?iso-8859-1?Q?MbMX7mVk+wSp5xIoxxboRhoXvOfY8AFcZ4hsG1oMgEnergM2R1o7L4vv2p?=
 =?iso-8859-1?Q?BYNRZ9sRGjVcFx0W1dX1Fos4K51eA9311rabfU2Fse8E2VUf4Ep3aiC1dU?=
 =?iso-8859-1?Q?3pHxm971VIq8h7girs6Wxj3PTYh36uT0hauGCv+8jzj0Dyb85f3r4D1VSF?=
 =?iso-8859-1?Q?MujZQ0JM/A4UbQeOC6m/VeyKqAbwx0edDsg4I7GIjew9/dJnexCkbaLg?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 02c175be-cf80-41d4-c0c3-08dc687b1c9a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 18:35:15.1421
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ULT/5mcgLDWE3WwqoEBrWHsrrmVjjTVkgOzlHmxFudj9JITzpZTy+DCIJ/LZpxW1Azdb0n3na1nmpnofMq1in2QR9VmZ+t7MQq6ZDpV2sOg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7721
X-OriginatorOrg: intel.com

Bjorn Helgaas wrote:
> On Sun, Apr 28, 2024 at 10:57:13PM -0700, PJ Waskiewicz wrote:
> > On Tue, 2024-04-09 at 08:22 -0500, Bjorn Helgaas wrote:
> > > On Sun, Apr 07, 2024 at 02:05:26PM -0700, ppwaskie@kernel.org?wrote:
> > > > From: PJ Waskiewicz <ppwaskie@kernel.org>
> > > > 
> > > > Currently, Type 3 CXL devices (CXL.mem) can train using host CXL
> > > > drivers on Emerald Rapids systems.? However, on some production
> > > > systems from some vendors, a buggy BIOS exists that improperly
> > > > populates the ACPI => PCI mappings.
> > > 
> > > Can you be more specific about what this ACPI => PCI mapping is?
> > > If you already know what the problem is, I'm sure this is obvious,
> > > but otherwise it's not.
[..] 
> It's just a buggy BIOS that doesn't supply _UID for an ACPI0016
> object, so you can't locate the corresponding CEDT entry, right?

Correct, the problem is 100% contained to ACPI, and PCI is innocent. The
ACPI bug leads to failures to associate ACPI host-bridge objects with
CEDT.CHBS entries.

ACPI to PCI association is then typical pci_root lookup, i.e.:

        pci_root = acpi_pci_find_root(hb->handle);
        bridge = pci_root->bus->bridge;