Received-SPF: pass (google.com: domain of linux-kernel+bounces-162862-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 29 Apr 2024 12:55:17 -0600
From: Alex Williamson <alex.williamson@redhat.com>
To: Nipun Gupta <nipun.gupta@amd.com>
Cc: <tglx@linutronix.de>, <gregkh@linuxfoundation.org>,
 <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>, <maz@kernel.org>,
 <git@amd.com>, <harpreet.anand@amd.com>,
 <pieter.jansen-van-vuuren@amd.com>, <nikhil.agarwal@amd.com>,
 <michal.simek@amd.com>, <abhijit.gangurde@amd.com>,
 <srivatsa@csail.mit.edu>
Subject: Re: [PATCH v6 1/2] genirq/msi: add wrapper msi allocation API and
 export msi functions
Message-ID: <20240429125517.693714ef.alex.williamson@redhat.com>
In-Reply-To: <20240423150920.12fe4a3e.alex.williamson@redhat.com>
References: <20240423111021.1686144-1-nipun.gupta@amd.com>
	<20240423150920.12fe4a3e.alex.williamson@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Tue, 23 Apr 2024 15:09:20 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:

> On Tue, 23 Apr 2024 16:40:20 +0530
> Nipun Gupta <nipun.gupta@amd.com> wrote:
> 
> > SI functions for allocation and free can be directly used by  
> 
> We lost the ^M in this version.
> 
> > the device drivers without any wrapper provided by bus drivers.
> > So export these MSI functions.
> > 
> > Also, add a wrapper API to allocate MSIs providing only the 
> > number of interrupts rather than range for simpler driver usage.
> > 
> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> > ---
> > 
> > No change in v5->v6
> > 
> > Changes in v4->v5:
> > - updated commit description as per the comments.  
> 
> I see in https://lore.kernel.org/all/87edbyfj0d.ffs@tglx/ that Thomas
> also suggested a new subject:
> 
>     genirq/msi: Add MSI allocation helper and export MSI functions
> 
> I'll address both of these on commit if there are no objections or
> further comments.  Patch 2/ looks ok to me now as well.  Thanks,

Applied series to vfio next branch for v6.10.  Thanks,

Alex