Received-SPF: pass (google.com: domain of linux-kernel+bounces-163030-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <8d384dcf-8688-ce7d-1dcf-432aad706221@intel.com>
Date: Mon, 29 Apr 2024 13:56:53 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] dmaengine: idxd: Avoid unnecessary destruction of
 file_ida
Content-Language: en-US
To: Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>
CC: <dmaengine@vger.kernel.org>, linux-kernel <linux-kernel@vger.kernel.org>,
	Lijun Pan <lijun.pan@intel.com>
References: <20240130013954.2024231-1-fenghua.yu@intel.com>
 <b4d845d8-24e3-43ce-b1d4-e121f799e26c@intel.com>
From: Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <b4d845d8-24e3-43ce-b1d4-e121f799e26c@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmdURThzMHM2YW9MWDNRNVA4V0NtZXlWRWE5Rm9FQXcvNW9WZUFic0Y3Mnk4?=
 =?utf-8?B?L2hLc3hyYXBKL0hsa2V5cjY4OVExbjdlM0Z0MFJKN0d4MGhiQUFmaDBGWkZ5?=
 =?utf-8?B?QTlFem9XTWtOTmQycEFBNU5hdUl6bDFHN0NhTmZoSU5tWnJBRnhMdDVUdWdT?=
 =?utf-8?B?L3NpanhmWHcxdHUzbzc5TG9NcnVlOVdhc05WR0hnWXc0V29NOFlSSTF4NnJZ?=
 =?utf-8?B?OThMY3Q2Ylkxa0lmODNBdGVOTmJHNHQyNEUrTG81TnZuV3JPdXRLZGh4N1JI?=
 =?utf-8?B?aFpPT2lNSkpwd0c5ek5XNlo5dkJSSXpGNmlMQnlaV2JpVnlHem5hZU9YK0pt?=
 =?utf-8?B?L2dRZ3hZazF4UE1TNUxSK3BuZlc3cm5abmtudDVkTlFUUURjcFhZbXREaDNn?=
 =?utf-8?B?dGhyQ1ZZSlV6VEdCaXdFZHM3dmhRN1JWYXV6dmU3NEFpT3FJY1lxSVVtMjVi?=
 =?utf-8?B?V1hGWC9YQUpWTTcwSTdKbm4zaWEyT0xIcFMvWHFZUFZHUHVRNThVbVpiK0E3?=
 =?utf-8?B?R1VSZW12TDErd2lNaThyTE9GNDhnUE5UMVBxN1RMVFZodHF6T1lERFlZcXpT?=
 =?utf-8?B?cHJwa1NaMFVlSC91bXJzOXdlKzAyT2pZb25JOGNXNi9HbnN2MWJIT3JiS2JY?=
 =?utf-8?B?OU41czd3UW9GdHpRcThReUtLUUZQaFRZRUFzYWhuTm5EU2lqL2tReHAycS83?=
 =?utf-8?B?Y2g1anZFbWJBNHhMMzA5ZVAycVUyOWczYW9wOGxMdVNaQzczQUFxTllIRGZD?=
 =?utf-8?B?ZzNPdmQwOWoyUnR3bHUzM2hXdElKVUNnUkJYMjJrY3dJSkxDMWFTaFhGVTVL?=
 =?utf-8?B?RGY4ZHBhOFlPa0ZTR2hEUG1sZGJ4ZzJIR3dUd3ZQWnIvendBcVF2Ry9pSFUw?=
 =?utf-8?B?My9oU0NpSkpmclpTc0xGVHg4bFNkZUJVVWNNRmJ3MDgxUDdHN0xqa3c1dEI5?=
 =?utf-8?B?a3N3a01vMmp4WWlkZlV3SzZ4Q3pKVmszWjVMOEJIbzl1ZFg0YVZEVVB4ck5M?=
 =?utf-8?B?YXdXdkZtT3JBd0ZneDRtOHRSaWl0TTg0dUVMd2RraUg2NXFtTUIvajlZaFFU?=
 =?utf-8?B?dVNML3R4WDJvQ3JJRGFaY1FxUVlVUUFSVGVBWEZKMi9VMFNiRXdlMlhTVjRV?=
 =?utf-8?B?MjJDRmZ6L0tXRHVWa0dIc2xyRkpmZXBnYlgzTVJ3dlpFL003Q1VZRDY0V0pJ?=
 =?utf-8?B?OUpoU0tBY1NQWEhFNlZYWHg5TGJ2eklPaXlhanlFRlNaUUNaY3lrZkxVbW9l?=
 =?utf-8?B?aDFRb2ZaVWVVZlFjQzRFVmtrblJaY2tha0paZEV0RFVmSUZLZm9YenF0ZmVt?=
 =?utf-8?B?aCsvdGQwOVNHOUZJTGpRZkdWZk5Sak10VUFocy9lVGFBSWd5ZGtDMDlNQ3VJ?=
 =?utf-8?B?VHhFT2lEaUNHclVWaWZhUWw1OU8zVW9laDhpTUxiNGZZaVNlMjBxTXQ0cmJK?=
 =?utf-8?B?MEJRZ2RUK0FIeE5WdVRMQXRhcDhheG1IT25hN1FHYXUzYjV3UTdRTmo1NGxF?=
 =?utf-8?B?Y21nbmVjMkNMZzVJMjZsVTduZGxySTdGVEVoVExOUUE3YmN2S0tWeHYwYWdC?=
 =?utf-8?B?WXBBWG9NZWNOM0MxNkJyelhCV0xlYUZtWlo0OWhLMEdWOVFsdzJ5NmQ5aWNp?=
 =?utf-8?B?UU43cVBOL09OcEZzbXprQUo0aENmdGtkYXJWRGJYbjhTMzB1RzFmT0xnc2lk?=
 =?utf-8?B?OVROWWt2amUyZCs4eUtJdnlseFY5SEdaVzlnR25BZEI3cDZBMUFWa2pHU3RB?=
 =?utf-8?B?WWhtV0czVHQ4MDFRYlI3eVpRZEpXcEtRYkZhOTViQmFsOGVZaHBialVjRGNJ?=
 =?utf-8?B?ejB1MzEySFp1UUpFYWpYNkpEMlZPNkoxTkE0ajVaUUU1OUszcndmY1gwREZn?=
 =?utf-8?B?YzNTQTIyOGNnRXN5M1ZoMVpMSEgvOVVFbmFVRFBlczA1eW9iL0UwajRzcFk0?=
 =?utf-8?B?Q1VPMGcyQlhQQ2NFaEhwczdybGZ2bjJBMjFkZkZBc2RQZ0JRVW9EQlpKQ3B4?=
 =?utf-8?B?dHRUQVRId0Z1N1hMRjVadUtMWW1uNzM0YThmUWRtZFZQNnlpVXluZnZUbEZZ?=
 =?utf-8?B?MGI2bGJDUDN3ZmdxL2hTbGh3WHBXaDZQRnIxSjNlVTZQUzhOc1NrQlN2Wng4?=
 =?utf-8?Q?kww6X775Alea4eqgc/PJzzwEP?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 381503e7-c255-4f8b-5ddb-08dc688ee342
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2024 20:56:48.9164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eysFHx5EuM7N44kqkNfsezcd2PDWf/DOfIxhbx56R9jwQdm5tPXE7cr3JojWZvu51YjUESRtfkFU2W58V7G3KQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5263
X-OriginatorOrg: intel.com

Hi, Vinod,

On 1/30/24 07:34, Dave Jiang wrote:
> 
> 
> On 1/29/24 18:39, Fenghua Yu wrote:
>> file_ida is allocated during cdev open and is freed accordingly
>> during cdev release. This sequence is guaranteed by driver file
>> operations. Therefore, there is no need to destroy an already empty
>> file_ida when the WQ cdev is removed.
>>
>> Worse, ida_free() in cdev release may happen after destruction of
>> file_ida per WQ cdev. This can lead to accessing an id in file_ida
>> after it has been destroyed, resulting in a kernel panic.
>>
>> Remove ida_destroy(&file_ida) to address these issues.
>>
>> Fixes: e6fd6d7e5f0f ("dmaengine: idxd: add a device to represent the file opened")
>> Signed-off-by: Lijun Pan <lijun.pan@intel.com>
>> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> 
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
>> ---
>>   drivers/dma/idxd/cdev.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c
>> index baa51927675c..3311c920f47a 100644
>> --- a/drivers/dma/idxd/cdev.c
>> +++ b/drivers/dma/idxd/cdev.c
>> @@ -1272,7 +1272,6 @@ void idxd_wq_del_cdev(struct idxd_wq *wq)
>>   	struct idxd_cdev *idxd_cdev;
>>   
>>   	idxd_cdev = wq->idxd_cdev;
>> -	ida_destroy(&file_ida);
>>   	wq->idxd_cdev = NULL;
>>   	cdev_device_del(&idxd_cdev->cdev, cdev_dev(idxd_cdev));
>>   	put_device(cdev_dev(idxd_cdev));

I noticed this patch was not merged to upstream yet. The patch is still 
cleanly applied to upstream.

Could you please help merge this patch?

Thanks.

-Fenghua