Received-SPF: pass (google.com: domain of linux-kernel+bounces-163069-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: i1719461a:Fastmail
Date: Mon, 29 Apr 2024 15:25:34 -0600
From: Lyndon Sanche <lsanche@lyndeno.ca>
Subject: Re: [PATCH v3] platform/x86: dell-laptop: Implement platform_profile
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: pali@kernel.org, W_Armin@gmx.de, srinivas.pandruvada@linux.intel.com,
	ilpo.jarvinen@linux.intel.com, Matthew Garrett <mjg59@srcf.ucam.org>,
	Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com
Message-Id: <MI3QCS.72BHE7ZBD8ZE3@lyndeno.ca>
In-Reply-To: <bcd4fc9f-8900-46bc-9577-d95fa67adc25@amd.com>
References: <20240425172758.67831-1-lsanche@lyndeno.ca>
	<20240429164844.7544-2-lsanche@lyndeno.ca>
	<5cbb8981-5e24-4dce-a78f-1cabc29f08e3@amd.com>
	<bcd4fc9f-8900-46bc-9577-d95fa67adc25@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed


On Mon, Apr 29 2024 at 12:51:31 PM -05:00:00, Mario Limonciello 
<mario.limonciello@amd.com> wrote:
> On 4/29/2024 12:45, Mario Limonciello wrote:
>> On 4/29/2024 11:48, Lyndon Sanche wrote:
>>>   #define CLASS_KBD_BACKLIGHT 4
>>>   #define SELECT_KBD_BACKLIGHT 11
>>> +#define SELECT_THERMAL_MANAGEMENT 19
> 
> I think you should insert this into dell-smbios-base.c under 
> call_blacklist.  This will prevent userspace from fighting with the 
> kernel on the same data when this code goes in.

Good idea, I have been using smbios-thermal-ctl for checking the state 
when testing. I will include this in the patch, then smbios-thermal-ctl 
cannot interfere.

Thanks,

Lyndon