Received-SPF: pass (google.com: domain of linux-kernel+bounces-163087-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240422083645.1930939-1-howardchu95@gmail.com> <Zi_slOlsZBjTbNIH@x1>
In-Reply-To: <Zi_slOlsZBjTbNIH@x1>
From: Namhyung Kim <namhyung@kernel.org>
Date: Mon, 29 Apr 2024 15:06:05 -0700
Message-ID: <CAM9d7cjFYPPusN+yGEHe5B5hwPoiLqXj=Q0DqjBaZR9gTAADTg@mail.gmail.com>
Subject: Re: [PATCH v1 1/4] perf record: Dump off-cpu samples directly
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Howard Chu <howardchu95@gmail.com>, peterz@infradead.org, mingo@redhat.com, 
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, 
	irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, 
	zegao2021@gmail.com, leo.yan@linux.dev, ravi.bangoria@amd.com, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 11:53=E2=80=AFAM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Mon, Apr 22, 2024 at 04:36:45PM +0800, Howard Chu wrote:
> > Parse off-cpu events using parse_event(). Change the placement of
> > record__config_off_cpu to after record__open because we need to write
> > mmapped fds into BPF's perf_event_array map, also, write
> > sample_id/sample_type into BPF. In record__pushfn and record__aio_pushf=
n,
> > handle off-cpu samples using off_cpu_strip. This is because the off-cpu
> > samples that we want to write to perf.data is in off-cpu samples' raw_d=
ata
> > section:
>
> Hey,
>
>         This lacks a cover letter and the chainig of patches so that b4
> can fetch the series.
>
>         Also all 5 patches have the same summary and different
> descriptions and contents, can you please rework the patch series, using
> 'git format-patch', and make the description reflect what each patch is
> doing?

He already sent out v2.

Thanks,
Namhyung

https://lore.kernel.org/r/20240424024805.144759-1-howardchu95@gmail.com/