Received-SPF: pass (google.com: domain of linux-kernel+bounces-163141-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <Zh93hKfHgsw5wQAw@krava> <20240420042457.3198883-1-dmitrii.bundin.a@gmail.com>
 <9ca4b5dd-20be-79ac-52eb-a19c0c82280f@iogearbox.net>
In-Reply-To: <9ca4b5dd-20be-79ac-52eb-a19c0c82280f@iogearbox.net>
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date: Mon, 29 Apr 2024 16:33:20 -0700
Message-ID: <CAEf4BzZz6n3FS-mWY1epa4y6RBLJggJ8Y-WEW-uhM11w3qMjCQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next v3] bpf: btf: include linux/types.h for u32
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>, olsajiri@gmail.com, andrii@kernel.org, 
	ast@kernel.org, bpf@vger.kernel.org, dxu@dxuuu.xyz, eddyz87@gmail.com, 
	haoluo@google.com, john.fastabend@gmail.com, khazhy@chromium.org, 
	kpsingh@kernel.org, linux-kernel@vger.kernel.org, martin.lau@linux.dev, 
	ncopa@alpinelinux.org, ndesaulniers@google.com, sdf@google.com, 
	song@kernel.org, vmalik@redhat.com, yonghong.song@linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 8:54=E2=80=AFAM Daniel Borkmann <daniel@iogearbox.n=
et> wrote:
>
> On 4/20/24 6:24 AM, Dmitrii Bundin wrote:
> > Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> > the header linux/types.h. Including it directly on the top level helps
> > to avoid potential problems if linux/types.h hasn't been included
> > before.
> >
> > The main motiviation to introduce this it is to avoid similar problems =
that
>
> nit: spelling
>
> > was shown up in the bpf tool where GNU libc indirectly pulls
> > linux/types.h causing compile error of the form:
> >
> >     error: unknown type name 'u32'
> >                               u32 cnt;
> >                               ^~~
> >
> > The bpf tool compile error was fixed at 62248b22d01e96a4d669cde0d7005bd=
51ebf9e76
> >
> > Fixes: 9707ac4fe2f5 ("tools/resolve_btfids: Refactor set sorting with t=
ypes from btf_ids.h")
> >
> > Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@gmail.com>
> > ---
> >
> > Changes in v2: Add bpf-next to the subject
> > Changes in v3: Add Fixes tag and bpf tool commit reference
> >
> >   include/linux/btf_ids.h | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> > index e24aabfe8ecc..c0e3e1426a82 100644
> > --- a/include/linux/btf_ids.h
> > +++ b/include/linux/btf_ids.h
> > @@ -3,6 +3,8 @@
> >   #ifndef _LINUX_BTF_IDS_H
> >   #define _LINUX_BTF_IDS_H
> >
> > +#include <linux/types.h> /* for u32 */
> > +
> >   struct btf_id_set {
> >       u32 cnt;
> >       u32 ids[];
> >
>
> Lgtm, not sure if its worth it but also doesn't hurt and aligns the heade=
r
> from tooling a bit closer to the kernel one. Just to clarify, this does n=
ot
> fix a concrete issue today, so small 'cleanup' rather than 'fix'.
>

Adjusted commit message and pushed to bpf-next, thanks.

> Thanks,
> Daniel