Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1687717lqa; Mon, 29 Apr 2024 16:40:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXXtLBmhWuA+2QvKqFfEhX+qD1R12pT1lftarKH657cu678PUwyKayK196URMcreqqKzKt1tp9oETThIgC1IhjV5ZaSrcacrHcLOhHxww== X-Google-Smtp-Source: AGHT+IFHS/NSdW7JL8zdwWOuG7dTJmX3Wgda243ve00nSJOQhlcfHPUCbVDgCCbklE20S5UowAK4 X-Received: by 2002:a25:a022:0:b0:de5:4eef:542d with SMTP id x31-20020a25a022000000b00de54eef542dmr1030711ybh.57.1714434003299; Mon, 29 Apr 2024 16:40:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714434003; cv=pass; d=google.com; s=arc-20160816; b=Utnf1Mc/JWW1awtIhBFEL0VtzkPGGuDVc0NKH9OddJYHGvInweAAUbgt4/M2jbb1ZF fWlAz0Ji7ZId4TYFnG/gH8e0rqqQ3dGPjZsIVk7WGNgIwNl6pmqEhgcd97JtkMqoPMme CvyD1PCwvUDamFW3B7zszwJJ/HbgBk94VCo6NQSaBJcDrL2LvHKS3YjVSKjvrW+4D842 kaZIsW7K5QPbv/oj6oo5xWhK+IbiVyBx2oM2NXS3B0uzGUABjuGo46K5/MNRrvkzlIUz iyOM+cBWdJjlkQTKxYdlpOpNsQyVFHEDTpErpwoHCwujvjZ4+jbpwg9POEXb8eJHKLKm 9EoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Y7MgXOGlVLSsruR66RDz0IenAw3Zic8P5DPuYKlA2zs=; fh=Mm8hlFdBHUY0fyqKU/MWlqkizWEw7qYBWD0xRewgNf0=; b=PF/hWIf7YySPjqtEBwByuqvtbAGAbpDzTOYZZ2xgQpPs494A2K4kJ4ounSZFhTtpdL 35nqI7MMnc8mmcuO6hHQhBXdJYKdEn20lNBsPLIvgprvjuymbckk7j4o3OD1hnFuksGg bub3IGWdWNGTdE+cfseNVmUZ5ff5E1mrPgQANoRu9Ry6FMQpWz/rlZHzv0ukdNIDAt0o VCX4yGJ2xe39emrtwdGk6w/3UqcS10dNMe0fcSzAb+edmG0MsNlZza8DyYF1egEc+fqt 6WH7NZMjqI1naUUDqi7Ye6XnhOLXbUFXdPN+XPriDzgsS3wVykN7zzsWpFUuuosR8N3M qOqg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b=GntLG5WU; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-163155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163155-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h16-20020a37de10000000b0078f0eb3b04csi8007028qkj.713.2024.04.29.16.40.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 16:40:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-163155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kl.wtf header.s=key1 header.b=GntLG5WU; arc=pass (i=1 spf=pass spfdomain=kl.wtf dkim=pass dkdomain=kl.wtf dmarc=pass fromdomain=kl.wtf); spf=pass (google.com: domain of linux-kernel+bounces-163155-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163155-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kl.wtf Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 07B581C22611 for ; Mon, 29 Apr 2024 23:40:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 257BD194C74; Mon, 29 Apr 2024 23:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b="GntLG5WU" Received: from out-179.mta1.migadu.com (out-179.mta1.migadu.com [95.215.58.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC82126F07 for ; Mon, 29 Apr 2024 23:39:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714433994; cv=none; b=UEdSM8bqUMdqO2fFJ/hn9kdMpUD938WdpK2ksK+EulS7uZF66MIlOm+o6sx4fl+2XCD6hnuwJdt2Ybjiop4gN9Se/GnvyY+ZXGcTnPEYQ9jwxGwehzBbqw7tlk25YSe24Jn7On3OBIW9BMkYVXGmYPvqZ93U4giLatcuUxmWpEo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714433994; c=relaxed/simple; bh=Y7MgXOGlVLSsruR66RDz0IenAw3Zic8P5DPuYKlA2zs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rmi8HXVEIZtfiwIMAuh8pVrKKk9KEesrTi9+MhccgNcQUt2PO2Qu9iq0/AuUTAbt/u8GKJ1TvVVwzvciDTZ+OCEJk9ZrMQvqy8mvtgHLlRQvIvi3KC1bRgfG9xkyTY+goqHpOQ62Kq8M0jShviwUXG5uGUoU38vsulPcXX83W9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf; spf=pass smtp.mailfrom=kl.wtf; dkim=pass (2048-bit key) header.d=kl.wtf header.i=@kl.wtf header.b=GntLG5WU; arc=none smtp.client-ip=95.215.58.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=kl.wtf Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kl.wtf X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kl.wtf; s=key1; t=1714433990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Y7MgXOGlVLSsruR66RDz0IenAw3Zic8P5DPuYKlA2zs=; b=GntLG5WU9G8fjuihI2/3E0+kZcpvbOcLU18obq99uFSk9GQh0bPHBGrpB+1DCup/7uHTvW ipsdy5wJBmDw/Gh27VbmnYROtS8GpeM2gUY2rL4wfb5pjxoampsQMYoZmiKjwEhVO/D8/P +FxSeq/pUzZ9p9QxUXQVfrsYpA6l/35l4XkkKF6MAcSfnzYAQZ5WZv84t6Td4ZuE7xwr0P R34o93lu/QzSq6w8esw7wQ0L97Q395BcXOv9PzKJEzqWNQbgMemAgKYU07igkeoOsK1Gmk yo7quLl8vvxmhFfXKaGryrYqY2b1fCwLYdzcisMwlzj/2J31yQ6Tj70+URTE7w== From: Kenny Levinsen To: Jiri Kosina , Dmitry Torokhov , Benjamin Tissoires , Douglas Anderson , Hans de Goede , Maxime Ripard , Kai-Heng Feng , Johan Hovold , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Radoslaw Biernacki , Lukasz Majczak Cc: Kenny Levinsen Subject: [PATCH 0/2] HID: i2c-hid: Unify device wake-up logic Date: Tue, 30 Apr 2024 01:33:13 +0200 Message-ID: <20240429233924.6453-1-kl@kl.wtf> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Third time was not the charm[0]. After Dmitry's comment[1], and after looking some more at the I2C drivers, I have given up on removing the smbus probe for now. We can always revisit this later if the situation improves enough, but there are more important things to fix. Instead, go all in on the address probe with retry and use it for both initial probe and resume, replacing the previous retry on power on commands. This gives us consistency and a single place to update and document. [0]: https://lore.kernel.org/all/20240426225739.2166-1-kl@kl.wtf/ [1]: https://lore.kernel.org/all/ZixvUNooESC02cJK@google.com/