Received-SPF: pass (google.com: domain of linux-kernel+bounces-163198-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240427005626.1365935-1-zhouzhouyi@gmail.com> <059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop>
In-Reply-To: <059d36ce-6453-42be-a31e-895abd35d590@paulmck-laptop>
From: Zhouyi Zhou <zhouzhouyi@gmail.com>
Date: Tue, 30 Apr 2024 08:58:11 +0800
Message-ID: <CAABZP2y1Ge-B26BNRcCsga2h7RTdkF0jBZpUCZNcpNAusDGi4Q@mail.gmail.com>
Subject: Re: [PATCH] x86/rcutorture move CONFIG_HYPERVISOR_GUEST to kvm-test-1-run.sh
To: paulmck@kernel.org
Cc: linux-kernel@vger.kernel.org, frederic@kernel.org, boqun.feng@gmail.com, 
	joel@joelfernandes.org, neeraj.upadhyay@amd.com, qiang.zhang1211@gmail.com, 
	rcu@vger.kernel.org, lance@osuosl.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 7:22=E2=80=AFAM Paul E. McKenney <paulmck@kernel.or=
g> wrote:
>
> On Sat, Apr 27, 2024 at 12:56:26AM +0000, Zhouyi Zhou wrote:
> > CONFIG_HYPERVISOR_GUEST is a x86 specific kernel option, move to
> > kvm-test-1-run.sh to avoid ConfigFragment.diags in non-x86 platforms.
> >
> > Tested in both PPC VM of Open Source lab of Oregon State University and
> > local x86_64 server.
> >
> > Fixes: a6fda6dab93c ("rcutorture: Tweak kvm options")
> > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
>
> I like this general approach, but why not have something like a
> CFCOMMON.arch for the various "arch"s that need it?
>
> Better yet, I bet that there is already something somewhere in the
> Linux kernel source tree that knows what hypervisor Kconfig options
> each architecture needs.  If so, it would be most excellent to reuse
> that information instead of maintaining it separately in RCU.
Thank Paul for your great guidance and valuable advice!

I will do a thorough research on the above approaches.

Thanks again ;-)
Zhouyi
>
>                                                         Thanx, Paul
>
> > ---
> >  tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 4 ++++
> >  tools/testing/selftests/rcutorture/configs/rcu/CFcommon  | 1 -
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh b=
/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh
> > index b33cd8753689..75774bc70be7 100755
> > --- a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh
> > +++ b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh
> > @@ -68,6 +68,10 @@ config_override_param "--gdb options" KcList "$TORTU=
RE_KCONFIG_GDB_ARG"
> >  config_override_param "--kasan options" KcList "$TORTURE_KCONFIG_KASAN=
_ARG"
> >  config_override_param "--kcsan options" KcList "$TORTURE_KCONFIG_KCSAN=
_ARG"
> >  config_override_param "--kconfig argument" KcList "$TORTURE_KCONFIG_AR=
G"
> > +if uname -a | grep -q x86
> > +then
> > +     config_override_param "x86 specific option" KcList "CONFIG_HYPERV=
ISOR_GUEST=3Dy"
> > +fi
> >  cp $T/KcList $resdir/ConfigFragment
> >
> >  base_resdir=3D`echo $resdir | sed -e 's/\.[0-9]\+$//'`
> > diff --git a/tools/testing/selftests/rcutorture/configs/rcu/CFcommon b/=
tools/testing/selftests/rcutorture/configs/rcu/CFcommon
> > index 0e92d85313aa..cf0387ae5358 100644
> > --- a/tools/testing/selftests/rcutorture/configs/rcu/CFcommon
> > +++ b/tools/testing/selftests/rcutorture/configs/rcu/CFcommon
> > @@ -1,6 +1,5 @@
> >  CONFIG_RCU_TORTURE_TEST=3Dy
> >  CONFIG_PRINTK_TIME=3Dy
> > -CONFIG_HYPERVISOR_GUEST=3Dy
> >  CONFIG_PARAVIRT=3Dy
> >  CONFIG_KVM_GUEST=3Dy
> >  CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC=3Dn
> > --
> > 2.34.1
> >