Received-SPF: pass (google.com: domain of linux-kernel+bounces-163223-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 29 Apr 2024 18:23:51 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>, Dan Williams
	<dan.j.williams@intel.com>, Dave Jiang <dave.jiang@intel.com>, "Alison
 Schofield" <alison.schofield@intel.com>, Andrew Morton
	<akpm@linux-foundation.org>
CC: <linux-mm@kvack.org>, <nvdimm@lists.linux.dev>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Vishal Verma
	<vishal.l.verma@intel.com>
Subject: Re: [PATCH v2 1/4] dax/bus.c: replace WARN_ON_ONCE() with lockdep
 asserts
Message-ID: <66304827d2095_14872943c@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240416-vv-dax_abi_fixes-v2-0-d5f0c8ec162e@intel.com>
 <20240416-vv-dax_abi_fixes-v2-1-d5f0c8ec162e@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240416-vv-dax_abi_fixes-v2-1-d5f0c8ec162e@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jySzYJdCBGNTCUMzEQ0plU3pdEXSwIoLs2Ze3bEEdPbaKpHGY9eBseZhAsKk?=
 =?us-ascii?Q?HCSqNbstwLQwkV0RO6Iuz41lZYkkPyWNw0yHTHKhkrCUVVK+xTuW4E/Aow/2?=
 =?us-ascii?Q?y+gS4vKvk5+2xXWNbCKDWRiEYdZveit0pRfGqOpxA9ogGAqrsq2k/keRaYWD?=
 =?us-ascii?Q?0AByDZGKR12ADoQhpvyV0/7XMFKqRg8GKS28pE2g/yaomhto8AqU4T7gi1fN?=
 =?us-ascii?Q?1Of7o0auUf80D/3lco5XzWZjSmEigcQiEIweKd5Sh6RoMr4vUoew4SsbnRJ1?=
 =?us-ascii?Q?uRnQiNx0lTH2LxeTNRpNddDqbBj9QIwbH5ji0G5/nJFRme2Eg8zBPJOmUrYF?=
 =?us-ascii?Q?YXVIN70Lq2YyC6Lqf6QsibYhveVWb9c/WY4FdgtTzn/kDaLfKgpuDb/7VMPg?=
 =?us-ascii?Q?+DMM94ZSMiYagQxnIoKaXTk7Gvf/tePdT0fV4yHIHidOw6XF9gc+6/u9ray5?=
 =?us-ascii?Q?RjwD6onKHDwmQCRsabLGg/I4onO3UkOFH/E79b5AheEgcEvyTz/cmcXbxHG8?=
 =?us-ascii?Q?HoKqZQD7As22T/SgjlA/Ty1bV2USEFU7XXMLUDQbTBjkys4v88I8dsmafGNT?=
 =?us-ascii?Q?IKlNSrD2hC3QfICzKDWipjMa1A/yN9txebq011mtgFEd+ysavG5jsAlTrtLL?=
 =?us-ascii?Q?VPr2uaqZolCkM+d1zUPI6ZcD4CHMmDLBAcE5eM/lKXg12ipeGli/KUtTPFKa?=
 =?us-ascii?Q?RjPfpkQD/NiRBVwYP7a/NF7Q3MrMlYWc3tj/oghXjshJDwVH6VHlORVurtC9?=
 =?us-ascii?Q?+zl5OAWxRudXObPs+fslmEbf6/NTWVC1fj586ZudMuqhgzFUmyh4tHv9Nend?=
 =?us-ascii?Q?xlLnxDl6fpf9fyX+0A1txJp+iqdMJ7R8EkBku9H7wyLeA4MJJAybU1VEHDbB?=
 =?us-ascii?Q?r9S4LmAhmBHGePXGhi1Ft+xuiuZ3dUP9doUVnSxj5zAVNvI2i/S5b/lVhYSH?=
 =?us-ascii?Q?+kLTrLv8i7qmh9A3d8L3o3IGtCGjwj3bW5WNW6JwOH0V63Z5A6a2vNlPwhOP?=
 =?us-ascii?Q?KEjouu5TzD+7TigyVCviwkWfcFlyjovUu6QB37dqQs4DSJBL1LBQP05fWzmr?=
 =?us-ascii?Q?tXSKePB8hl3tPa2iiaoLW31athJoH5DWCL4OzGXfSTdN6vDnVLbbwdiJGxVU?=
 =?us-ascii?Q?XwIwJ+qopvNzYldU3aNgs8mm90Xqgx+NLSXQpCjMqx9GNsRUthwQzWi2+stS?=
 =?us-ascii?Q?QyaADWzq5JtbvlV5xYWsdN8wCHwRWUBfJWnrl2H+GjaBWP7Fvp/QxcqmKmuN?=
 =?us-ascii?Q?IQikiRfyFHnJ/Bk0XXy9pDQJH7rbUNLtsOy+zTbLi9+U49vh3Hasr9LXaobZ?=
 =?us-ascii?Q?cDvbUOyZM5+yry7sH4i57MnAprhsyfeIDtNSIQATJ0lkH3E7AmNEHRNvFHFL?=
 =?us-ascii?Q?pykgNRTPn7sWVfPT85m0woDvx+gyHbFsXdjHHR4feqP46NvzT5coxa2YVb75?=
 =?us-ascii?Q?KLjR34cerfudTjFLm1pwLeu2I4FZOYBTYTJkA2Zl448W1jyaRxAR46LD/iAf?=
 =?us-ascii?Q?Yj/Uxt6nocA0I6r0EX5pYZlrPc/c3PYklKrKbJvZajrmHotCIMHR3rSK8QGU?=
 =?us-ascii?Q?Dpgoro6vOzDWGEHL5xF8k4yyF8uffdmJY2fORNCXMsIZX3HQlXRqItTHMag+?=
 =?us-ascii?Q?eg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bb352971-4e8f-4150-55d2-08dc68b43323
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 01:23:54.2203
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2i/3hqKpMsCnPXeoAdBTFErYzLZfbDeHc5G/SgKQO4W3B9SDYEmoyOtPDaQ8JSFTYTOnNetzWP5yhRtWn1OD05eHHHN2PfZS9plVAUlp3iE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7351
X-OriginatorOrg: intel.com

Vishal Verma wrote:
> In [1], Dan points out that all of the WARN_ON_ONCE() usage in the
> referenced patch should be replaced with lockdep_assert_held, or
> lockdep_held_assert_write(). Replace these as appropriate.
> 
> Link: https://lore.kernel.org/r/65f0b5ef41817_aa222941a@dwillia2-mobl3.amr.corp.intel.com.notmuch [1]
> Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem")
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  drivers/dax/bus.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>