Received-SPF: pass (google.com: domain of linux-kernel+bounces-163224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6844a9d8-f1a7-738e-105c-e9c44f5c11f4@huawei.com>
Date: Tue, 30 Apr 2024 09:23:51 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH -next] proc: Remove unnecessary interrupts.c include
To: Andrew Morton <akpm@linux-foundation.org>
CC: <mcgrof@kernel.org>, <j.granados@samsung.com>, <brauner@kernel.org>,
	<david@redhat.com>, <willy@infradead.org>, <oleg@redhat.com>,
	<linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>
References: <20240428094847.42521-1-ruanjinjie@huawei.com>
 <20240429093549.f2b9c670f383bed627022f31@linux-foundation.org>
Content-Language: en-US
From: Jinjie Ruan <ruanjinjie@huawei.com>
In-Reply-To: <20240429093549.f2b9c670f383bed627022f31@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 2024/4/30 0:35, Andrew Morton wrote:
> On Sun, 28 Apr 2024 17:48:47 +0800 Jinjie Ruan <ruanjinjie@huawei.com> wrote:
> 
>> The irqnr.h is included in interrupts.h and the fs.h is included in
>> proc_fs.h, they are unnecessary included in interrupts.c, so remove it.
>>
>> ...
>>
>> --- a/fs/proc/interrupts.c
>> +++ b/fs/proc/interrupts.c
>> @@ -1,8 +1,6 @@
>>  // SPDX-License-Identifier: GPL-2.0
>> -#include <linux/fs.h>
>>  #include <linux/init.h>
>>  #include <linux/interrupt.h>
>> -#include <linux/irqnr.h>
>>  #include <linux/proc_fs.h>
>>  #include <linux/seq_file.h>
> 
> Within limits, we prefer that .c files directly include the headers
> which they use.  If interrupts.c uses nothing from these headers then
> OK.  If, however, interrupts.c does use things which are defined in
> these headers then the inclusion of those headers is desired.

Thank you, sorry I'm just learning the rules now.