Received-SPF: pass (google.com: domain of linux-kernel+bounces-163226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 29 Apr 2024 18:25:50 -0700
From: Dan Williams <dan.j.williams@intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>, Dan Williams
	<dan.j.williams@intel.com>, Dave Jiang <dave.jiang@intel.com>, "Alison
 Schofield" <alison.schofield@intel.com>, Andrew Morton
	<akpm@linux-foundation.org>
CC: <linux-mm@kvack.org>, <nvdimm@lists.linux.dev>,
	<linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Vishal Verma
	<vishal.l.verma@intel.com>
Subject: Re: [PATCH v2 3/4] dax/bus.c: Don't use down_write_killable for
 non-user processes
Message-ID: <6630489ea2b63_14872949@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240416-vv-dax_abi_fixes-v2-0-d5f0c8ec162e@intel.com>
 <20240416-vv-dax_abi_fixes-v2-3-d5f0c8ec162e@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240416-vv-dax_abi_fixes-v2-3-d5f0c8ec162e@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PJksVOuKiKU+f+KVzGPkn5JQigQR/2uEfT+f3tx8D6uRmkMQbZw0BP0fmlrI?=
 =?us-ascii?Q?pEXycMJaKDlvKgBRj9BnDTzl1lUGDNVBEGQZmGhPNQxQcCkHpzDiolyOUBQd?=
 =?us-ascii?Q?fO0Cdyrox2DsKGbm8soQ7RWoqXEG+eq2kORv5hOXZbnx9drEbhqCk9RIin7F?=
 =?us-ascii?Q?B1JNTv9SXOf/TJ8mLAGEoLroj0AR79PXN58WKFo1SVCky4qPmfPdTBi1lYRd?=
 =?us-ascii?Q?RzSqde1+6NEBhcMSld0FQEt91u6Q91A4J/XvQftg5CAliC26wWvcrR3gGvue?=
 =?us-ascii?Q?k2/3a5DBiD2zSgw7FJZOZ/S/d1vFEU0xDqvA3fJT+VMcmMRdiyP8DdpkikbA?=
 =?us-ascii?Q?lYg21Xw1akxZ7v2COZSykIkNXzQE8z4X7IbptbqnZnfAB+mpQnJZg3HeGH+G?=
 =?us-ascii?Q?Av8oASq0Ysl2KmnsFAgi6b6ArXh+AUWMJntZtZCIxbtE1DyLbHOoNi+TcTCs?=
 =?us-ascii?Q?QCjyD97HJ/Rz2/wZ43Kvec3lC2CgIMPKcxccREdK7l9fe0qvnAkFBtG30yTh?=
 =?us-ascii?Q?GR3Oj5gty6MvTKQoHAQTr2hOUT9hNuQh6T1QH8HC85BJstXrrq4uUYugQLiV?=
 =?us-ascii?Q?GMI2/dQ+dPWlUmZbQdN4sAwVDCiALbw03aVlnu2nloELPFomka7512BT5Qh7?=
 =?us-ascii?Q?3Df0PPR+CRS9YwJj5xwDS/NjiWR5MCB1iFd/9l/T8jcc6yFFQ57+qRD7e0lm?=
 =?us-ascii?Q?HF3Bk2Th1yN2uzysMgKHJAkmvGYe/4cQ7BAIBIV2W0t6NGkZ5hLh3jKrtuJ6?=
 =?us-ascii?Q?LNIAgZ3DhRRbBXPF9avZBYobVijOWuN1AxNxrHhL2b+8F5gUCrFQ+ewND2Le?=
 =?us-ascii?Q?bvEZgbs/qdQyzFP67wT0T4R+DumqmjRQMVy2RaH1kSR38tFID0gW2oFqZ9tu?=
 =?us-ascii?Q?EspCadkjWaVhjUxzhaQUz8tN2rVZRHbtKb7Uni2qH8N39R9wB+/5+R86oChj?=
 =?us-ascii?Q?pG67MsdLXorRUKVdW6YDxbA2bWkWWCTQleeefzXTeHDSfHqyn4UkPnpq6WBd?=
 =?us-ascii?Q?yAZ6ogih7fBwDr8dldGwMwqTqTprrYeWTfmBhhJaO8HHbGborFf69nufXr8r?=
 =?us-ascii?Q?f0rmN+Cve988+WXblhQFeOCBqQgjiRmdJlH9ouAdoxHTQtyVlgiK9tUBPJEM?=
 =?us-ascii?Q?HvOH20Vnjo0PtKVJgUKuSMyIy4gbaj81psuEL3SHVM/4scVlylimfurCe8Xn?=
 =?us-ascii?Q?TnCE9T87i6abjWjy2mntvkdgVhSt1zQRUCyLRwLgBzPVhDIGqhn4dnWgCVdp?=
 =?us-ascii?Q?+RIXpyKeZOggFaNbKgsuxNBPYsJkrhjLgUmKRtGBYUxqvUhkKqtS94vPTseh?=
 =?us-ascii?Q?ngJ4TLkXGf1Is42z9c2f32SEtwWK2hDeSBIGo9T7DYVLpwooW9vG3euiSTeV?=
 =?us-ascii?Q?bFnel4BQw2cKJgYb4NOlcdkJo0DI021uLwqxWCidiM7Q2D5IphfKa8yttnda?=
 =?us-ascii?Q?TdjX9k4CVvzh80vR2m116LXPMH0u26zxBf9nriRcsexPKwohyJKtApiJ8Cj/?=
 =?us-ascii?Q?4Na6VSQLkhfLU8ojvk9PNwT8b6IzpA222L6N91kCJPY4TEsFniZG89pqBMBS?=
 =?us-ascii?Q?XBfuRHPHf/2WLojPveXJuG9dyIyLEAA0cL8ZyKx6GrSGPQw0Ioo2JKLubvb+?=
 =?us-ascii?Q?qA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 433418a1-6f51-4b91-76e1-08dc68b47a07
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 01:25:53.1432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2XZ5m+k0JE1Ajtg+dbESnxQYhC3GrpOnkv6mAzRbGl0M/7nnooRH+YjK6lNJDV9WpT7LaAIMTAO/FzhHqNg67ZFLaHd0xAGP4FatQqxaJMA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7351
X-OriginatorOrg: intel.com

Vishal Verma wrote:
> Change an instance of down_write_killable() to a simple down_write() where
> there is no user process that might want to interrupt the operation.
> 
> Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem")
> Reported-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  drivers/dax/bus.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>