Received-SPF: pass (google.com: domain of linux-kernel+bounces-163233-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Peng Fan <peng.fan@nxp.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
CC: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>,
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam
	<festevam@gmail.com>, "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/8] iio: adc: fsl-imx25-gcq: use 'time_left' variable
 with wait_for_completion_interruptible_timeout()
Thread-Topic: [PATCH 3/8] iio: adc: fsl-imx25-gcq: use 'time_left' variable
 with wait_for_completion_interruptible_timeout()
Thread-Index: AQHamiklrLoHwKkt802KEzt7tf8nCrGACTPw
Date: Tue, 30 Apr 2024 01:36:14 +0000
Message-ID:
 <DU0PR04MB9417CE73856B1E1B1CC3D62C881A2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20240429113313.68359-1-wsa+renesas@sang-engineering.com>
 <20240429113313.68359-4-wsa+renesas@sang-engineering.com>
In-Reply-To: <20240429113313.68359-4-wsa+renesas@sang-engineering.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?/T5nGPRMwqBpc6TwtogKEVA3Z4nPwJu34327JD43VQpHjNhQ0gyvfE6Byxtt?=
 =?us-ascii?Q?vj55cKRzLOiUL5w6c+P7KMPJoampOCdEGBx7fL9IJLGl4Zg39gVAbFFmm/9T?=
 =?us-ascii?Q?vx1Rl8spamatxoAcI3mlru1fFD09Pw5XEZ+fxPOhk2SVOe2nZlT/EhvCh+kq?=
 =?us-ascii?Q?KbFTsbyDJ6M/SHhuWRzqYpeYOlywFlnd/rPV00oE2GYew9W5nARxO+6r1kz0?=
 =?us-ascii?Q?POyclJbe6xg6vi6PRHp6mxWdmHM5r52LvBg0x3rB2RmyRBuWCGNe+CZxApKQ?=
 =?us-ascii?Q?i1pxC5HcDjtu3UyfH0ftXVYnLTmXOeaQK7FD/v/vBDUtpPd/sp51BYEEdIzA?=
 =?us-ascii?Q?UoO+m69KwTGt853PVzbMDN+NLK1UfdhY5QDzS2Xdhfgh5/a/HrKBXXVgAaMA?=
 =?us-ascii?Q?90w0JjDiazcoHuBOCkQfSrHnQNntZUlnkP0twt1aiEJ8Ix2gjKXSV+ySRqTq?=
 =?us-ascii?Q?a56gi+ip2QzEx9spkz1B0ABjlcpQJt9zGp9xoeSczRC2VhpaaMW7O7lnr0rq?=
 =?us-ascii?Q?9cTPA2vjgwQHMe4Hqfgx8xwtHTXNqKAFzVSH9K9A1+hdUfOOGSlslOlzMJ7w?=
 =?us-ascii?Q?c5InWaKCplCJ58ZqXA2fvC1FBS/BQBTjbJtTQxdEUFeee2SP6vmR1zGpi0js?=
 =?us-ascii?Q?nVy07SMM+VMQW/zNIqXV9mXokK4BKFADCn2CIZNuuyRpn/pRCa7Mlqmz+ptF?=
 =?us-ascii?Q?fWeKP5KMwpPTGcq7m2xZ9kQRl/jTO7AzR3w3oGPsN9CcyKW+LOjJeLRQt+ba?=
 =?us-ascii?Q?PezyYxt2NuwxlZNYxaPH945pC68BzqQMmtYAb/POT/6S3gmkx9OfbpNPP3W7?=
 =?us-ascii?Q?5m6ZQ1Q//aMoSi1pEpAFRJugirIGDzUNc6vLv2PUWgPHW8A9Xf/Mncr2bdun?=
 =?us-ascii?Q?4ig0f8z8dki62xcazuIOI2yHXsSU7gQq9qmgbDoF+VCv7cgq1y+qqePQrF2T?=
 =?us-ascii?Q?qLmqA2/Ent+o5WsgG/Zh2OnOhXH8lt7F+DCG1OBMk6E6t9sG5Ipmz3VkltPM?=
 =?us-ascii?Q?UfMzdTVwFMIKC/KcYyNwde6vCqsfSajoegRiBzf0WPZZ4Xp+mrwv6sYVQ+ST?=
 =?us-ascii?Q?GJk8nvXJXp+uc95Qqi4VIytanJuDVkMlXc9y7P0BG2mKFkU2mnTDTTJcimRL?=
 =?us-ascii?Q?27GtLAUeGl+kyxgBlBkXaYoFs6BwmX/0dP9rkqfiTCNaJEe4MZ6jfvfzh20o?=
 =?us-ascii?Q?vfqrGj9Cjkx4pHgkP5gZLUd9LBzcgcT7ie1ccP0PpKzCBK0Zhe6Qkxx8fQ0D?=
 =?us-ascii?Q?DZEHUpkoHpuVEYsqhELcoI1q2a5+hA7GxGc42tZjrneLg+VjI+tyvjL6lPm1?=
 =?us-ascii?Q?Br1bF8+cNkeGvh/OQk3XiTXqM4yty/AV7Vz5QevdkNdCeBsjOKtF7m9+qDS6?=
 =?us-ascii?Q?rxC+6Dkm1aRWifhTnBOO22dfQPAiB9oUZp5YS3/X09xyhGP72salKof1P609?=
 =?us-ascii?Q?qFIhYWQBUQfMYmrWXcU5JkMAsBpT93DpmDdnS2J1DWFmcHoWNDMKDau+5pQB?=
 =?us-ascii?Q?+oNQyr6kpnYHWuzJNcuLmqZWPk0ya5fHwnG/Qs8M6wf+TVONypEO/bmCl+Zk?=
 =?us-ascii?Q?dh/tzkc/iWSGom58As4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 367b39d2-2fca-4488-e9c9-08dc68b5ec48
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2024 01:36:14.1808
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0atN7URh+gY0P0KNITzAkv0yOpTVkglvgbndnj20RGB3GIBdGakkjPDInyggwFLAt+VNC8pomknsPtAE0MndPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9233

> Subject: [PATCH 3/8] iio: adc: fsl-imx25-gcq: use 'time_left' variable wi=
th
> wait_for_completion_interruptible_timeout()
>=20
> There is a confusing pattern in the kernel to use a variable named 'timeo=
ut' to
> store the result of wait_for_completion_interruptible_timeout() causing
> patterns like:
>=20
> 	timeout =3D wait_for_completion_interruptible_timeout(...)
> 	if (!timeout) return -ETIMEDOUT;
>=20
> with all kinds of permutations. Use 'time_left' as a variable to make the=
 code
> self explaining.
>=20
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/iio/adc/fsl-imx25-gcq.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-=
gcq.c
> index 68c813de0605..dabc5303d644 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -107,7 +107,7 @@ static int mx25_gcq_get_raw_value(struct device
> *dev,
>  				  struct mx25_gcq_priv *priv,
>  				  int *val)
>  {
> -	long timeout;
> +	long time_left;
>  	u32 data;
>=20
>  	/* Setup the configuration we want to use */ @@ -120,12 +120,12
> @@ static int mx25_gcq_get_raw_value(struct device *dev,
>  	regmap_update_bits(priv->regs, MX25_ADCQ_CR,
> MX25_ADCQ_CR_FQS,
>  			   MX25_ADCQ_CR_FQS);
>=20
> -	timeout =3D wait_for_completion_interruptible_timeout(
> +	time_left =3D wait_for_completion_interruptible_timeout(
>  		&priv->completed, MX25_GCQ_TIMEOUT);
> -	if (timeout < 0) {
> +	if (time_left < 0) {
>  		dev_err(dev, "ADC wait for measurement failed\n");
> -		return timeout;
> -	} else if (timeout =3D=3D 0) {
> +		return time_left;
> +	} else if (time_left =3D=3D 0) {
>  		dev_err(dev, "ADC timed out\n");
>  		return -ETIMEDOUT;
>  	}
> --
> 2.43.0
>=20