Received-SPF: pass (google.com: domain of linux-kernel+bounces-163242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Peng Fan <peng.fan@nxp.com>
To: "S.J. Wang" <shengjiu.wang@nxp.com>, "abelvesa@kernel.org"
	<abelvesa@kernel.org>, "mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@kernel.org" <sboyd@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com"
	<festevam@gmail.com>, "imx@lists.linux.dev" <imx@lists.linux.dev>,
	"shengjiu.wang@gmail.com" <shengjiu.wang@gmail.com>
CC: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] clk: imx: imx8mp: Add delay after power up
Thread-Topic: [PATCH] clk: imx: imx8mp: Add delay after power up
Thread-Index: AQHalvygsYYcYJKLo0CfIP23Iyu2xrGAD7TQ
Date: Tue, 30 Apr 2024 01:39:47 +0000
Message-ID:
 <DU0PR04MB94175AA9D4AC236DF3C35B64881A2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <1714040364-17127-1-git-send-email-shengjiu.wang@nxp.com>
In-Reply-To: <1714040364-17127-1-git-send-email-shengjiu.wang@nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?QTEJoYp30UJxsjwsWAc8RrRyj1nVubRHHSfrx3omUqHEy+iC38z4VsGswAK6?=
 =?us-ascii?Q?BzLR+EDmIto0FJWp2i8+3qjg+r5Y380ThCrWm2A6wJwCJDVSjZGktFUhcYnV?=
 =?us-ascii?Q?jxSPQyagkrihC5Ds3a7SrnTdVb4NF3Hn7vPHgBnjB4q6gi08Ly6t1N6vA6Tl?=
 =?us-ascii?Q?IQGTdQXSslhFqL6s2A+2hRmH4c1Yzvpl6eLja4hYY3de4zl5TmQGCG9DSibi?=
 =?us-ascii?Q?rqu70CW1lN2qkPnow/Dtkf7vqT+BtY5WUgz+mIj8NaNWeynRK0BKMa9PD/RY?=
 =?us-ascii?Q?3UVCrNTG5kj/8vLvbNFvP0u6AdpWlJkJ8u5STl7/o+HNQE4T55w4ysH+xblU?=
 =?us-ascii?Q?ALi8XVY5C9utDCtFCoLm2BgmL8Wi03ZYFf+1GIDpt/bkJskT8relc/I4oe5e?=
 =?us-ascii?Q?ZrLLiZMC/6UuAaNG231qGqIxAkFgm1eLBwenR+v7tds+wLT7DANrWf+Evijy?=
 =?us-ascii?Q?SpizZBb7vASVtS66mwIkkyDChD6OUrP2rBQltYZRVDI1AEZYvJo6vGc4dF8n?=
 =?us-ascii?Q?p4MT/Gnuw5EJVt+uOuZsGzXb5Me/YBVItkaqmiwx0IMEm4LW05yD4GUECZxX?=
 =?us-ascii?Q?tGJDfYl0pFVVZXktUz50sEhHen3Hytvm4uzLLt1vMNC0jCjxZDVviJmT+B7+?=
 =?us-ascii?Q?XHpen4lKrcT+Gub2IPiljVXsx7s1LUbvdJyOVH2yhVTC+BuYTncGmGiJA35x?=
 =?us-ascii?Q?QlNaPA3ANgFXvHDR13ZfZeuh80tV3qPe4tkSvGQ6lIuIlMlUaZwpf6YB1fg+?=
 =?us-ascii?Q?Ggt3Ht0Poj2h/i7GO4oX+Mc/oBKXDjid4ad0WbCrUNkChi8Nulac24kZPuIs?=
 =?us-ascii?Q?Ij3/St2gRqQgcofaebuaqe1gMbjfyajUJjuNrgKuWuK2Lf4aHCClRJ8lm3yU?=
 =?us-ascii?Q?AFJm3E8743AVsJ3zoCI0I8VAVfjolCFGo5KyrUrnAcSuUyTgw/DSykB0mwbf?=
 =?us-ascii?Q?1VbuIc+dVazcIV7MAOHFvJktDbnyq53b9QFvtzS+fn/6fX5i+w6yQa/Jl4Nh?=
 =?us-ascii?Q?gID4vM3OBLqgHzj+j+K7wIqE5sXRU6LAurwNPiM8UIPbKd/qNiCygOjjUiGz?=
 =?us-ascii?Q?iI3rHdFJkVKx0m1xMsLPVt+a+tMQtS6sUszt5kw88j8tlm4wp59KrL4ga5/J?=
 =?us-ascii?Q?lG6nH4YuHpCHyAcqN/BBZs65l4s4DMDT2gpOW5IKfyshPS6B5rQdd9RIE3RJ?=
 =?us-ascii?Q?7bE7HpdIEf3+YYCtkt2A9HqTBfuUMVewyzfyHc+gGRoFUu+PRi+CjmLSIgFT?=
 =?us-ascii?Q?HlTG93JaVv4T5XdLemDc85JOXu6CnWQFPQDx1kVdfAh3HjWQ1uevU8IMPpFQ?=
 =?us-ascii?Q?D1eY2cyoQkALcNmYAgqRY0V3Iz1b+O8uj+pQM7gMCI86x4Jl8t8NjlJCEATN?=
 =?us-ascii?Q?uN/EdsVKFVwZ7sOZkCvq4PKgVGKPHvTGa/lepfEGtPSJ7DumsDoVsG7KhcfC?=
 =?us-ascii?Q?mzVcT6CUqa8XocZcdK2AucZFvJEAaU7Rdi+GSPKx5ZNW++5/ZyZUsqIjELmQ?=
 =?us-ascii?Q?o7J53dsz8bg8SifvorxjzZdqhbg0t1C5+xFnP3u3YNq711KaorQ/Jnp0Y0Ng?=
 =?us-ascii?Q?Gq7utX1YW5Sx8XjoLHI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b24a7f1f-e10b-45d5-55af-08dc68b66b59
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2024 01:39:47.3740
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +Aor0ShVcOvUbhIE8c2bqBlBYNqGh8ZDXHSG5uRfn/rbX8O8oWov11GUVeUOzaK1T8jcJwvXfJ10ysoXPnvsQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10088

> Subject: [PATCH] clk: imx: imx8mp: Add delay after power up
>=20
> According to comments in drivers/pmdomain/imx/gpcv2.c:
>=20
> 	/* request the ADB400 to power up */
> 	if (domain->bits.hskreq) {
> 		regmap_update_bits(domain->regmap, domain->regs->hsk,
> 				   domain->bits.hskreq, domain-
> >bits.hskreq);
>=20
> 		/*
> 		 * ret =3D regmap_read_poll_timeout(domain->regmap,
> domain->regs->hsk, reg_val,
> 		 *				  (reg_val & domain-
> >bits.hskack), 0,
> 		 *				  USEC_PER_MSEC);
> 		 * Technically we need the commented code to wait
> handshake. But that needs
> 		 * the BLK-CTL module BUS clk-en bit being set.
> 		 *
> 		 * There is a separate BLK-CTL module and we will have such
> a driver for it,
> 		 * that driver will set the BUS clk-en bit and handshake will
> be triggered
> 		 * automatically there. Just add a delay and suppose the
> handshake finish
> 		 * after that.
> 		 */
> 	}
>=20
> The BLK-CTL module needs to add delay to wait for a handshake request
> finished before accessing registers, which is just after the enabling of =
power
> domain.
>=20
> Otherwise there is error:

No need paste all the panic log, otherwise the patch LGTM:

Revewied-by: Peng Fan <peng.fan@nxp.com>
>=20
> [    2.180834] SError Interrupt on CPU1, code 0x00000000bf000002 -- SErro=
r
> [    2.180849] CPU: 1 PID: 48 Comm: kworker/u16:2 Not tainted 6.9.0-rc5-
> next-20240424-00003-g21cec88845c6 #171
> [    2.180856] Hardware name: NXP i.MX8MPlus EVK board (DT)
> [    2.180861] Workqueue: events_unbound deferred_probe_work_func
> [    2.180878] pstate: 80000005 (Nzcv daif -PAN -UAO -TCO -DIT -SSBS
> BTYPE=3D--)
> [    2.180885] pc : clk_imx8mp_audiomix_runtime_resume+0x34/0x44
> [    2.180900] lr : pm_generic_runtime_resume+0x2c/0x44
> [    2.180910] sp : ffff800083423a20
> [    2.180913] x29: ffff800083423a20 x28: 0000000000000000 x27:
> 0000000000000000
> [    2.180922] x26: ffff0000c0e4e410 x25: 0000000000000000 x24:
> 0000000000000000
> [    2.180935] x23: 0000000000000000 x22: ffff0000c02afd20 x21:
> 0000000000000000
> [    2.180945] x20: ffff0000c162a000 x19: ffff0000c0e52810 x18: fffffffff=
fffffff
> [    2.180959] x17: 0000000000000000 x16: 0000000000000100 x15:
> ffff8000834239f0
> [    2.180970] x14: ffff0000c03d0a1c x13: ffff0000c0a03440 x12:
> 00000000000003c7
> [    2.180982] x11: 0000000000000000 x10: ffff8000825010ba x9 :
> 0000000000000008
> [    2.180993] x8 : 0000000000000008 x7 : 0000000000000000 x6 :
> 0000000000000000
> [    2.181005] x5 : ffff8000838b0000 x4 : ffff0000c0e66088 x3 :
> ffff8000813852c0
> [    2.181018] x2 : 0000000000000000 x1 : 0000000000000004 x0 :
> ffff8000838b0300
> [    2.181035] Kernel panic - not syncing: Asynchronous SError Interrupt
> [    2.181038] CPU: 1 PID: 48 Comm: kworker/u16:2 Not tainted 6.9.0-rc5-
> next-20240424-00003-g21cec88845c6 #171
> [    2.181047] Hardware name: NXP i.MX8MPlus EVK board (DT)
> [    2.181050] Workqueue: events_unbound deferred_probe_work_func
> [    2.181064] Call trace:
> [    2.181066]  dump_backtrace+0x90/0xe8
> [    2.181080]  show_stack+0x18/0x24
> [    2.181091]  dump_stack_lvl+0x34/0x8c
> [    2.181104]  dump_stack+0x18/0x24
> [    2.181117]  panic+0x39c/0x3d0
> [    2.181129]  nmi_panic+0x48/0x94
> [    2.181142]  arm64_serror_panic+0x6c/0x78
> [    2.181149]  do_serror+0x3c/0x70
> [    2.181157]  el1h_64_error_handler+0x30/0x48
> [    2.181164]  el1h_64_error+0x64/0x68
> [    2.181171]  clk_imx8mp_audiomix_runtime_resume+0x34/0x44
> [    2.181183]  __genpd_runtime_resume+0x30/0x80
> [    2.181195]  genpd_runtime_resume+0x110/0x244
> [    2.181205]  __rpm_callback+0x48/0x1d8
> [    2.181213]  rpm_callback+0x68/0x74
> [    2.181224]  rpm_resume+0x468/0x6c0
> [    2.181234]  __pm_runtime_resume+0x50/0x94
> [    2.181243]  pm_runtime_get_suppliers+0x60/0x8c
> [    2.181258]  __driver_probe_device+0x48/0x12c
> [    2.181268]  driver_probe_device+0xd8/0x15c
> [    2.181278]  __device_attach_driver+0xb8/0x134
> [    2.181290]  bus_for_each_drv+0x84/0xe0
> [    2.181302]  __device_attach+0x9c/0x188
> [    2.181312]  device_initial_probe+0x14/0x20
> [    2.181323]  bus_probe_device+0xac/0xb0
> [    2.181334]  deferred_probe_work_func+0x88/0xc0
> [    2.181344]  process_one_work+0x150/0x290
> [    2.181357]  worker_thread+0x2f8/0x408
> [    2.181370]  kthread+0x110/0x114
> [    2.181381]  ret_from_fork+0x10/0x20
> [    2.181391] SMP: stopping secondary CPUs
> [    2.181400] Kernel Offset: disabled
> [    2.181403] CPU features: 0x0,00000040,00100000,4200421b
> [    2.181407] Memory Limit: none
> [    2.463040] ---[ end Kernel panic - not syncing: Asynchronous SError
> Interrupt ]---
>=20
> Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for
> power saving")
> Reported-by: Francesco Dolcini <francesco@dolcini.it>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> ---
>  drivers/clk/imx/clk-imx8mp-audiomix.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-
> imx8mp-audiomix.c
> index e4231e9c8f05..cb44c460548e 100644
> --- a/drivers/clk/imx/clk-imx8mp-audiomix.c
> +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c
> @@ -6,6 +6,7 @@
>   */
>=20
>  #include <linux/clk-provider.h>
> +#include <linux/delay.h>
>  #include <linux/device.h>
>  #include <linux/io.h>
>  #include <linux/mod_devicetable.h>
> @@ -362,6 +363,12 @@ static int
> clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
>=20
>  static int clk_imx8mp_audiomix_runtime_resume(struct device *dev)  {
> +	/*
> +	 * According to the drivers/pmdomain/imx/gpcv2.c
> +	 * need to wait for handshake request to propagate
> +	 */
> +	udelay(5);
> +
>  	clk_imx8mp_audiomix_save_restore(dev, false);
>=20
>  	return 0;
> --
> 2.34.1