Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1767568lqa; Mon, 29 Apr 2024 20:33:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWlLSCjH13qLwurnMVWtgXsI3FHbXfsxqmYk+Z8JI58dTht1lL814NjSLjq2ZUSze2eFSIDHvFmKBXEXcG2tHed3SfodldCLn4/dRk3Sg== X-Google-Smtp-Source: AGHT+IE9KUyEjPWaI3rJIoE46lJBz7VErdoIWPqVTntaSJwHR5Fm6p5WPCoeoiyf/0028oZEe80K X-Received: by 2002:a05:6808:28b:b0:3c5:f728:3934 with SMTP id z11-20020a056808028b00b003c5f7283934mr12773503oic.26.1714447997863; Mon, 29 Apr 2024 20:33:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714447997; cv=pass; d=google.com; s=arc-20160816; b=j53kVw+U1xG8UvmjJk4h/hBN7emh49kHsqK+JQagYHOT46rIw+p7L22bOg9t3cA2EW ahvtlsN+ESecB8C4pml62+oV71r1jkXw/wiL2Vut4H5xRLWAUza5miRTVn06rxDbl+vq mBj1hIgvjaPWy1jgpfARtzWaqHb3Km4vnUt6ZlEgFWb/677UHf1k7qDpQsRgal+oAkMS 713Wlupp6CdneAWX+nPyu/z2wix4EXmMJ3asvmN7rAn/8cg+tytMWAGyIkMIV4sJGHtJ j38Dd1o8PWo5eXU3x2b8PonV5hFpwJlH+NMgLD8xaHsgiSql4EWrB+CXLso4avyPwwZF T8sw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=JPt6seOrS0c8rALNbioTUw/W9/y7z5rWWccXhHGuw8I=; fh=MUR88bFMIx3vFKp/j9Y9fWtpE04vvnu3U9YY6g14FHI=; b=UMTWIC6gzJUP0dPKeUBVz0iB0jADxHhBo2tElKKsHgYOefz6yKX6YbdHQP+xrF2KHK dJTviKZnloOiGRcYIfnMNOcdu6YhXGxg0FtR6B3rhSSe7ZBd7vy9wPWNA87lqZEEVYog nlCbSGx1i89R3R7kQCj393+l2xEU1m6jJzW29DZ833BuuRjx/G2wY25z3oOcYJAd0bLQ mHQBIJlShNfBbLZAYeB4md92lI6XQLTBQRcKzyzCr4IpyR+ksEh29wyA/zp61rV/KpK5 1FKRuQYpwdszIDUMaezNoQr6+2255f+zVRi+NMvTBLUCK2jqlmLep+PvJ2DcweoyCb9q xdVQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=myAu4gBs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-163288-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163288-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h8-20020a056a00170800b006f3fe245cffsi3602131pfc.107.2024.04.29.20.33.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 20:33:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-163288-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=myAu4gBs; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-163288-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163288-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id DDE0C2841D3 for ; Tue, 30 Apr 2024 03:23:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AC75010A1E; Tue, 30 Apr 2024 03:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="myAu4gBs" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D278214012; Tue, 30 Apr 2024 03:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714447413; cv=none; b=lxBpCSnoYo8v7RC96ym13LO7NN/0l4VqkeV9a73EY1epucARsrC8opCxSQQVAVsIcRe37nv83PPzgILQCyRr2UK/sXR8XMmIPFEmq07ne0owRmW0cnpkH2NCuNvDGN90Ksr9F2UsIGCIYljakRweVvBYjPWaQNOwG+kT+/7XQKE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714447413; c=relaxed/simple; bh=+ziwUOuJ/5z2kID1ktuoOnRRYM512wFNMBw8R4f1CH4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UZqbAIPPZShs/18uXs+p47unwZUNf4ENnqdBZIGX1gqPeUPhwGAlrEpc7WzxmViTmp8oeonitNZ7wi70jmR6u3Nrp+IfWatdcbbVlkSoyjLce+MGb9hC42sA0ubFG2HeIP57kspvHTycCW39g/zhFMpee2CyjRjxLGLdXuPAJTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=myAu4gBs; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6375C116B1; Tue, 30 Apr 2024 03:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714447413; bh=+ziwUOuJ/5z2kID1ktuoOnRRYM512wFNMBw8R4f1CH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=myAu4gBsisirnn2O0lJ4Ig1Cm0FyC7rYAJzytGiDK4azOQ1ii9xHas1MwjaxUZLAQ Tgx19e1KESqZVBq5dhBBIiGIOCEBwVF+yDz+ZzUMdiVaEqL2bbx5zrvHElcVL864JW IU8x0ueDVSm2uE9wN447iR53NyOkkGnHKmBvxuEG/TwZ/IKkBuEE6bIZlOzJvCsVrh XCCw5fTkPrvQCsMOP0Rq5Fql8TUHSnRlzDipFPFHNBFehYq/+dhO2jChsq0YCuz6Y8 0fQPGLST31rlspF0L5lH/5+WzoGh+++Z0Pv3cojd3ivdYyNCaYM0JgU7UZefZVWmJ0 w3asVzGGnlBYw== Date: Mon, 29 Apr 2024 20:23:31 -0700 From: Jakub Kicinski To: Danielle Ratson Cc: , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH net-next v5 10/10] ethtool: Veto some operations during firmware flashing process Message-ID: <20240429202331.29f3dafa@kernel.org> In-Reply-To: <20240424133023.4150624-11-danieller@nvidia.com> References: <20240424133023.4150624-1-danieller@nvidia.com> <20240424133023.4150624-11-danieller@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 24 Apr 2024 16:30:23 +0300 Danielle Ratson wrote: > Some operations cannot be performed during the firmware flashing process. > > For example: > > - Port must be down during the whole flashing process to avoid packet loss > while committing reset for example. > > - Writing to EEPROM interrupts the flashing process, so operations like > ethtool dump, module reset, get and set power mode should be vetoed. > > - Split port firmware flashing should be vetoed. > > - Flashing firmware on a device which is already in a flashing process > should be forbidden. > > Use the 'module_fw_flashing_in_progress' flag introduced in a previous > patch to veto those operations and prevent interruptions while preforming > module firmware flash. Feels a little out of order to add this check after the functionality. I'd merge this with patch 5.