Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1777061lqa; Mon, 29 Apr 2024 21:04:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXkWiG6v0D9shZPsigYCiAvNzGPbU3igqydg0DAeOrRPlrVroH/E/700uFFrfC/RPXZdCTT87JP424nR/VVmt5cVn44zBQOGHulMfz32Q== X-Google-Smtp-Source: AGHT+IHK0uOScLQGqAj2BaMtKXf2AwMhKaFYdSNNbUO6V4+pK85P1vEIy1Xlgp55+kvFcfK26+Oa X-Received: by 2002:a25:d845:0:b0:de5:a15a:7118 with SMTP id p66-20020a25d845000000b00de5a15a7118mr12042897ybg.42.1714449862145; Mon, 29 Apr 2024 21:04:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714449862; cv=pass; d=google.com; s=arc-20160816; b=xoWcBw39B1SSLKxjuw5Q9+WuB6r6kyI9Ka7I0YsvbfXxiMSOrsiKZE2FjuxXG0hxfZ tCvbEdnKj5R7duKZdYOjZEXcMYmmDJvqeV6foqVOTUn8p43CAMcMt9hM9rTo3/hOE5lm NUqaB2x5h+37sT4QRwxh2/7UqrvueMlGq4VlrbjCQaC0Fg2sL9TGlIaqsusFK8AooILj lAO10KlvYi2Loh0nuzTkM12ArTuozcETUxHHVs02z5gmj+Y+YHTUS4xndVRS6PmD4JQy x+JPChJnt6si/3gqIYtNAOU+h6odhsfIoBzUZeUyFcAdRO7CFxXopqvaZBtncax02LUN Tq1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Cc+/1xCquATq7FO6eqR8t3cu5To1zwP4PfeaYzwibME=; fh=aB4DiVZZMDyOzVeIMyxFu3UcvfDiUvQzZ7U82fluu4o=; b=KCDbaTVnn25kOYXhVJDxL+8CKs9sLkD7RSKKolCuofPeri1N8Bs838lQrkYljCuz/C t7dOnCfBhI2XY5qyof5KVs1Qy2zkUqvsqr5btOwIhMFN571LJAwUyfxWS0dOfmmGpqxH 6uwqa/ql31SBFUWId4ne8+Y9Lt4UF2t5xpW3euyBDXo6Ql+3KjT1Ml5tiIadrHMp5xV7 Vih5jSgx8k6SsJ2QBqaa5swW7cEmpiJCagCBnKoqHZX2vXgPChkQUWw+6EqxfGLY0VQ+ oOuh6NbTJowE0AxeqGxU6kRg9k989npCp6Fb9NJBXmjK6Yizx7Tm9WCy8N4LqKugNhtH K4ew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ygYcon6u; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-163313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163313-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w4-20020ac87e84000000b0043adbfb4be2si4584014qtj.605.2024.04.29.21.04.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 21:04:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-163313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=ygYcon6u; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-163313-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163313-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D84D91C21B20 for ; Tue, 30 Apr 2024 04:04:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3277D125CC; Tue, 30 Apr 2024 04:04:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ygYcon6u" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B84D2101C5; Tue, 30 Apr 2024 04:04:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714449854; cv=none; b=S1or4uFZt6B6Nb6txl3Z2mmyPHqdYYJK5FdDDFvQ+iKmC0ggyBVNwOP/pcd0htqCce/BnsRHWjLWfJQBuW3hEo65QDFapjwLYtBZlYVXat7Y/u1+MK6MWSctQV+6o1g760E/J58gviRieni2oY/aXlAeAQt7Nk77UwhCybJBzdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714449854; c=relaxed/simple; bh=xquYkdl9fpC+Wtb+uNSGETdm8v6yEqPydZ0+Pzg3qgo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Tq1VohRHK0EFAEEzJkt8rddurMzzSZ6zYd9rTUEKJ0iouCCkaUEF73I9Uc5PPkfbmjsf5RCpwW2Nbt68CWl/9t1/WZQeSuANwEauV4pCfM/BDpFGkTQ6VJIJDGTAlzGL6tVEivwqeRNjlpVoFlKc7apx41dgui3gA/1JGmqq5Pk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=ygYcon6u; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Cc+/1xCquATq7FO6eqR8t3cu5To1zwP4PfeaYzwibME=; b=ygYcon6u+jC+Jl55WVeEYJm703 J1rriCyFT2G+/Pn2LZnU9UoMC8vwxFmABUJz74+YLijBxCsgIdBi8j+gAq867BDTjKUsIIuJU8245 TaDr1fqX9HlBLkUt91nrh73ciReXhJ1AnCQJNPlPOqTWfF4D6+rhceGAheF0JIaqhzwiBAXo6wtRK 2WB+fea1l1SgR4qQDrQUpJo5kcNmAiTlmapV+gNuSWn+HCW0RUp6juUrWOnTntDm22Au2KNHCJfi5 4QBULQfXtIeXXe8BkRWjKXdJWCDh87FBDqgQVmIdQRUMNCjNw/3aSFyGnvfJ/cJAMe1QPP9ISQK18 jOWXwLWg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1eiw-00000004zYR-48Wf; Tue, 30 Apr 2024 04:04:10 +0000 Date: Mon, 29 Apr 2024 21:04:10 -0700 From: Christoph Hellwig To: Jiapeng Chong Cc: chandan.babu@oracle.com, djwong@kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH 1/2] xfs: Remove duplicate xfs_da_format.h header Message-ID: References: <20240430034728.86811-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430034728.86811-1-jiapeng.chong@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Apr 30, 2024 at 11:47:27AM +0800, Jiapeng Chong wrote: > ./fs/xfs/libxfs/xfs_trans_resv.c: xfs_da_format.h is included more than once. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8931 I don't think we do Closes for random bugzilla, never mind for trivial cleanups. The changes itself looks fine, though: Reviewed-by: Christoph Hellwig