Received-SPF: pass (google.com: domain of linux-kernel+bounces-163318-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2a595561-0a11-4d5e-ac72-a7c3aab9c8f7@linux.dev>
Date: Tue, 30 Apr 2024 12:13:31 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] bcachefs: Correct the FS_IOC_GETFLAGS to
 FS_IOC32_GETFLAGS in bch2_compat_fs_ioctl()
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org,
 Youling Tang <tangyouling@kylinos.cn>
References: <20240430032744.943468-1-youling.tang@linux.dev>
 <penqmxyjpw5jukmqbmsrjbvqxhugrhbk6gruie4pjdoacah5zr@atcvnu6ogksv>
Content-Language: en-US, en-AU
From: Youling Tang <youling.tang@linux.dev>
In-Reply-To: <penqmxyjpw5jukmqbmsrjbvqxhugrhbk6gruie4pjdoacah5zr@atcvnu6ogksv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 30/04/2024 11:29, Kent Overstreet wrote:
> On Tue, Apr 30, 2024 at 11:27:44AM +0800, Youling Tang wrote:
>> From: Youling Tang <tangyouling@kylinos.cn>
>>
>> It should be FS_IOC32_GETFLAGS instead of FS_IOC_GETFLAGS in
>> compat ioctl.
> Do we by chance have a test for this?

Just reading the code found this out.


>
>> Signed-off-by: Youling Tang <tangyouling@kylinos.cn>
>> ---
>>   fs/bcachefs/fs-ioctl.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
>> index 3dc8630ff9fe..205a323ffc6d 100644
>> --- a/fs/bcachefs/fs-ioctl.c
>> +++ b/fs/bcachefs/fs-ioctl.c
>> @@ -548,7 +548,7 @@ long bch2_compat_fs_ioctl(struct file *file, unsigned cmd, unsigned long arg)
>>   {
>>   	/* These are just misnamed, they actually get/put from/to user an int */
>>   	switch (cmd) {
>> -	case FS_IOC_GETFLAGS:
>> +	case FS_IOC32_GETFLAGS:
>>   		cmd = FS_IOC_GETFLAGS;
>>   		break;
>>   	case FS_IOC32_SETFLAGS:
>> -- 
>> 2.34.1
>>