Received-SPF: pass (google.com: domain of linux-kernel+bounces-163483-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Apr 2024 09:34:42 +0200
Message-ID: <87cyq7nw19.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Manuel Barrio Linares <mbarriolinares@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Geraldo Nascimento <geraldogabriel@gmail.com>,
	dengxiang <dengxiang@nfschina.com>,
	Jussi Laako <jussi@sonarnerd.net>,
	Christos Skevis <xristos.thes@gmail.com>,
	Alexander Tsoy <alexander@tsoy.me>,
	Jeremie Knuesel <knuesel@gmail.com>,
	WhaleChang <whalechang@google.com>,
	Sean Young <sean@mess.org>,
	linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: usb-audio: Add sampling rates support for Mbox3
In-Reply-To: <20240429193522.10380-1-mbarriolinares@gmail.com>
References: <87il00pdsz.wl-tiwai@suse.de>
	<20240429193522.10380-1-mbarriolinares@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Mon, 29 Apr 2024 21:35:00 +0200,
Manuel Barrio Linares wrote:
> 
> +	set_rate = le32_to_cpu(buff4);
> +	if (new_rate != set_rate)

Those two lines cause sparse warnings, unfortunately.
You can't assign int to __le32 type directly, and you can't compare
between those types directly, either.

That said, it should be rather like

	if (new_rate != le32_to_cpu(buff4))
		dev_warn(...);


You can check the sparse warning by yourself by passing C=1 argument
to make, too.


thanks,

Takashi