Received-SPF: pass (google.com: domain of linux-kernel+bounces-163538-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Apr 2024 16:27:48 +0800
From: Inochi Amaoto <inochiama@outlook.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, 
	Inochi Amaoto <inochiama@outlook.com>, Jean Delvare <jdelvare@suse.com>, 
	Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, 
	Chen Wang <unicorn_wang@outlook.com>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/2] dt-bindings: hwmon: Add Sophgo SG2042 external
 hardware monitor support
Message-ID:
 <IA1PR20MB4953F13D16B99FC04EB2AD30BB1A2@IA1PR20MB4953.namprd20.prod.outlook.com>
References: <IA1PR20MB4953D1C509CC7F23620CCA01BB1B2@IA1PR20MB4953.namprd20.prod.outlook.com>
 <IA1PR20MB4953EF54DBF6D5681C27014BBB1B2@IA1PR20MB4953.namprd20.prod.outlook.com>
 <97886e14-f07f-4175-8e8d-2d70c2daa907@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <97886e14-f07f-4175-8e8d-2d70c2daa907@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: IA1PR20MB4953:EE_|MN0PR20MB7367:EE_
X-MS-Office365-Filtering-Correlation-Id: 16434118-d337-42dd-e508-08dc68ef5ac8
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|461199019|1602099003|3412199016|440099019|1710799017;
X-Microsoft-Antispam-Message-Info:
	fjC0taqLhqttUkXaQZnfBhv0QMVPN8k/VKFYc646TXBqIEyBSUcjAllqUyfTbqzGwNLMWy6SdszgVGnuyEsw4g5V5JtXhWlAC5emk7P/oWDnWL6IsHm2vTuSxXvUmn68RS5WZRW+NulFE4zkxLx8J2YgQPWTQZZRVuo9U8CNCNmRjdWyBNDWl02OR5IS/E2v973hVUgFd4X+cChlSLBA6Gc1l0Ageq0uU5faNE3BW+Ou9CFeGWZ+LuDqxhyntinL5EiDbtf4k9UG9j8uYkGWcRKhNCDidRnapyi2+9TyTsu4y7sIGxfs0l46W39SsRN4fDC8mF9W+50gW3EBFxNsuTWdtENYK+Fcxpj97Y+thhaaB3fWq0eX+CYJsTwsVuHjmNKCpYERYxCr9Udl7fDO9dXzZeYVycaKKmPBUMIsFFhkrnsn2Xv7xR23l+HUkFcLMMgC2oi1hJ3iEDwTHBPZWE/FBaxvZUhzuY1qpwpXu/GEyB4i8t7MlGY5Sei3AlZO5ObmXgj/XhPUgip6DwlT1opz/CsboypSFvO+59VxSakrW5Vg9cA8b3IyJe+N0zQf8RhC86zNpkqrHDsg4qWYm/1+XvNrK9cE3PvqalMIZuY1uXi3t8lUsDnEAtUedNGESDrO8GbvOqbDEw3nDWoMsL1cxOh8rBzPxz/4VW8zAxA608q/r/fKTJeh00mTOrMQ
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?UNZ2Xai7HSDd9sbuhw5i8u6e3knNneBuyywP3jDCVNFrj2sqh4EwT8EXJNGa?=
 =?us-ascii?Q?89jSW/gRwu+B7eOS/q2wEXIpeyytGYL/sOmrHR9vJMku9O4x5KIaz8uvbSQ1?=
 =?us-ascii?Q?ATvitCNQgLLeXzWD6PSuGrd1bj89k6coF5YKVwXVWPrKT8BcmYEd54cavwyJ?=
 =?us-ascii?Q?ufgAwRThZHP4oKIUczIwACH0ScWnr34QeBxHbjI2Su8c/1nQ0FbCiMuZBKKo?=
 =?us-ascii?Q?Jnb54pc6XQ00yHQSvbYTcTWWaFKSENGYXexw3BP3Vv0git6gfmU4xQtpXG0t?=
 =?us-ascii?Q?Z4Ekf1b+fZiJ4jffovDUITYwbXogOtiL7jjowN6ka0D8Z8OEKVQ+Xw9twGUQ?=
 =?us-ascii?Q?BcUmoe/oxwb7bHgvp2uTqHGcjBQvPkCIc7Hwq+7/os9H2LVRHub2LUKsy4sB?=
 =?us-ascii?Q?WyDqVqdVCwKg3rFJCqIFZQ7OWCSWvB/KpdFND/eYhsK0pqA0lRPOSIPnwOnt?=
 =?us-ascii?Q?m8qtdYbShxQMSATAUT+qbVfHboOpMTav5E1Svy6f+kApgF/WKl6yuqh7E9Ou?=
 =?us-ascii?Q?iVDeZdtUhjCOX0ZfhTFbvnkjDEQ1nxV+OsElDV4XXSVxqf9Q75+brdyzUx+Z?=
 =?us-ascii?Q?cM0s0PLOz5izNOxnXFmx7fC68uc16hi8kCb/eKzieKHcKRtOZPGflbyNNCIU?=
 =?us-ascii?Q?iRC5snVlDz5x9YCZ0KahRK/FnxRCtGAx9DW+iAtXa1E6cIuUpT1R7U0xw8/I?=
 =?us-ascii?Q?IaDKMOuY0E9jgeVqmACKT7J+7/cWD/Cf77/SYLmWxELh4wbWrqYM410C1D4O?=
 =?us-ascii?Q?GW0BzmLX4ndzm1xakzYFpDbBHUGbIpmCyrRrMQ6nw7bO9vytL8j9gRRBe6hT?=
 =?us-ascii?Q?tRP2sCx51yq6pbmAtSa8RAl15+/5+7AihdONIKsionRRB7v4DRF9yt1xyKaK?=
 =?us-ascii?Q?eutgB7ffjU/rM5QbX9UvdUiK22K3XUB1iwpd2Pj//1jF1TK5KtwW7MNBaWvy?=
 =?us-ascii?Q?gizJ8wHQK5ls8OwL5PIUQ+qZolAaTtEF28ikZhdm0SOCsrvyk3lAvWNIROdR?=
 =?us-ascii?Q?hXHXS//2Y6KSHONFfv1clw8nNXzqNz0InHZcoyHX1Bijbs/W7KG+bWhQCISv?=
 =?us-ascii?Q?Rx1h/uOrKIY74Xidohv3zp/DS9KEz7sIlKLUlrE+HFwxrTJOImEc31MrgN9r?=
 =?us-ascii?Q?kB+yXCzmYH3Ja69KwOux9nHwjIUCkUnpmnp241BgyYk0numM1lgSFQAJ/2so?=
 =?us-ascii?Q?oKc+qgwP5m+GHXOGqi7K80Wk/eRGvr62eoPsl9VxDd+SCYF+465+pjcWtw0J?=
 =?us-ascii?Q?+V4KxvXdL9NTLFNlXeTJ?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16434118-d337-42dd-e508-08dc68ef5ac8
X-MS-Exchange-CrossTenant-AuthSource: IA1PR20MB4953.namprd20.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 08:27:21.1275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR20MB7367

On Tue, Apr 30, 2024 at 09:47:16AM GMT, Krzysztof Kozlowski wrote:
> On 29/04/2024 14:03, Inochi Amaoto wrote:
> > Due to the design, Sophgo SG2042 use an external MCU to provide
> > hardware information, thermal information and reset control.
> > 
> > Add bindings for this monitor device.
> > 
> > Signed-off-by: Inochi Amaoto <inochiama@outlook.com>
> > ---
> >  .../hwmon/sophgo,sg2042-hwmon-mcu.yaml        | 40 +++++++++++++++++++
> >  1 file changed, 40 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml b/Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml
> > new file mode 100644
> > index 000000000000..64a8403aaab8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/sophgo,sg2042-hwmon-mcu.yaml
> > @@ -0,0 +1,40 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/sophgo,sg2042-hwmon-mcu.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sophgo SG2042 onboard MCU support
> > +
> > +maintainers:
> > +  - Inochi Amaoto <inochiama@outlook.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: sophgo,sg2042-hwmon-mcu
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  "#thermal-sensor-cells":
> > +    const: 1
> 
> This looks like thermal sensor, so you miss ref to thermal-sensor.yaml
> in top-level. Just like other sensors.
> 

Thanks.

> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - "#thermal-sensor-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        syscon@17 {
> 
> Are you sure this is syscon? 

My fault, I forgot to change the node type after moving.
I will replace this type with suitable one.

> Title says mcu, compatible says hwmon...

SG2042 use an external MCU to provide hwmon info (on the
motherboard, not in the SoC).
This is why I say this is MCU, and compatible says hwmon.

> 
> 
> Best regards,
> Krzysztof
>