Received-SPF: pass (google.com: domain of linux-kernel+bounces-163543-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-4-shakeel.butt@linux.dev>
In-Reply-To: <20240430060612.2171650-4-shakeel.butt@linux.dev>
From: Yosry Ahmed <yosryahmed@google.com>
Date: Tue, 30 Apr 2024 01:34:10 -0700
Message-ID: <CAJD7tkb0cOwgvet4MV8pAzP+R4ptHoWgFoMsdoYw_0qrcWv1=Q@mail.gmail.com>
Subject: Re: [PATCH v3 3/8] mm: memcg: account memory used for memcg vmstats
 and lruvec stats
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, Johannes Weiner <hannes@cmpxchg.org>, 
	Michal Hocko <mhocko@kernel.org>, Roman Gushchin <roman.gushchin@linux.dev>, 
	Muchun Song <muchun.song@linux.dev>, "T . J . Mercier" <tjmercier@google.com>, kernel-team@meta.com, 
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt <shakeel.butt@linux.d=
ev> wrote:
>
> From: Roman Gushchin <roman.gushchin@linux.dev>
>
> The percpu memory used by memcg's memory statistics is already accounted.
> For consistency, let's enable accounting for vmstats and lruvec stats
> as well.
>
> Signed-off-by: Roman Gushchin <roman.gushchin@linux.dev>
> Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>

Reviewed-by: Yosry Ahmed <yosryahmed@google.com>

> ---
>  mm/memcontrol.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 7126459ec56a..434cff91b65e 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5545,8 +5545,8 @@ static int alloc_mem_cgroup_per_node_info(struct me=
m_cgroup *memcg, int node)
>         if (!pn)
>                 return 1;
>
> -       pn->lruvec_stats =3D kzalloc_node(sizeof(struct lruvec_stats), GF=
P_KERNEL,
> -                                       node);
> +       pn->lruvec_stats =3D kzalloc_node(sizeof(struct lruvec_stats),
> +                                       GFP_KERNEL_ACCOUNT, node);
>         if (!pn->lruvec_stats)
>                 goto fail;
>
> @@ -5617,7 +5617,8 @@ static struct mem_cgroup *mem_cgroup_alloc(struct m=
em_cgroup *parent)
>                 goto fail;
>         }
>
> -       memcg->vmstats =3D kzalloc(sizeof(struct memcg_vmstats), GFP_KERN=
EL);
> +       memcg->vmstats =3D kzalloc(sizeof(struct memcg_vmstats),
> +                                GFP_KERNEL_ACCOUNT);
>         if (!memcg->vmstats)
>                 goto fail;
>
> --
> 2.43.0
>