Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761423AbYA1TWl (ORCPT ); Mon, 28 Jan 2008 14:22:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752710AbYA1TWc (ORCPT ); Mon, 28 Jan 2008 14:22:32 -0500 Received: from a-sasl-quonix.sasl.smtp.pobox.com ([208.72.237.25]:48279 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbYA1TWb (ORCPT ); Mon, 28 Jan 2008 14:22:31 -0500 Date: Mon, 28 Jan 2008 13:22:04 -0600 From: Nathan Lynch To: Greg KH Cc: Jan-Bernd Themann , Sudhir Kumar , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, sam@ravnborg.org, Christoph Raisch Subject: Re: [2.6.24-rc6-mm1]Build failure in drivers/net/ehea/ehea_main.c Message-ID: <20080128192204.GO14201@localdomain> References: <20080108163305.GB10026@in.ibm.com> <20080110173418.GA14728@kroah.com> <200801181016.49128.ossthema@de.ibm.com> <20080125191047.GM14201@localdomain> <20080128182423.GC28861@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080128182423.GC28861@kroah.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2764 Lines: 55 Greg KH wrote: > On Fri, Jan 25, 2008 at 01:10:48PM -0600, Nathan Lynch wrote: > > Jan-Bernd Themann wrote: > > > > > > On Thursday 10 January 2008 18:34, Greg KH wrote: > > > > > The structure device_driver(in device.h) has a member struct driver_private which > > > > > contains the member kobj (according to drivers/base/base.h). > > > > > But in device.h struct driver_private has been declared localy and > > > > > neither defined nor included from base.h. > > > > > So my effort to use driver->driver_private->obj also does not work. > > > > > (I am surprised from where do you access the struct device_driver) > > > > > > > > That is because a driver should not be accessing such a field. > > > > > > > > And especially not in this manner, why would this driver be creating a > > > > symlink that has already been created by the driver core? This whole > > > > thing can just be removed with no problems. Can you try just removing > > > > the ehea_driver_sysfs_add and ehea_driver_sysfs_remove functions to > > > > verify this as I don't have the hardware present to test it out. > > > > > > The eHEA driver tries to orginize its sys-entries as close as possible to > > > other ethernet drivers. Each eHEA NIC has multiple ports which is not that > > > common in PCI. This means that each port is represented by a subdirectory > > > which has not the "driver" sys-link, only the root directory has. > > > Some tools expect to have this driver link in each port directory. > > > That is the reason why this link is created manually. > > > > > > Are there any other ways to create this link? > > > > > > This is now broken in mainline... > > > > drivers/net/ehea/ehea_main.c: In function 'ehea_driver_sysfs_add': > > drivers/net/ehea/ehea_main.c:2812: error: 'struct device_driver' has > > no member named 'kobj' > > drivers/net/ehea/ehea_main.c:2815: error: 'struct device_driver' has > > no member named 'kobj' > > drivers/net/ehea/ehea_main.c:2818: error: 'struct device_driver' has > > no member named 'kobj' > > drivers/net/ehea/ehea_main.c: In function 'ehea_driver_sysfs_remove': > > drivers/net/ehea/ehea_main.c:2830: error: 'struct device_driver' has > > no member named 'kobj' > > Does the patch below fix this? That driver should not have been trying > to create symlinks that the driver core has already created for it. Yes, it fixes the build error, by just removing the code that got broken. Jan-Bernd gave a rationale for creating the symlink that didn't really seem to be answered. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/