Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1896800lqa; Tue, 30 Apr 2024 02:29:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUf4LB5/XqyHmz5HNQUuRyGYANyMvlgSol5RwOfZklRFr1JTNVldPCUeNVCsSfCpayjbSjUoampMUeMb1nOtMF3+HA/7gBJ9xyMROPW8g== X-Google-Smtp-Source: AGHT+IENJU+xlPS3iW97guDaBbCAee05p01fjOK8gYMoqrHH6csujjQ3GohbjJd8WtlzdMGBadmr X-Received: by 2002:a17:902:988a:b0:1ea:2753:2b9f with SMTP id s10-20020a170902988a00b001ea27532b9fmr11290203plp.20.1714469343229; Tue, 30 Apr 2024 02:29:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714469343; cv=pass; d=google.com; s=arc-20160816; b=Rt6ym882CBFWf80NMQeFU3RsZkaPomElGFBiL9px2J6WZ8VH/rK0Rupbgc2+zTx6sN WNPgZbYzmLrwemdcC3Udu4qmlx4nYRQgJN8ePoCFGRjr/j9c+4ajsPpSFvoUcqyBHdbZ fNw/0GejGWOIxr4m0cfhGvuuYTVIlMdFcVSCs3hJbDC5KfSPB+N2PTK5jECfOGOkByOj wkeZynDUF4Qnqx1rG1nzD5A1Ji3ao7VUj52ZTxdyUSCT/Kr+yGNHBbrFyNUmX10yvd1l zR/KAltMnEZ/vE5fsl35mwNK2LZ/tWCbjPAQHoPHvDCEUPc94IHR4dcys2hgzATgrC14 onig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:in-reply-to:from :content-language:subject:references:cc:to:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=nJLw8ZzNkHNxUi0RWmfswS2AiqmNNWu4fMk4lAvCziY=; fh=xXsXYmHMYzEggc0jWBAsi3r900EvZJVD9YqBsmUx85Q=; b=r07mGEKCcvzuBlo4xq8C3Ffu/yUG8YQsNE8eOTcaalFCfDNHt4b2TtW9d9gLyqQnIj D5DSoFlziuYwuaYY+PYttUQAYsC11Ck+rHolD+u0JZYA9Fcw0WmoXp7QWLv3LrQHL54b 86SmiwUAsGMzqUhyHNCoQS9fAzv/hZWvQX0ynbkm9wPT4Wg59w3l8vKU7if3Ztgzq/oL TfUvn6JUTrrGIcqhyxC5b7yl4sYvuXk0Z21HLIEyGMlTnOIS06A5tdcXJwCn/KkCjxR3 zmwAvM/6bvOC0pg9mZGFJcN1zh9A6QYQrbC3+yaNiV1AnsKmgpvJ3QFVW4Md9P0v3PD8 C5AQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="YA/7nQ35"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-163664-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163664-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id ma11-20020a170903094b00b001ea023361adsi14254195plb.33.2024.04.30.02.29.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 02:29:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-163664-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=s29768273 header.b="YA/7nQ35"; arc=pass (i=1 spf=pass spfdomain=web.de dkim=pass dkdomain=web.de dmarc=pass fromdomain=web.de); spf=pass (google.com: domain of linux-kernel+bounces-163664-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163664-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=web.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id CAD68B23F16 for ; Tue, 30 Apr 2024 09:24:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DC871C660A; Tue, 30 Apr 2024 09:19:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="YA/7nQ35" Received: from mout.web.de (mout.web.de [212.227.15.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C561A129E6E; Tue, 30 Apr 2024 09:19:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468751; cv=none; b=Yl2JZSaAIHK0f6Rt+1hc9sjeBHpA4cXDaEWoHK9ED+iUmDt7LB9oqlf4BgyjGnEAris//qEwfJxjoWt7gETtL1uteZpxB4FDy1wd3dMGkTcX6bF0oibDTlYK0ptG9U3XVUvq5ANdBB3kmb63hXtsgpbYCeKfwlfnkIrNFdFwqIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714468751; c=relaxed/simple; bh=nJLw8ZzNkHNxUi0RWmfswS2AiqmNNWu4fMk4lAvCziY=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=sbRPBteVbfUpCI2fXJ7LMcLsOgsdkm70TcKFgDtkom9Syok+y8kMXUkvRZu+WGJRwOSYeX3b9LgNn+SqaFEPBzcWGsKf8S3tknHhN5w2GhqSllDEKmbOGBGcZ0qF1MZfiw5KCDb6lPlx36AZTA0SdtASNenhkD93Y4QJVoIvl3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=YA/7nQ35; arc=none smtp.client-ip=212.227.15.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1714468721; x=1715073521; i=markus.elfring@web.de; bh=nJLw8ZzNkHNxUi0RWmfswS2AiqmNNWu4fMk4lAvCziY=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=YA/7nQ35u0kJEg0FSF8UrZNkzte5ooB3jtBpE2Rdi+zYdC3hgcy8exhdzfyApNjY 58hitwap4e8JN6RQmFY9Dlu+yms30IyXqgcL+/a1xWiWGMWgQF0K5Z1lEtoJb7UWj hYmOL5WXrqGWkbvsh6CBFD7UXUQeL4GBPSG5/HfzYzXFJnewkLeN9x6i1/bIdoxfy 4YuOSxp3HX+q/dpsc3+5LdYDfJs037p1fM3WEc/rxR624GOfxZgQutsJKXZ9orgjS uaddWT4fKxTILEwNx5ynqbFnJP1GaKUyxooWuGH3wbMI3qMYhHfiFbXjy4XD87RLM M3aVQOiBt3vyTww0JQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MwjK2-1sqnog3znW-00yQhv; Tue, 30 Apr 2024 11:18:40 +0200 Message-ID: <7d4a29a1-26d2-4b22-8823-ce8e7f9ac534@web.de> Date: Tue, 30 Apr 2024 11:18:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Kent Overstreet , Youling Tang , linux-bcachefs@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org, Youling Tang References: Subject: Re: bcachefs: Fix error path of bch2_link_trans() Content-Language: en-GB From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8JGAxKe1KPyVXekngDfxeASqhnsNJcNDH5Oi18Aw2cRMyhF6Jt3 iEPn4suDWuGcgZp7U9kX7SZpuaSz2PtLj9PCd9KWByfLbn0sudLzTEApmkJ8Z5QJEVfVr+Y oarf2KbY23l1hLnQKWf0P2wOIAWwK0NzF2WNuA29iKKW1nKn17bdveWhnVDt+UW1GdslcMS 7EqHUHolqPCCVF9cyHZvg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:kBKqZET/k9s=;aI40zUrPaZ3NOHwVe3EQtPL9N1H /GkmdmvCi5AY9YcgBQ08ZmsUeH3QI8YFvHJTzlyAv/IxOryjtLMQ4nSApcn9Lp90I1XfvFSRQ u4GSol2OxMeW1ixGekmVsNys8n9aG76Z3ooJ3KmTVwo2h+7tBZeemWLDBWxrk9S/lBdRhmMtc 1R0Yu9boNGtBs9ODrAg5v2OlUH1H5HxLVxz3XSuEeimH6g8Ujz+V0ihp4owzBrkoFiEO4uHbQ 0sRbdolTa+gAHThUOpG1ExGOIyV0oKiIAksFZgx8k1yz/VUrLKeMzWdsTJeXMrqcO+hBWHqny xZdBn+UINmy1mZoIwYCuwYEH21G2gj1wOEGWbJhykamWm26xb2JkfE+XGwdOj7S/7IWysr0wO h5cf3vsPpk9WpJaxU2fqhAtHeMRh0D38SV/RkvJxDU6O+Z+Xta0QseHdax8hapz7LytPcxckS uNdxfBtuYpBj69or8gUQ9TwhuLzDWBJQ7DWtU5zIdsY6zLqm1WS0EkpeoCEbLSJBRCXn9I6Qm CZl8NR5rk+RdTLgDRXORyomg7DE+SANCNH8DAairTHrKJovLubZumvphLhBlVjOpMrDBSksJR AV5jbHoKaxyq9Wh1QREfpBsB16tk9rkJX7LAi4Td+UAfoH62y1f0Mgx/6VpZcV2BIjqkBoiYs /TSuSK6l/lEzmx9dG2cMo95biXxql0oGipEnvFEWJNEYYE5TikNWbSEPmWfjJh67ADJ8fYghU LOaMEJ02dxztEsLKOZorvAcIA+jvVBIjZFSByRxafAollnLFVyI7s+bIopS0fCCcZz5Lqt64p mEVSNkWBJo6xLeZ7MJp9hoLjhQfOi/N+oBY73qkI1cuBA= > > In bch2_link_trans(), if bch2_inode_nlink_inc() fails, it needs to > > call bch2_trans_iter_exit() in the error path. > > Thanks - applied. https://evilpiepirate.org/git/bcachefs.git/commit/?id=3Dd04db1c7653dee5ee5= f918ce951c05eefddad7eb Would it have been nice to add the tag =E2=80=9CFixes=E2=80=9D (besides an= imperative wording) accordingly? Regards, Markus