Received-SPF: pass (google.com: domain of linux-kernel+bounces-163684-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Sai Krishna Gajula <saikrishnag@marvell.com>
To: Herve Codina <herve.codina@bootlin.com>,
        Thomas Gleixner
	<tglx@linutronix.de>, Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski
	<krzk+dt@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        "David S. Miller"
	<davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski
	<kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Lee Jones
	<lee@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Horatiu Vultur
	<horatiu.vultur@microchip.com>,
        "UNGLinuxDriver@microchip.com"
	<UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit
	<hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        Saravana Kannan
	<saravanak@google.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Philipp Zabel
	<p.zabel@pengutronix.de>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen
 Hegelund <Steen.Hegelund@microchip.com>,
        Daniel Machon
	<daniel.machon@microchip.com>,
        Alexandre Belloni
	<alexandre.belloni@bootlin.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
        Allan Nielsen
	<allan.nielsen@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Luca Ceresoli <luca.ceresoli@bootlin.com>,
        Thomas Petazzoni
	<thomas.petazzoni@bootlin.com>
Subject: RE: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset
Thread-Topic: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset
Thread-Index: AQHamt/ZzC0MRaHyQUOivu1NdGJeIg==
Date: Tue, 30 Apr 2024 09:21:57 +0000
Message-ID: 
 <BY3PR18MB4707BE42247B0A418EFEE35EA01A2@BY3PR18MB4707.namprd18.prod.outlook.com>
References: <20240430083730.134918-1-herve.codina@bootlin.com>
 <20240430083730.134918-8-herve.codina@bootlin.com>
In-Reply-To: <20240430083730.134918-8-herve.codina@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?IWtLOlyJUFXNpG4pCW7JqzmPUd1FJg7E5u3kXoWWAMPqKaqXLwm31PzSkIgi?=
 =?us-ascii?Q?QJr6m7Vmhce+N2PrSM0/wFQ8lCTBFmW/29THGON25siy92MLQAtn5c90MuKh?=
 =?us-ascii?Q?f8nAW4MhHsi35HuDwdndhtG4EIKzixBQnZDQqlhwjaISj3ifCgMcKwKHnffh?=
 =?us-ascii?Q?5Y89elpwFxdk6gnc3F7nHckmceLwqYwzSxEz7ChEWE5Lx73hNHxih1AN3ufj?=
 =?us-ascii?Q?4OEEoUBh1xWUsJNfmm6KQZGRepSgiTaOZ0+VeP+IdKNYtiv718rFc2Mpg1QC?=
 =?us-ascii?Q?BSa13OtHCW/pEnj1xj+ByPkRjRqxDtztZgzqfXCaWoG92ILgF/N8/AHtNMWj?=
 =?us-ascii?Q?ZQHVBcxlxwomKB7A68Dd4kssRm6vNBBxktdbXZ/baXBtUU8trKiLLna/l1u6?=
 =?us-ascii?Q?KNGN/Z/4JnMStww7qIEcJpMIMDLXMCLu9ZaUCep5B8KGZV9oVh/z4p/rCoUG?=
 =?us-ascii?Q?Pxf8tCvuVvPwLUHTBrUYPX42+x63w/OstkESgA5Mb+v02+tMx7RzoZa9wpwp?=
 =?us-ascii?Q?fPN6pYGHaYc5CtDZCzgDaT8z43PjNrBoNFQ+mrwmNZZ6qkBFP+tZijavhXko?=
 =?us-ascii?Q?ibMEzWwA1cfsSdqU2Kh/9TgXd5yYC4raKFzPZ6w/3IYhM952YMecJCiHxHlz?=
 =?us-ascii?Q?lDxf4ROfyHz1MVswgwCDNa5ypG/XmhlSf59EK3U8dXWg5sjwATs3bNhlG/BN?=
 =?us-ascii?Q?aRHyqe8XozARP+PMy4LBlwrwN+kp5d6PzolQU2RdTsjuNV+bbfi6Crnnj397?=
 =?us-ascii?Q?3hQtvT7Frd0KDgB2FluMxxEEd4H6YUI9FiiC9n8e79rTdCDIt4hh/bhZg4c+?=
 =?us-ascii?Q?49HJbMyga5RjwU1tqGcZlawAgQi68Kq2l9My7Sdge0mrS9qHheXVTqRkdFnz?=
 =?us-ascii?Q?5zYEudfIMO+ExVSnrqu21jd8AxpeAm101JiUGSAWRLkMUD6UlBG7SUHYSoR+?=
 =?us-ascii?Q?fNsDr3fN1Ssw7207mdinu6EBgAs7+dEQz8l9L+ESQywDrYL2HTxfg/oVPsla?=
 =?us-ascii?Q?yKOP1Kg2VGcUI2PkkG37hQMCdB4b/1nW6w3Ngh+fN4+Aj+yHu2JeqO2/Vf1N?=
 =?us-ascii?Q?uS7h1h/DZQqZ4BWzYzOo2n4+V6TarBoBnkWETYzmqZOBVb1JLHkFfModD6G5?=
 =?us-ascii?Q?skyB7ZInXX1tJgrunm3ceV21D8mVC6h9y5k+eUl6JhFKbtPU/p4DH4LPMEcT?=
 =?us-ascii?Q?ZMwDEyeBQWQ85K/C/8DAorOae4zGwfoB7wntb9u7jEK1xYsgT4mzZbPoQTF7?=
 =?us-ascii?Q?MgXBvwoQHfmIYzcoZm2KX37kmaIFlGKc1CBq89AZxHU0h7h3SvKDrRT7zKrt?=
 =?us-ascii?Q?tcX+oYsF0XL+Y3qWVW2sU/he571rblEXZjlV+IelRhTtnSTd0fLM1/435oWd?=
 =?us-ascii?Q?/BrVS3wBfTmEYGV9Rlbo0grwYVdP6E579yoR9E12pzjzJ5v/N/RG2YNroFEN?=
 =?us-ascii?Q?V06Dbi1TLxXYAN8m7Pwx8k6m2BNbYtJAbfu5Yssu1XczCDza9mjqKeL98+X0?=
 =?us-ascii?Q?GntbQQznR0tYlL2FMlaRupvtBtP84ZpGOlwNFrypYuqNYkVpaRKxphVcca/8?=
 =?us-ascii?Q?A0nfhqtwwvJjuIggqbjSI9BRbX6JBsgFfjSl/i2N?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY3PR18MB4707.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc19a5bd-b99c-4e32-a3c9-08dc68f6fc1b
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2024 09:21:58.0240
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HSS+zKecTeP0NItR2ogPCuoIneZjHwUSmUigofK67NbHkEQSRKTUgTePCmMRya+1smJ/8P9wHM0RRffE/KJE6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR18MB5784
X-Proofpoint-ORIG-GUID: CfTm_nJjGJc9ZOgwQ2HlsVTVwFbPjowh
X-Proofpoint-GUID: CfTm_nJjGJc9ZOgwQ2HlsVTVwFbPjowh
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-30_04,2024-04-29_01,2023-05-22_02


> -----Original Message-----
> From: Herve Codina <herve.codina@bootlin.com>
> Sent: Tuesday, April 30, 2024 2:07 PM
> To: Herve Codina <herve.codina@bootlin.com>; Thomas Gleixner
> <tglx@linutronix.de>; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski
> <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Lee Jones
> <lee@kernel.org>; Arnd Bergmann <arnd@arndb.de>; Horatiu Vultur
> <horatiu.vultur@microchip.com>; UNGLinuxDriver@microchip.com; Andrew
> Lunn <andrew@lunn.ch>; Heiner Kallweit <hkallweit1@gmail.com>; Russell
> King <linux@armlinux.org.uk>; Saravana Kannan <saravanak@google.com>;
> Bjorn Helgaas <bhelgaas@google.com>; Philipp Zabel
> <p.zabel@pengutronix.de>; Lars Povlsen <lars.povlsen@microchip.com>;
> Steen Hegelund <Steen.Hegelund@microchip.com>; Daniel Machon
> <daniel.machon@microchip.com>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org;
> netdev@vger.kernel.org; linux-pci@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; Allan Nielsen <allan.nielsen@microchip.com>;
> Steen Hegelund <steen.hegelund@microchip.com>; Luca Ceresoli
> <luca.ceresoli@bootlin.com>; Thomas Petazzoni
> <thomas.petazzoni@bootlin.com>
> Subject: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch
> reset
>=20
> The mscc-miim device can be impacted by the switch reset, at least when t=
his
> device is part of the LAN966x PCI device.
>=20
> Handle this newly added (optional) resets property.
>=20
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> ---
>  drivers/net/mdio/mdio-mscc-miim.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-
> mscc-miim.c
> index c29377c85307..6a6c1768f533 100644
> --- a/drivers/net/mdio/mdio-mscc-miim.c
> +++ b/drivers/net/mdio/mdio-mscc-miim.c
> @@ -19,6 +19,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/property.h>
>  #include <linux/regmap.h>
> +#include <linux/reset.h>
>=20
>  #define MSCC_MIIM_REG_STATUS		0x0
>  #define		MSCC_MIIM_STATUS_STAT_PENDING	BIT(2)
> @@ -270,11 +271,18 @@ static int mscc_miim_probe(struct platform_device
> *pdev)  {
>  	struct device_node *np =3D pdev->dev.of_node;
>  	struct regmap *mii_regmap, *phy_regmap;
> +	struct reset_control *reset;

Please follow reverse x-mass tree order

>  	struct device *dev =3D &pdev->dev;
>  	struct mscc_miim_dev *miim;
>  	struct mii_bus *bus;
>  	int ret;
>=20
> +	reset =3D devm_reset_control_get_optional_shared(dev, "switch");
> +	if (IS_ERR(reset))
> +		return dev_err_probe(dev, PTR_ERR(reset), "Failed to get
> reset\n");
> +
> +	reset_control_reset(reset);
> +
>  	mii_regmap =3D ocelot_regmap_from_resource(pdev, 0,
>=20
> &mscc_miim_regmap_config);
>  	if (IS_ERR(mii_regmap))
> --
> 2.44.0
>=20