Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp1897433lqa; Tue, 30 Apr 2024 02:30:44 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVPeDXUYEYwvprx147cMu3041YX0tkJ2/17mci+MrCVt832ZbzclBux8i0UDJdbr3u0mNcyVpzbRCIUu7YmHiq8NawseNvSNqP0jmUxfg== X-Google-Smtp-Source: AGHT+IF8bL777+C+VnpMxyW40SR6l7Pn1V2T3wyavKIwHXi0r+ZSrehd6snihgflBEk4cILUNgax X-Received: by 2002:a05:620a:47c2:b0:788:31a1:4a16 with SMTP id du2-20020a05620a47c200b0078831a14a16mr14874084qkb.43.1714469444222; Tue, 30 Apr 2024 02:30:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714469444; cv=pass; d=google.com; s=arc-20160816; b=FmEfZCcEr5wjHS3QVnYZ3yxsxWTydSfUT6uTN0qqBOtlyB4p5thtinDoa6NZM51Bja Bz8eYHHKYUoK8Tk59e/PbECu4whDFZ40qvOG2nbySPJK+oX7mRKJgJTtIeDJAXRNiUgI 1I0vwOchQlTSYv/PRZDpnAb9FNlr0m0GTxGCOaX0jbMRlYfiFvuXYgXgk3iKIqoBLjN3 xmxUQkcolr4kFfaIWSe1KZdlZ/cA2xib4Dgm6W2vcEWJYe5hD3s1ueKGe7Cd4JW2Guv3 zG/w43PT4Umjw26I1BYBAJ2ryEH6rBhcCft0REKz3L8lrc9P4zmNpVqwfz3Sb1QeJhne fIlQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:dkim-signature:message-id; bh=lC3I7ZBJaD+fg9kzuIidBBEutjLohficzyxGQXhxxlA=; fh=Y6/daWk1BrV+SNGbp4UvsUXWRlTjn6vyzM5ghxdQ1Jg=; b=OGXr316uk5uJiYkFtSlKmcwm5qXKI2AUWQ0vh/R6otp8ebmu2c6WIEevFNwmuUjVMS 5Sik8KyniD+zFeqBDll1frSXzsMn6sjNWoP12oe03urVuiOQwXTMECImL1l6oRVkskTa iJU5zpOlNI96QCZbj5S5yP2zP04L0qKbI7WD0t8+nt9V3dDR6VgF579tXJdwtIkZD3B0 cbe5N/OrPvBkWW5YtEWkTno5soBZkPXooy83lI1dOVJG4Oon7U6jXCa+TbX2y3xN0KxP 8V97dOvp24dQH9zkaAeUGrHwn1joRR0oomzZG60QJE0LuoejOK4woAoSHEri3NNZCGxx G/vA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=L9KOUEVH; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-163691-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163691-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id a15-20020a05620a438f00b00790e9ff84bfsi6478889qkp.777.2024.04.30.02.30.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 02:30:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-163691-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=L9KOUEVH; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-163691-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-163691-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DDD1C1C22D52 for ; Tue, 30 Apr 2024 09:30:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 13D30127E25; Tue, 30 Apr 2024 09:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="L9KOUEVH" Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EABFE560 for ; Tue, 30 Apr 2024 09:30:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714469427; cv=none; b=SpAtiAUCpaT/74iFoOycUo8jVpLSDoQU+5P2e+2nnngEH+eLFmfm+YFMBHHqNO+ya4SMqFTlDZH9qEAWdhxAR3BIuUDvDgNewQm2Fa+ixdHBhho/zLA/c3Pag6FbA2S6UURzmuSAZmMl+FIm4ZpmHdObXTi6XoJdoKnZcj5QLxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714469427; c=relaxed/simple; bh=lC3I7ZBJaD+fg9kzuIidBBEutjLohficzyxGQXhxxlA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GLsOk6XsA31Zniqp8Uv/wE/TNGIHcX0XHKjTufDRMEGifB0QTVxnF3QAs/C++7zPg5auqsy+8UGaNYJvOh6CsbBxaYoq/GWkK5c6PFWDEOANl60aO9P610Z7xDsRzHM6Sp+wxzYL7PPpJUuT7Lg0af4yU3g8UNZ9PSdQZ6W2jCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=L9KOUEVH; arc=none smtp.client-ip=95.215.58.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Message-ID: <89354794-c53a-4935-a961-818710ba2fd3@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714469423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lC3I7ZBJaD+fg9kzuIidBBEutjLohficzyxGQXhxxlA=; b=L9KOUEVHAb9nJPSEIiH9SMTkMWT9y+C2fYeSRTKOnztJoXFFijlJ0IaRzxCQ+4vzV4Py3i TEJwMOyMW83eL/y2MxsN3jPpBr06bFybhmyWNu0QNRap6kyotLUepdUzpP2pk8Xdd74Wvs Q4LB9nZlGKu+UEMgYRwC+7WOybcrqcM= Date: Tue, 30 Apr 2024 17:29:54 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: bcachefs: Fix error path of bch2_link_trans() To: Markus Elfring , Kent Overstreet , Youling Tang , linux-bcachefs@vger.kernel.org Cc: LKML , kernel-janitors@vger.kernel.org References: <7d4a29a1-26d2-4b22-8823-ce8e7f9ac534@web.de> Content-Language: en-US, en-AU X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Youling Tang In-Reply-To: <7d4a29a1-26d2-4b22-8823-ce8e7f9ac534@web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Hi, Kent On 30/04/2024 17:18, Markus Elfring wrote: >>> In bch2_link_trans(), if bch2_inode_nlink_inc() fails, it needs to >>> call bch2_trans_iter_exit() in the error path. >> Thanks - applied. > https://evilpiepirate.org/git/bcachefs.git/commit/?id=d04db1c7653dee5ee5f918ce951c05eefddad7eb > > Would it have been nice to add the tag “Fixes” (besides an imperative wording) accordingly? The following labels can be added: Fixes: 962ad1a7666 ("bcachefs: Don't BUG_ON() inode link count underflow") Thanks, Youling.