Received-SPF: pass (google.com: domain of linux-kernel+bounces-163726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Apr 2024 11:53:32 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Claudiu <claudiu.beznea@tuxon.dev>
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, 
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>, Hien Huynh <hien.huynh.px@renesas.com>
Subject: Re: [PATCH v3] mmc: renesas_sdhi: Set the SDBUF after reset
Message-ID: <rekyp45sxw7xtwj7jz3kgnfskroc7z5txbmvmyk4tbw3djqhcn@qyulszizfvc3>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Claudiu <claudiu.beznea@tuxon.dev>, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, 
	linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>, Hien Huynh <hien.huynh.px@renesas.com>
References: <20240430093724.2692232-1-claudiu.beznea.uj@bp.renesas.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="jparjn2ysbxorccu"
Content-Disposition: inline
In-Reply-To: <20240430093724.2692232-1-claudiu.beznea.uj@bp.renesas.com>


--jparjn2ysbxorccu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 30, 2024 at 12:37:24PM +0300, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>=20
> For development purpose, renesas_sdhi_probe() could be called w/
> dma_ops =3D NULL to force the usage of PIO mode. In this case the
> renesas_sdhi_enable_dma() will not be called before transferring data.
>=20
> If renesas_sdhi_enable_dma() is not called, renesas_sdhi_clk_enable()
> call from renesas_sdhi_probe() will configure SDBUF by calling the
> renesas_sdhi_sdbuf_width() function, but then SDBUF will be reset in
> tmio_mmc_host_probe() when calling tmio_mmc_reset() though host->reset().
> If SDBUF is zero the data transfer will not work in PIO mode for RZ/G3S.
>=20
> To fix this call again the renesas_sdhi_sdbuf_width(host, 16) in
> renesas_sdhi_reset(). The call of renesas_sdhi_sdbuf_width() was not
> removed from renesas_sdhi_clk_enable() as the host->reset() is optional.
>=20
> Co-developed-by: Hien Huynh <hien.huynh.px@renesas.com>
> Signed-off-by: Hien Huynh <hien.huynh.px@renesas.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


--jparjn2ysbxorccu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmYwv5cACgkQFA3kzBSg
KbafUxAAsJ3wQuqSl+GQrbsQ7yA7ZNfWhXATEOMhQ0RtTH8zsooQ9MsSs1tsqqwp
Ygi38r8GGo28LkvKV+YjxwA/jBnW02S5hbGajwYsiWuAOVbXtsneFJZ4ea79sQYP
qazKz1Te386vHpPhfKs1d0qTBaaZp1XsD+1P4xd6Y1jak5o7iDca08LlpR0xt3+s
b/F5Gy6GVoM69GWRrertb7evWyiiKc0G+QW+8/eXjixe3DUvu81M1f1vxvF7NKR0
GjMYi/VUQJ5ypYBdyUPd94af3+3Z/URbM6886ugSpHOvj7PTs59zG36ddQ5yLJN0
EZlUoofQZ8b0vYpVEm/JcXXG1BH8EOkaffdj5y67HtrQzj7/Jm68waMaTlQKQ+xO
hMOdhX7lwYlWGVBFrpYX8UzUofwKnqJlk3w4XG37qTy1ZwH/AfdHHHWm5rdtGPFP
IuEFZC0XUGX2aW4XgcKe5UcEGz2bCuqSvmOfUUg1oN553BasKfGIqRnR9innNb76
uxEtrhmjFcQz9ZrBJACgHL0vo5/6NXNZyxx+mwjXWftXLpmmgAr5e6r2x+wGU0o3
4Fi9DlvpJC0N5yjyN3uvI1OhqjD8zh+QyOzHuhWP372es13IpGqYfohxyYrm69Qf
alt+AeYq15lanBxcPbhXGY/CgkqHQjQVGF4M75Dmn+tepwkcpIc=
=vsZz
-----END PGP SIGNATURE-----

--jparjn2ysbxorccu--