Received-SPF: pass (google.com: domain of linux-kernel+bounces-163728-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <54e83ce6-0f9d-45c2-92c7-a41fdb812314@web.de>
Date: Tue, 30 Apr 2024 11:55:31 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V3 1/2] scsi: qla2xxx: Fix double free of fcport in
 qla24xx_els_dcmd_iocb
To: Yongzhi Liu <hyperlyzcs@gmail.com>,
 GR-QLogic-Storage-Upstream@marvell.com, linux-scsi@vger.kernel.org,
 kernel-janitors@vger.kernel.org,
 James Bottomley <James.Bottomley@HansenPartnership.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Nilesh Javali <njavali@marvell.com>, Saurav Kashyap <skashyap@marvell.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Himanshu Madhani <himanshu.madhani@oracle.com>, huntazhang@tencent.com,
 jitxie@tencent.com
References: <9c711441-6e79-422f-9405-ee271929e77c@web.de>
 <20240430091144.10744-1-hyperlyzcs@gmail.com>
Content-Language: en-GB
From: Markus Elfring <Markus.Elfring@web.de>
In-Reply-To: <20240430091144.10744-1-hyperlyzcs@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:xnnnl6+YVLE=;xeE/n0XHGDxpJQ0CevP9kGdutxS
 g9btpkvaRhOiJE77U3pw5fnljnnFQH5pYAiN57vcaB0xwO/ye21AA3dpkRmyQnEUMKjDa3hzg
 YNMLArheBftq8dfeDGepO6hKgjf1iI0BMwQ0236O1g4lPjR0UgilvYWEzC2J4stt5ywAJ5ItS
 kRsGiBJ4sOq7V6Vm2ef0FHjA5V1fB1ojNMh4MX0SL7YCvSkMY2v/P3Ie7a2bBTWL9/5ykJked
 B4/2KtCI6/awJROqlVzPJuoVnpO1tMkp0HD4cv6Bs1iyArwZK/I1dt8usaLUMWFP4/2ywx1D6
 JXXpmgVA8J+qI0kfWoK0/NwctXyn1L7J+i+0SFz/AedV65ufZySDqiibDLCMwty31Kf6hQrTt
 6sIFwnTkBeROeaE5JQrY86FLt9PcnyZRgqN9ktaEz1KQMNe0U/OfF2CDZnD9Nj4ZUoQWLmQwa
 Y/yP33X1P7ScmoJETMjT2FQ4kDe9anKrLsWz0Gi9O1L7elMAEwfD1DYxXfd7mLIcvlYuoiXHM
 EgwbOofMXMGPDX23RS/1MO4Q3seL8V/MsOX8myvcL67IOymIgBTETFxlQ8vGMzFOzDGE3DxKu
 UQmyguuJ8cXH/exswoBFtTg7qdm/VXO1EP2VoUypNzdV4VPVI73KliEtcU6152Z5oWu28Ljsd
 gpnUkuwhjgKbGDuH4mr2+lFi2se7Jc1MGBFeoHHgMfwNvERfDtTAXE3pVLJHokP0/GsdXuTyo
 bl9SAx0xtRoQOcJ98p+PTl14BTnbsWLKNAKVQVMgU0fi7GRiioHls6AsdWFOtupXwWG0xUD9t
 leX0Wk3PVCqeiNvGOK4cTRKZk8fTtR/L+Tdi0koODolGA=

* I would usually expect a corresponding cover letter for patch series.

* Would you like to add parentheses to the function name in the summary ph=
rase?


> When dma_alloc_coherent() or qla2x00_start_sp() return an error,

                                                  call returned?


> the callback function qla2x00_els_dcmd_sp_free in qla2x00_sp_release
> will call qla2x00_free_fcport() to kfree fcport. We shouldn't call

                                     free =E2=80=9Cfcport=E2=80=9D?


> qla2x00_free_fcport() again in the error handling path.

                                                    paths?


> Fix this by cleaning the duplicate qla2x00_free_fcport() calls up.

Would the wording =E2=80=9CThus delete duplicate qla2x00_free_fcport() cal=
ls.=E2=80=9D be a bit nicer?


=E2=80=A6
> ---
> V2 -> V3: Improve patch summary and provide a patch serises with two sep=
arate update steps
=E2=80=A6

* How do you think about to avoid the repetition of version identifiers
  (according to the selected enumeration style)?

* You would probably like to avoid another typo here.

Regards,
Markus