Received-SPF: pass (google.com: domain of linux-kernel+bounces-163810-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240425110017.75238-1-joshua.yeong@starfivetech.com> <20240429032146.2d3t7bai7k6cotqt@vireshk-i7>
In-Reply-To: <20240429032146.2d3t7bai7k6cotqt@vireshk-i7>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 30 Apr 2024 12:56:38 +0200
Message-ID: <CAJZ5v0iY9CQPRWub_Mk3LyZX_41Y_L4Gjm302X=GjcnhRiu1vw@mail.gmail.com>
Subject: Re: cpufreq: Fix printing large cpu and cpufreq number
To: Viresh Kumar <viresh.kumar@linaro.org>, Joshua Yeong <joshua.yeong@starfivetech.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 5:21=E2=80=AFAM Viresh Kumar <viresh.kumar@linaro.o=
rg> wrote:
>
> On 25-04-24, 19:00, Joshua Yeong wrote:
> > Fix printing negative number when CPU frequency
> > with large number.
> >
> > Signed-off-by: Joshua Yeong <joshua.yeong@starfivetech.com>
> > ---
> >  drivers/cpufreq/freq_table.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.=
c
> > index c17dc51a5a02..9b9568023f3c 100644
> > --- a/drivers/cpufreq/freq_table.c
> > +++ b/drivers/cpufreq/freq_table.c
> > @@ -194,7 +194,7 @@ int cpufreq_table_index_unsorted(struct cpufreq_pol=
icy *policy,
> >       }
> >       if (optimal.driver_data > i) {
> >               if (suboptimal.driver_data > i) {
> > -                     WARN(1, "Invalid frequency table: %d\n", policy->=
cpu);
> > +                     WARN(1, "Invalid frequency table: %u\n", policy->=
cpu);
> >                       return 0;
> >               }
> >
> > @@ -254,7 +254,7 @@ static ssize_t show_available_freqs(struct cpufreq_=
policy *policy, char *buf,
> >               if (show_boost ^ (pos->flags & CPUFREQ_BOOST_FREQ))
> >                       continue;
> >
> > -             count +=3D sprintf(&buf[count], "%d ", pos->frequency);
> > +             count +=3D sprintf(&buf[count], "%u ", pos->frequency);
> >       }
> >       count +=3D sprintf(&buf[count], "\n");
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> --

Applied as 6.10 material with edited subject and changelog, thanks!