Received-SPF: pass (google.com: domain of linux-kernel+bounces-163909-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 30 Apr 2024 14:21:57 +0200
From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Andrew Hepp <andrew.hepp@ahepp.dev>,
	Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] iio: temperature: mcp9600: set channel2 member
Message-ID: <20240430122157.GA46332@debian>
References: <20240430120535.46097-1-dima.fedrau@gmail.com>
 <20240430120535.46097-2-dima.fedrau@gmail.com>
 <20240430131102.00005e58@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240430131102.00005e58@Huawei.com>

Am Tue, Apr 30, 2024 at 01:11:02PM +0100 schrieb Jonathan Cameron:
> On Tue, 30 Apr 2024 14:05:31 +0200
> Dimitri Fedrau <dima.fedrau@gmail.com> wrote:
> 
> > Set channel2 member of channel 0 to IIO_MOD_TEMP_OBJECT and set modified
> > member to 1.
> This an ABI change, so needs a strong argument + must be a fix 
> rather than an improvement.  So why does this need to change?
>
Hi Jonathan,

I don't know if it is an valid argument but when using tool "iio_info"
the temp_object wasn't displayed at all. After adding these two lines
the temp_object is displayed. Don't know if it is a problem with the
userspace tools.

iio_info version: 0.25 (git tag:b6028fde)
Libiio version: 0.25 (git tag: b6028fd) backends: local xml ip usb serial

Besides that it eases distinction between the two channels in the last
patch, but I think this argument is not strong enough. :)

Best regards,
Dimitri

> 
> > 
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > ---
> >  drivers/iio/temperature/mcp9600.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperature/mcp9600.c
> > index 7a3eef5d5e75..e277edb4ae4b 100644
> > --- a/drivers/iio/temperature/mcp9600.c
> > +++ b/drivers/iio/temperature/mcp9600.c
> > @@ -26,6 +26,8 @@ static const struct iio_chan_spec mcp9600_channels[] = {
> >  	{
> >  		.type = IIO_TEMP,
> >  		.address = MCP9600_HOT_JUNCTION,
> > +		.channel2 = IIO_MOD_TEMP_OBJECT,
> > +		.modified = 1,
> >  		.info_mask_separate =
> >  			BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
> >  	},
>