Received-SPF: pass (google.com: domain of linux-kernel+bounces-163917-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240425183810.3079069-1-robh@kernel.org> <9e1195f05f4eced0a158c49616deba6a.sboyd@kernel.org>
In-Reply-To: <9e1195f05f4eced0a158c49616deba6a.sboyd@kernel.org>
From: Rob Herring <robh@kernel.org>
Date: Tue, 30 Apr 2024 07:33:45 -0500
Message-ID: <CAL_JsqJUMPMv8YuRgaWL+1it07vrn-U0nLckMkPPVF-QzJOcew@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: clock: fixed: Define a preferred node name
To: Stephen Boyd <sboyd@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Michael Turquette <mturquette@baylibre.com>, linux-clk@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 29, 2024 at 7:11=E2=80=AFPM Stephen Boyd <sboyd@kernel.org> wro=
te:
>
> Quoting Rob Herring (Arm) (2024-04-25 11:38:09)
> > diff --git a/Documentation/devicetree/bindings/clock/fixed-clock.yaml b=
/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > index b0a4fb8256e2..d287bd092054 100644
> > --- a/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/fixed-clock.yaml
> > @@ -11,6 +11,13 @@ maintainers:
> >    - Stephen Boyd <sboyd@kernel.org>
> >
> >  properties:
> > +  $nodename:
> > +    anyOf:
> > +      - description: Preferred name is 'clock-<freq>'
>
> Is the preferred value of <freq> the clock-frequency property? Should
> say that explicitly somehow so that it's clear.

Yes, will add.

> > +        pattern: "^clock-([0-9]+|[a-z0-9-]+)$"
> > +      - description: Any name allowed
> > +        deprecated: true
> > +
> >    compatible:
> >      const: fixed-clock
> >
> > diff --git a/Documentation/devicetree/bindings/clock/fixed-factor-clock=
yaml b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> > index 8f71ab300470..962a1fe85416 100644
> > --- a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml
> > @@ -11,6 +11,14 @@ maintainers:
> >    - Stephen Boyd <sboyd@kernel.org>
> >
> >  properties:
> > +  $nodename:
> > +    anyOf:
> > +      - description:
> > +          Preferred name is 'clock-<freq>' if the input frequency is f=
ixed
>
> Similar question here. Is <freq> supposed to be the output clock frequenc=
y?

Yes.

>
> > +        pattern: "^clock-([0-9]+|[0-9a-z-]+)$"
> > +      - description: Any name allowed
> > +        deprecated: true
>
> I hope that deprecating this doesn't cause folks to try to clean things
> up and then break code that's depending on the node name to be the name
> of the clk. We don't want that string name to be important but it is
> sometimes.

Right. Leaving things as-is is the intent. We won't be enabling any
"no deprecated" mode by default when it is added.


Rob