Received-SPF: pass (google.com: domain of linux-kernel+bounces-163958-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 30 Apr 2024 15:07:24 +0200
Message-ID: <87ikzzm22b.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Baojun Xu <baojun.xu@ti.com>
Cc: <robh+dt@kernel.org>,
	<andriy.shevchenko@linux.intel.com>,
	<lgirdwood@gmail.com>,
	<perex@perex.cz>,
	<pierre-louis.bossart@linux.intel.com>,
	<kevin-lu@ti.com>,
	<shenghao-ding@ti.com>,
	<navada@ti.com>,
	<13916275206@139.com>,
	<v-po@ti.com>,
	<niranjan.hy@ti.com>,
	<alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>,
	<liam.r.girdwood@intel.com>,
	<yung-chuan.liao@linux.intel.com>,
	<broonie@kernel.org>,
	<soyer@irl.hu>
Subject: Re: [PATCH v4 2/3] ALSA: hda/tas2781: Tas2781 hda driver for SPI
In-Reply-To: <20240430072544.1877-3-baojun.xu@ti.com>
References: <20240430072544.1877-1-baojun.xu@ti.com>
	<20240430072544.1877-3-baojun.xu@ti.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Tue, 30 Apr 2024 09:25:43 +0200,
Baojun Xu wrote:
> 
> Main source code for tas2781 hda driver for SPI.
> 
> Signed-off-by: Baojun Xu <baojun.xu@ti.com>

That's far little description than wished.  You can copy the contents
of your cover letter to here, for example, for more detailed
information.

Second, and most: this patch breaks again the build.
You added the code calling functions that aren't defined yet
(appearing in the patch 3).

Also, some functions seem defined but not really used, e.g.
tasdevice_spi_calbin_remove(), and some are not needed to be global
functions.


thanks,

Takashi