Received-SPF: pass (google.com: domain of linux-kernel+bounces-163993-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Apr 2024 16:21:31 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: jgg@ziepe.ca, wenglianfa@huawei.com, gustavoars@kernel.org,
	lishifeng@sangfor.com.cn, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/core: Remove NULL check before dev_{put, hold}
Message-ID: <20240430132131.GG100414@unreal>
References: <Zi5QgLIt9sblrfYs@octinomon.home>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Zi5QgLIt9sblrfYs@octinomon.home>

On Sun, Apr 28, 2024 at 02:34:56PM +0100, Jules Irenge wrote:
> Coccinelle reports a warning
> 
> WARNING: NULL check before dev_{put, hold} functions is not needed

Please do it for whole drivers/infiniband/core in one patch, please.

> 
> The reason is the call netdev_{put, hold} of dev_{put,hold} will check NULL
> There is no need to check before using dev_{put, hold}
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/infiniband/core/device.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 07cb6c5ffda0..84be4bb9b625 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -2235,8 +2235,7 @@ struct net_device *ib_device_get_netdev(struct ib_device *ib_dev,
>  		spin_lock(&pdata->netdev_lock);
>  		res = rcu_dereference_protected(
>  			pdata->netdev, lockdep_is_held(&pdata->netdev_lock));
> -		if (res)
> -			dev_hold(res);
> +		dev_hold(res);
>  		spin_unlock(&pdata->netdev_lock);
>  	}
>  
> -- 
> 2.43.2
>