Received-SPF: pass (google.com: domain of linux-kernel+bounces-164023-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Apr 2024 09:36:05 -0400
From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-kselftest@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v1] selftests: mm: gup_longterm: test unsharing logic
 when R/O pinning
Message-ID: <ZjDzxcrP_tDxo-X6@x1n>
References: <20240430131508.86924-1-david@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240430131508.86924-1-david@redhat.com>

On Tue, Apr 30, 2024 at 03:15:08PM +0200, David Hildenbrand wrote:
> In our FOLL_LONGTERM tests, we prefault the page tables for the GUP-fast
> test cases to be able to find a PTE and exercise the "longterm pinning
> allowed" logic on the GUP-fast path where possible.
> 
> For now, we always prefault the page tables writable, resulting in PTEs
> that are writable.
> 
> Let's cover more cases to also test if our unsharing logic works as
> expected (and is able to make progress when there is nothing to unshare)
> by mprotect'ing the range R/O when R/O-pinning, so we don't get PTEs
> that are writable.
> 
> This change would have found an issue introduced by commit a12083d721d7
> ("mm/gup: handle hugepd for follow_page()"), whereby R/O pinning was not
> able to make progress in all cases, because unsharing logic was not
> provided with the VMA to decide at some point that long-term R/O pinning
> a !anon page is fine.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: Peter Xu <peterx@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Acked-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu