Received-SPF: pass (google.com: domain of linux-kernel+bounces-164039-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 30 Apr 2024 15:47:59 +0200
From: Borislav Petkov <bp@alien8.de>
To: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: robert.richter@amd.com, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org,
	Avadhut.Naik@amd.com, John.Allen@amd.com
Subject: Re: [PATCH v2 07/16] x86/mce/amd: Simplify DFR handler setup
Message-ID: <20240430134759.GBZjD2j942leiJGSrQ@fat_crate.local>
References: <20240404151359.47970-1-yazen.ghannam@amd.com>
 <20240404151359.47970-8-yazen.ghannam@amd.com>
 <20240424190658.GHZilYUvw1KfSfVd_e@fat_crate.local>
 <e0d10606-4472-4cde-b55d-34180efad42b@amd.com>
 <20240429125956.GNZi-ZzN1Izxps8ztT@fat_crate.local>
 <d1e329da-6a04-47f7-bdab-ea6c4f584802@amd.com>
 <20240429141244.GGZi-q3NdmI17pai4N@fat_crate.local>
 <891ec639-e557-4dbe-8afa-3317b9c173ce@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <891ec639-e557-4dbe-8afa-3317b9c173ce@amd.com>

On Mon, Apr 29, 2024 at 10:25:02AM -0400, Yazen Ghannam wrote:
> Yep, "MCA init cleanup" is another thing on my TODO list.

Right, so looking at the code, early_identify_cpu()/identify_boot_cpu()
could call a

mca_bsp_init()

or so which does the once, vendor-agnostic setup.

identify_cpu->mcheck_cpu_init()

already does both the BSP and AP per-CPU init.

With such a split, I think we'll have all the proper places to do setup
at the right time without hackery.

> The BSP still completely finishes init before the APs, correct?

Yes.

> I recall some effort to make CPU init more parallel, but I haven't
> been following it.

I think you mean parallel hotplug but that's for the APs only.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette