Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp2039383lqa; Tue, 30 Apr 2024 06:55:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU/WZG7RNqbINNqgI+cyoxKGYtSsxrjz1wSQ/3O8GEXBp3wqv1ySWA2kuRdhc32beBZyUghoVsTkBvpVuE92t6kyu90IH92/EPbwI/Tqw== X-Google-Smtp-Source: AGHT+IHsc9o7Fvjxblx24qEc2mkaGLiQlzZriKMHVeeWbLw8OmGOJEI0BuFjuOvOIJnJJJlM9OYk X-Received: by 2002:a17:902:e843:b0:1e4:10d9:5dfb with SMTP id t3-20020a170902e84300b001e410d95dfbmr3255869plg.38.1714485302198; Tue, 30 Apr 2024 06:55:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714485302; cv=pass; d=google.com; s=arc-20160816; b=G626Nyc3lqC7dwJ5E/2tX8YkiCDxkZPy3hbdEyjKywoBiKWyZ00X0D73sqI9VM8YvB 1G5dQipTp1s67P1/Ps0BfIfrPP1LJRq1x9xt1pjHnOQIAJ8PREIfbpvKf5LaCEZrS/Mx B1IlpCDjplMWK5EOFDrEiygXs8wodT8CrrPf/0vSsYxPi5EXlB6kchRHkDezf1mZUxmC 7dyioKGTQeTLmYMSPF3bOZ0EpmzaIrW5EBajCQdj5bTnIyknHrJw1WJcR514qRsf+azF JPSwskzEUyLCCFqhxu/WgvWczQja2/4Ed1DiggUKgMkvDCqLFgbfBUfJSpZUEo+BWqqx CWWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:subject:cc:to:from:date:dkim-signature; bh=WMKLboavbUox63AeT++4XJft+PszM72LOAImYWoY0FQ=; fh=lk7j1tUxd3U7SrnKenF92nJ6+nhs1P4EO7UllI1dmqE=; b=q1I8ngUeMqwhGXCx9k9GAezs1mQKANxd8rL2ZfKJt4C8YXAA17dRibthYslEvUXf++ SrXGP1gV1axpYTTuniWUpveJiTB8E/HhNT0sTdv+R4leiB1bRBx5aPCxkmq+AVnkuezD gOAt8d25AsZbtwvFYGD963mI21fczmNW5FuOJ8VC/amGwzTR7kjsI90QLGj0iEeS2AVl i9sH3xKXTiBHJCxTgHxqQrDAUr9+acWEWHhucR8cnsnKkuOC+F5D8pqU/u005HgSc4E6 l1HUbcfmzOx3gYDk6dVMatlF2gCiUT6ruEPkAasOh+CrzUOGLdrzzhTj76xGQmSKp1Vr oS1g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@digikod.net header.s=20191114 header.b=QRhixgYn; arc=pass (i=1 spf=pass spfdomain=digikod.net dkim=pass dkdomain=digikod.net); spf=pass (google.com: domain of linux-kernel+bounces-164043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164043-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u13-20020a170902e5cd00b001e3e09beb25si22182532plf.223.2024.04.30.06.55.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 06:55:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@digikod.net header.s=20191114 header.b=QRhixgYn; arc=pass (i=1 spf=pass spfdomain=digikod.net dkim=pass dkdomain=digikod.net); spf=pass (google.com: domain of linux-kernel+bounces-164043-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164043-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 04912B20F23 for ; Tue, 30 Apr 2024 13:54:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C361317279C; Tue, 30 Apr 2024 13:54:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="QRhixgYn" Received: from smtp-bc0a.mail.infomaniak.ch (smtp-bc0a.mail.infomaniak.ch [45.157.188.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E428171E6E for ; Tue, 30 Apr 2024 13:54:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.157.188.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714485292; cv=none; b=afrN6hhgTjWTDKfXA/TSTkmbN77XZFHO2rwtmmvrEFcfC3cJxL/6rSOvRAGVzLAc6B67YaXYijxvcLVpOofjR8OoqlmZ0BvubtAIyD3VUGd9eFp9zGDy6eaQr2/lsYwaR+zLc+bNY+qkNcUPClNyBXuzN6GYbmLyfzWlckGD6OY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714485292; c=relaxed/simple; bh=j7uCyw9gJWCykaUxpDFOXMmF9t4ZvW27l4JLBpjd2og=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=ZEZsxsXAMRo5Tx80KHeIU5xlGT2nVWf8/lGl1CULQxUSlrkqsn122B/hX1ozfdqeErpCiP3CWaGI/8TojRJI10QNk+1M9VnT8SMnfTeUhVTt8kqhszUT0OY6/liuSzPBo2NIm+JQWJYEMyS7mXjgUUy9gHVEI/17Hosb4f0RKpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=QRhixgYn; arc=none smtp.client-ip=45.157.188.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4VTMBm3dQPzrnc; Tue, 30 Apr 2024 15:54:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=digikod.net; s=20191114; t=1714485280; bh=j7uCyw9gJWCykaUxpDFOXMmF9t4ZvW27l4JLBpjd2og=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=QRhixgYnlBaRvvyb3lebMIaeuqK1e5AWRewZ92+iiAJoapexwVWFLHAAv5v6MKpj9 vDysK6E3qcIRS0TbubkMImRRoYgbuhwLQ/qsfv6WLy2A/7aWpc0gWaMgtyDs5hLTpB mDZJgdAvUcoaA56JS2/diOTsOq6ZTjHvY+a0O0WQ= Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4VTMBl3881zNKv; Tue, 30 Apr 2024 15:54:39 +0200 (CEST) Date: Tue, 30 Apr 2024 15:54:38 +0200 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Shuah Khan , Jakub Kicinski , Mark Brown Cc: Christian Brauner , Kees Cook , Shengyu Li , "David S . Miller" , =?utf-8?Q?G=C3=BCnther?= Noack , Will Drewry , kernel test robot , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 0/9] Fix Kselftest's vfork() side effects Message-ID: <20240430.eudae0Mahbie@digikod.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240429191911.2552580-1-mic@digikod.net> X-Infomaniak-Routing: alpha Shuah, could you please take this series in your tree and push it to next? This mainly fixes an issue in the pidfd tests and we should get this merged before the final 6.9 release. Thanks. Jakub, can you please review it? Mark, it would be good to have your Tested-by tags. :) On Mon, Apr 29, 2024 at 09:19:02PM +0200, Mickaël Salaün wrote: > Hi, > > As reported by Kernel Test Robot [1], some pidfd tests fail. This is > due to the use of vfork() which introduced some side effects. > Similarly, while making it more generic, a previous commit made some > Landlock file system tests flaky, and subject to the host's file system > mount configuration. > > This series fixes all these side effects by replacing vfork() with > clone3() and CLONE_VFORK, which is cleaner (no arbitrary shared memory) > and makes the Kselftest framework more robust. > > I tried different approaches and I found this one to be the cleaner and > less invasive for current test cases. > > This third series replace improve the clone3_vfork() helper and add > Reviewed-by tags. > > I successfully ran the following tests (using TEST_F and > fork/clone/clone3) with this series: > - landlock:fs_test > - landlock:net_test > - landlock:ptrace_test > - move_mount_set_group:move_mount_set_group_test > - net/af_unix:scm_pidfd > - perf_events:remove_on_exec > - pidfd:pidfd_getfd_test > - pidfd:pidfd_setns_test > - seccomp:seccomp_bpf > - user_events:abi_test > > [1] https://lore.kernel.org/oe-lkp/202403291015.1fcfa957-oliver.sang@intel.com > > Previous versions: > v1: https://lore.kernel.org/r/20240426172252.1862930-1-mic@digikod.net > v2: https://lore.kernel.org/r/20240429130931.2394118-1-mic@digikod.net > > Regards, > > Mickaël Salaün (9): > selftests/pidfd: Fix config for pidfd_setns_test > selftests/landlock: Fix FS tests when run on a private mount point > selftests/harness: Fix fixture teardown > selftests/harness: Fix interleaved scheduling leading to race > conditions > selftests/landlock: Do not allocate memory in fixture data > selftests/harness: Constify fixture variants > selftests/pidfd: Fix wrong expectation > selftests/harness: Share _metadata between forked processes > selftests/harness: Fix vfork() side effects > > tools/testing/selftests/kselftest_harness.h | 113 +++++++++++++----- > tools/testing/selftests/landlock/fs_test.c | 83 ++++++++----- > tools/testing/selftests/pidfd/config | 2 + > .../selftests/pidfd/pidfd_setns_test.c | 2 +- > 4 files changed, 135 insertions(+), 65 deletions(-) > > > base-commit: e67572cd2204894179d89bd7b984072f19313b03 > -- > 2.44.0 >