Received-SPF: pass (google.com: domain of linux-kernel+bounces-164045-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Apr 2024 10:54:58 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 1/6] iommu/arm-smmu-v3: Pass in cmdq pointer to
 arm_smmu_cmdq_issue_cmdlist()
Message-ID: <20240430135458.GO941030@nvidia.com>
References: <cover.1714451595.git.nicolinc@nvidia.com>
 <0acb55059f7212abdf4277a81e2f033127072bc9.1714451595.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0acb55059f7212abdf4277a81e2f033127072bc9.1714451595.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?jazuUsGmwZH0ijnMKwFKRiNcYIKPvWsHW8KgeGRP/t8R6qCf2Z/qhPcF7luX?=
 =?us-ascii?Q?nXAcXf1BSf42E9eAgxLU9Q5s/5sD3ag7q6cpqb6S6phv7+DrrESPq9XA7crv?=
 =?us-ascii?Q?zvyVma7J1ajHQ+EkNMAx01s3IGz/+SxtxgadEiMg+RnM/AnUxEu8rDVG9n4N?=
 =?us-ascii?Q?cXzIij53APJ0aGWoD+djZiwzoL3Ms1bScshidubzNbKqugAF10EDI7oDIHkp?=
 =?us-ascii?Q?UVN8fy5vryx3mWvQd6ykl3h12ptemW3b/8rM9RlAwEB40RFQxqvVLNQ9tZPW?=
 =?us-ascii?Q?Tp1dbD+D7Z/NxyBJE8uLCY98/tQvEwV0uN0UgNduKuvIIm8wlVc3Te37K6e4?=
 =?us-ascii?Q?qdgnfaFNsqt5DzT7/uPZAsn6JgKYMr6dqeumQbyLCyd5sxkdTa9aXpIhk7b4?=
 =?us-ascii?Q?AZAMgjzmu760+tdM+NhEbU5bXetoUz4PQZzNtvjmjiQtgRNjnqF74/1HLVQl?=
 =?us-ascii?Q?CKh0dz2CSI0+Qq3ctt6mEFiTqkVERsspcdIusGsHY4ISV448FJIVk2YqcKpZ?=
 =?us-ascii?Q?pHmBVFg9k4g6bizMKkszEq2Nomps9fkzipU5KsCsmNpUfFflUAlbYnlzV5H8?=
 =?us-ascii?Q?SZ00vc6EqYALJmslDxL+I8vD+7yDlJ0ICop2e9oAKNvkCxwctn5vI/eXMQ3h?=
 =?us-ascii?Q?Pk96OHQuTMO6Jvf9LNrdEfTEZKP3ZFYpQK4Dyn07/hmMOOymhBLl86IzpXJq?=
 =?us-ascii?Q?90GbghLd4aLMAKtnRaebywb4LFudEFl7OSfNYphLYR60Fm/+OQmJTJuLLpiB?=
 =?us-ascii?Q?NTiuCLQxPErEo2YWwYadugkbLBMjTnRy7538samlnT2o9TfCiKnB7mtmxZIc?=
 =?us-ascii?Q?+isbCuMQcrG/jtS83GuzO0SVem6vBUcNZZovX3bdK3kSwrqinpPRALegyAYa?=
 =?us-ascii?Q?yR13ZaAabRGGEhYNtTFRsu0xvtaxPgGQR2LRKHLTqlOSH+DwG6v+4NY7QQQu?=
 =?us-ascii?Q?rptcbdCxnQcm31ykk+JHVU29wS+zRK3bdetpoCTk0EfkU5zrnWkj21KE/P13?=
 =?us-ascii?Q?wyIT1vqzZ7+64a248OJefkq1Y5fbKl8uyUMZ6zs5lo9qswqDTjc1JVNGl5S1?=
 =?us-ascii?Q?jdsgcy5D6TKx3cbvV0GU/j16f6PJ0KzFmxM9+wy9s6wZ6PBMrc5l61UWrJxB?=
 =?us-ascii?Q?xlcZnePx0hP3UtZw1SAMckMe0GvdC6zUGYPk9CDyQ7Flw2zeBOLaA4k83ZS3?=
 =?us-ascii?Q?s11iHi4NbOSxXwupMDQD2JIBeA10AcfGMeWhW7ZvNSjoHN56QQRuPM6GJGbj?=
 =?us-ascii?Q?zryhXSwfZ9Eu/Vosw3Udtk11bQ/MbnXWcJTrGKXI4QkHbSIYG3F0WtObzESU?=
 =?us-ascii?Q?eoed4Xq2EBB0OhzcgFy0upKceQIQdFmHVoNP5ft9agnsIYRN5n+5ASNbWUDU?=
 =?us-ascii?Q?+3kE96g1et40oEosTTuMtdDWnGqWjJp4ooeT43jOQLnAyp0ynEjKFXo2VFtw?=
 =?us-ascii?Q?VM3jse1chlP5MHLn/EXoPeDsA/6cVrwEjKeLUJ5nFH1bd84yRTn5Bxoe9prv?=
 =?us-ascii?Q?fjrZuGfx1mPdoKt1ZgvXqzfIAeDsfflPVeclFsqd18vOtlom2IZCmU+kKg6l?=
 =?us-ascii?Q?+AB8QrXsJWwt5cjm0bcHQU9FYe64JjQfx8CgcG0g?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d08aa4b8-de21-44c2-044f-08dc691d20a9
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 13:55:00.4000
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kQB10nCy5pK/wzIJY0X92A7aP1rM6bmmPEukNshMFZjYMBOCF27h/+dzsDCfsQQv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7169

On Mon, Apr 29, 2024 at 09:43:44PM -0700, Nicolin Chen wrote:
> The driver currently calls arm_smmu_get_cmdq() helper in different places,
> although they are all called from the arm_smmu_cmdq_issue_cmdlist().
> 
> Allow to pass in the cmdq pointer, instead of calling arm_smmu_get_cmdq()
> every time.
> 
> This will also help CMDQV extension in NVIDIA Tegra241 SoC, as its driver
> will maintain its own cmdq pointers, then need to redirect arm_smmu->cmdq
> to one of its vcmdqs upon seeing a supported command.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason