Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp2048846lqa; Tue, 30 Apr 2024 07:05:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXg8g9vS1hIx55c6d8hRkQWONtjUlmYo4iR9fEEBWCPvgc2FHEuafwidTj9YaWmMgV8wMSaUjJFLTFTVEQCF/rtp9lQpPYlt88O0UXp3g== X-Google-Smtp-Source: AGHT+IHnUMOb7j82jpQpP30pO7T5Jtz3xnVEeKAiTbIFll6WgS5WgTycf/TkJZ+Ihw06vzzE17zo X-Received: by 2002:a05:6830:410b:b0:6ee:ca2:523 with SMTP id w11-20020a056830410b00b006ee0ca20523mr3705882ott.26.1714485915143; Tue, 30 Apr 2024 07:05:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714485915; cv=pass; d=google.com; s=arc-20160816; b=jLzfrx3JHLAiMKi9muQV6qooAubth7tOWWHslq9V9JVkn/XmElmg0VIj9kmSvHtUOs +af3ajZY2DVrkkmKlzvwPs7W0jQYlcWF9o3vpvtD1wSk5BeeC1rWU29ygTUUFg6x2b8D P57NzDpxVvlhctUD66jQ9LxExFsWrHEigI7MeV+0GvWhM+UywNJKiPovzFxbs1/5VIqD 7Q29vn7xwa5ohqEoP09jTOHGWgPR7J1qSk1Bu5kcbVzxojhswwKkDH/lZzGyeqxrwcj3 fhYy9n+g4XpzyWZQ7+xVoBlxX75Bh1WMRxF1ZpzoxCg2W9WNyntgQeENJuRC9tIK8CQu vn7A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cAKC+FytbCMqRhx/bKnkjsTVy7JI3n8TWD+vJCpv8t4=; fh=yroVL5W+anpDZI5K0fU2gzdirmXOU/GyUvNeEMKqLNo=; b=IWaqW5QT58/xXMUYIzWEa8bWQ7xIU66ag4FhKfZOa/6CHkeYM5NpmspKEgAtqPPHH2 34pzn2r7ZxTx0z8wdR2Tt35323Yjao1lUGeFTs8ghjczMHbyCThFjh7rkM7LCpw4XlPH pF/MLUERdQd3Sg1r//iZVDEQWSOxYQKqa0pX5phWW4NpKPO6ehANXo1dSpSptkSHGvEK 6h4+M7FlDH+nVEKlmg7kfhMuIziGb6pO6HL9unLAzdthmmtVH9IIvEfFN7gBxk2Zvr+L U2rFXE/ObNrDnOznbyPb3i25MdIlbKZYW6yvuLb7rkHPrn2gH5cYpnIOwz9ulup/xV/1 XuaQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=FftPWpOh; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-164058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164058-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id c25-20020a056830001900b006ee51608b63si1037236otp.47.2024.04.30.07.05.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 07:05:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=FftPWpOh; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-164058-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164058-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6A9882849AC for ; Tue, 30 Apr 2024 14:04:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F11D817F388; Tue, 30 Apr 2024 14:01:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="FftPWpOh" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7445217BB1B; Tue, 30 Apr 2024 14:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714485694; cv=none; b=XenbudA+T5/yMFYFszynqMzXmQLh6eF1zy/l4vc8nDt593VWx2WvGb5LeMhXekt7lmPol1cMQzWBfWmGN2nWan9gW3nj/mn95Qpz5OGNCa/svBdJcmA6DdtMvKJwyupI1xPZzFSIrq/4xvrPueZmmgNEYcUOVIcilBYQN//qOMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714485694; c=relaxed/simple; bh=fOkQvKx3TkjoVLbIXCLjIhXaPdmdNknggbtEf/cT3yY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Nc8UjCh1WexD2aqfOsNFiD2Da2hn9xC3gqwkoTqNJsHDpi8G7RIv1UQ9lsR+lYJecTCzIE22sUlo8snkrX6n0x88iogN7Es8RmOoJPnduf5GbWAvJhojJUgQsfjtJmG3yQ5zLLLiz3xWHBls189jzw8k3sifGaxnxlatk6sMrfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=FftPWpOh; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=cAKC+FytbCMqRhx/bKnkjsTVy7JI3n8TWD+vJCpv8t4=; b=FftPWpOhN2IU3ZbF5sbRbfzVgt nMLGfJs77c0MbKf6spQZjQHA6ABKs/zK4WZHPpg73aq5Vbaj65Qz6ZYA16QahFl+DhqRb/Or1PzWj ezxloudXaRZU+n6QiZr8F2ie8a8YkYi0M8F1eQOtD34hsUGSYWZioTPm+djth2ucU8r4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s1o2j-00ELSx-DV; Tue, 30 Apr 2024 16:01:13 +0200 Date: Tue, 30 Apr 2024 16:01:13 +0200 From: Andrew Lunn To: Herve Codina Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni , stable@vger.kernel.org Subject: Re: [PATCH 08/17] net: lan966x: remove debugfs directory in probe() error path Message-ID: References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-9-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240430083730.134918-9-herve.codina@bootlin.com> On Tue, Apr 30, 2024 at 10:37:17AM +0200, Herve Codina wrote: > A debugfs directory entry is create early during probe(). This entry is > not removed on error path leading to some "already present" issues in > case of EPROBE_DEFER. > > Create this entry later in the probe() code to avoid the need to change > many 'return' in 'goto' and add the removal in the already present error > path. > > Fixes: 942814840127 ("net: lan966x: Add VCAP debugFS support") > Cc: > Signed-off-by: Herve Codina Reviewed-by: Andrew Lunn Andrew