Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp2060827lqa; Tue, 30 Apr 2024 07:17:03 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVu18qeEMEyV3WWFIzFMt2DSCfA/GDIPJXzAfvulde525/IXG9ykt5hDSmrCDyfKEmP+CZ7jQGB3faaTnmcLwB1yKXeTjposL7Z8Gm03Q== X-Google-Smtp-Source: AGHT+IHDdUxZeWgjFqsxwA8oW2tqtdlDnVGC+JEXPDU5FlCsTYOoTL1TYWurj08zcuHLDSnkU9TO X-Received: by 2002:a05:6808:192a:b0:3c8:62fc:2653 with SMTP id bf42-20020a056808192a00b003c862fc2653mr11230215oib.37.1714486622873; Tue, 30 Apr 2024 07:17:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714486622; cv=pass; d=google.com; s=arc-20160816; b=NHzDupOWR6Yqev5aRn+JoEQrikYW5fBPRB8/ewA8LLBmeQ+uHiFgb90TUyC5icYHY+ tZW3D6Q/FR9BneGuT9sPPh1O1tKchs3oPEittCtEQ8cNkdJV5G56/bSm4AebbCN8loEg cqSXuBJ8NNW2/zBwhXFF44txWW7UUT8PE9DNHBNa6udT+BqjH8xHQbOhrij4DJI1tkR0 Tux7A71cEH8e8fZUAN5ntW/xqjL6IwQ6qLn9kqfdoGwIZpk7YYnMOoByTrSEAN/zSVy6 qTX9KemivrtARcwenyYHA2o2Lx/PYCiywwqvyLso7oLWRn77DthqT6pn/Ft2C4+kQ6cm ffKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=91B27U8z7Iln6XJD9uh+fX/pmahLPw16tVNP6LRoyow=; fh=dijFYpEVp+4ijccmXeOrV1fnLJQjsqwgNfcTPuMjuvg=; b=huJqfv/xULJ+eVk7PW/b4aZTDFSubd5zd3Vq1lP9exhH+DSLX/fqUQydSr3SeRcv4J ZWbBaVVa4B5VKXr9nghRYZSJMbb+v3PcO+rXFynwSIOjxEkoJOsFSbHy2h7BCMHgsr1Q KazxVCXCGuJpqwT0DHYe5rhhcsbBAMhvNllX+mJzXx+ANW4S/hDVFwvr4rTuRZzpeaKM n8f+UeZfZSKmLFW04J9vTx7D+Ss2emHitxy4S3DFUWSvzXtuTv7AQx+U9vFWPHbbMJsz kOEJ8bNuAofj4DSmhGDdC4JXjaYlim3Vd0SQUWdWf4Epnfh2oVHn8OVa9I+oApk4mM9i Y0dw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DByRTjAp; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-164085-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164085-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id ec19-20020a056808639300b003c75428bec3si7758040oib.237.2024.04.30.07.17.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 07:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164085-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DByRTjAp; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-164085-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164085-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 02F4E281FB1 for ; Tue, 30 Apr 2024 14:16:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3643C2101A5; Tue, 30 Apr 2024 14:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DByRTjAp" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C871C8FD9 for ; Tue, 30 Apr 2024 14:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714485802; cv=none; b=ayIplEzCLxHLA0c/P3CgqzHTlSMXOwMIUoTjxuyQ//vD0GvWL7mnYzmO0js3QPHHfctwA05dGThKuI1olEZNU49ea3PCdpjbMndkNsK/37Y5s675/cNHzQbhzS+GL8dRjxoGxtSyoutd85kSzlCx44C1+dNO3M8S2TbifHuGY5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714485802; c=relaxed/simple; bh=SlDter0zPHMmOmVkh2bkhZIQPqVPC0ZajmJeQql/VqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fGiCbOpU28BKp1RSAZTUN20K4x4uD9jgOoaorltAJQLHhJl9o1Va6NzRNl8bGYDX9sBAInkZYt8R4n+TkgaEHoU3n5FQfeOmZpLsuqbIAVzXs9j1nWOGnfuoXgFiTkrWZ0oAZQdiOKZQeJzrfvClFI/jtkIAPvzn+w9Vy9WA/gU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DByRTjAp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714485795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=91B27U8z7Iln6XJD9uh+fX/pmahLPw16tVNP6LRoyow=; b=DByRTjApMqpkyJGAgu4RQd66Vk1gSwNWYR7lrZWhbPq5Ggt+eSyP62+7mfn/zf7BtV9LD/ DLGv2o6egkgOuuhwYqrAFrGOwdcXYr8RJdDGL3J/KAOZf1VqvJjOW2W7mMiKTr5A4zEWct R5hqi3HGfKG5JVCYB0o29MFbT639dYc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-259-9eohxlC1NuGqMNpSzIOC4g-1; Tue, 30 Apr 2024 10:03:03 -0400 X-MC-Unique: 9eohxlC1NuGqMNpSzIOC4g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A778F823F1B; Tue, 30 Apr 2024 14:02:36 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7904D1C0F133; Tue, 30 Apr 2024 14:02:33 +0000 (UTC) From: David Howells To: Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet Cc: David Howells , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 21/22] netfs: Miscellaneous tidy ups Date: Tue, 30 Apr 2024 15:00:52 +0100 Message-ID: <20240430140056.261997-22-dhowells@redhat.com> In-Reply-To: <20240430140056.261997-1-dhowells@redhat.com> References: <20240430140056.261997-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Do a couple of miscellaneous tidy ups: (1) Add a qualifier into a file banner comment. (2) Put the writeback folio traces back into alphabetical order. (3) Remove some unused folio traces. Signed-off-by: David Howells Reviewed-by: Jeff Layton cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/netfs/buffered_write.c | 2 +- include/trace/events/netfs.h | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c index 43d2cbcbe75c..d435f39547ef 100644 --- a/fs/netfs/buffered_write.c +++ b/fs/netfs/buffered_write.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/* Network filesystem high-level write support. +/* Network filesystem high-level buffered write support. * * Copyright (C) 2023 Red Hat, Inc. All Rights Reserved. * Written by David Howells (dhowells@redhat.com) diff --git a/include/trace/events/netfs.h b/include/trace/events/netfs.h index e7700172ae7e..4ba553a6d71b 100644 --- a/include/trace/events/netfs.h +++ b/include/trace/events/netfs.h @@ -141,12 +141,9 @@ EM(netfs_folio_trace_cancel_copy, "cancel-copy") \ EM(netfs_folio_trace_clear, "clear") \ EM(netfs_folio_trace_clear_cc, "clear-cc") \ - EM(netfs_folio_trace_clear_s, "clear-s") \ EM(netfs_folio_trace_clear_g, "clear-g") \ - EM(netfs_folio_trace_copy, "copy") \ - EM(netfs_folio_trace_copy_plus, "copy+") \ + EM(netfs_folio_trace_clear_s, "clear-s") \ EM(netfs_folio_trace_copy_to_cache, "mark-copy") \ - EM(netfs_folio_trace_end_copy, "end-copy") \ EM(netfs_folio_trace_filled_gaps, "filled-gaps") \ EM(netfs_folio_trace_kill, "kill") \ EM(netfs_folio_trace_kill_cc, "kill-cc") \ @@ -156,7 +153,6 @@ EM(netfs_folio_trace_mkwrite_plus, "mkwrite+") \ EM(netfs_folio_trace_not_under_wback, "!wback") \ EM(netfs_folio_trace_read_gaps, "read-gaps") \ - EM(netfs_folio_trace_redirty, "redirty") \ EM(netfs_folio_trace_redirtied, "redirtied") \ EM(netfs_folio_trace_store, "store") \ EM(netfs_folio_trace_store_copy, "store-copy") \