Received-SPF: pass (google.com: domain of linux-kernel+bounces-164091-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <49973089-1e5e-48a2-9616-09cf8b8d5a7f@cornelisnetworks.com>
Date: Tue, 30 Apr 2024 10:03:49 -0400
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically
To: Leon Romanovsky <leon@kernel.org>, Breno Leitao <leitao@debian.org>,
 kuba@kernel.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
 "open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
 open list <linux-kernel@vger.kernel.org>,
 linux-netdev <netdev@vger.kernel.org>
References: <20240426085606.1801741-1-leitao@debian.org>
 <20240430125047.GE100414@unreal>
Content-Language: en-US
From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
In-Reply-To: <20240430125047.GE100414@unreal>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RFFVbXkwN3BaNTRXck9Pem5PajNoYkhOWjcxM1BWWHJmU1Mvc3ZFV09naGdC?=
 =?utf-8?B?TzloejlLbldXYkJBVFZGZTRIZXhWaEdidzRzbGIxY1pCUmhHSkdiblFROWF5?=
 =?utf-8?B?UXFrTVBuT1BDQkt3SXFvSGMxRXBMWlRrTjdxZVNUZFlLZWFpQkJJa2NoNVZn?=
 =?utf-8?B?a0dEbjJ2QTZJYjhINE9VMzY0dGFZcDJIZjJ4bEl6VDJiQ0laN3BvR0NOT2Vk?=
 =?utf-8?B?Y0JQL1lrMFA4T05kZFRKalhESGl6aTQrK05zbXN0ZG1nS1RLazd1QzR0L1BR?=
 =?utf-8?B?M0ZXMjFFMEVsT2pBdkVJMWR1dVprMnlVVjFjNHpaeDFGS2t2Uk1TZ2NISU5z?=
 =?utf-8?B?Rmlzd3B6TG5SRnVSSHI2OUsxM3FsYkI1VGVuMGxUbjRnODZnbFhpRWJjZG1q?=
 =?utf-8?B?bXZwV0R0ZERmZFA2bW53OXNvMEc2clpRUE85TmU4UkRpTThrZE5KNnBSaGxZ?=
 =?utf-8?B?Njg0RTRkWUxEV0hhbVZyaW1nOXVoekFTT1ZOb2dITzJ1MUwzWjBsMWtTQlN2?=
 =?utf-8?B?Y3ZUVEl1cEp4SmxtbEk2MjIwcEllVzZ5cFhTK3ZteXROLzFlUloyeDBTd2Vo?=
 =?utf-8?B?cGVid21PcXhtTjZES2pLeTBmbVVGQ2Z3U1FUVjJRZ0NremJJUTBWandjd1FX?=
 =?utf-8?B?ZGx4R2dNSkhvUmZyNHVsUkoyaFJtdGIwVzdLZE9RVG9raWdlR1I0d0dIaTdk?=
 =?utf-8?B?dlFWUzlxejhLSkhNT2EwdXBkbzRJZ1YwZzdNTnh0Qms5Z05DOHozYy9rb1lP?=
 =?utf-8?B?MHAwTnJTYXkxcEhhZE9DZnZLMWlOZ3BBN2pnQ3Vlb1RVc0JQUXFTUjNLb2JU?=
 =?utf-8?B?MFVjTGZteTJ2dnBVR2RqVHc5d3VleVNmYjJzb21CSEh4M0tkTWdmWWt2anR2?=
 =?utf-8?B?c0VZSHUzSVIyZ1RYU0U1NnhHNjUvcXNPLzdNL3R6OTJZTzBiazFtQnlNUVFF?=
 =?utf-8?B?WnZ4UzVrU3hmc3QyVUJ1MC93NHUxVUo3SHUwcVVzam5sK0JXNFFiRTF4OXBp?=
 =?utf-8?B?K1I2Y3FkZEZiUkw2WE04ZnptNTFTMFUrU3JqVU1DbU0raERXRzNEVk45UWFN?=
 =?utf-8?B?NE55bEJCRWtNSGt2aytvNFl2SDdkc1JBTGhSTTRFSGNiK01pYlpjWFBraC8v?=
 =?utf-8?B?R2N6V1VteW9KMitEU0k3VVV5T3A2QVFNVmtjMGF1eXF3L3Z2ejh1UTZqb3l2?=
 =?utf-8?B?YVgzTVhwSVZpTmI5RGFNOXhsc041TTNDZ25zRVNNdHJiRG1qQU9YZEdrWHli?=
 =?utf-8?B?ajBEalhpYUxyUnNheXhwOHlmR2txZTNYSVMrbXVVZWhadlJGMEZlTGR4ZUxz?=
 =?utf-8?B?REhnb0dYc1ZLWStrSGlqMVZwYWNqQmN2WFZlNXlZN05zUVhycFBiNXdIdDBI?=
 =?utf-8?B?cnJhM0E5V0txSU9kY0RXbFVzZGJPM2Q4RVZhRnJjUEszbkdMc0FzZ1NYSDM2?=
 =?utf-8?B?cHU2ZzN6UmV3WjQ5UWtEc1ZYTUVUdW41dmFSeU90RFlxODJnNGlPamJ1cHRv?=
 =?utf-8?B?L3VuYklhOFNNOXVYK21DNnd6MnJ3Z3dqbHNFVHBNMGJ3SUsrdkp2bVYyMWt5?=
 =?utf-8?B?NXFBZG5lNnZVbkZsOE56dlFoL2E1SDdXMnpQaG96cnAxTHA2RU5GdUlrSUpw?=
 =?utf-8?B?a3hVYlFFdWlYM1BnY3p4ZFplMzZ1Wm1oZU5aVXVlYXpuR01tSjhSTWdWeGVN?=
 =?utf-8?B?UEdWbzA3VGduUWZhWkNaNnNJN2ZDalpsL2dITTZ2U3V3S0Z5TVQzZm03Wjd6?=
 =?utf-8?B?QWFUejE0aFNFNUVaMStuQlA2cnN0QnZXTHhhTFJxYkVmVitQeUhaMytrYVRa?=
 =?utf-8?B?SS94cFU4TzhMNTRnY1pMVFNXRSswZEVtL1RvbUhaN0l5OUNVbVp4a29zem5a?=
 =?utf-8?B?eXZoTUU3YmtpeDRZdFpieEpaeHltT2dFSHVTTUppUHFTNk1PQW43ZTRZKy9X?=
 =?utf-8?B?UG9UTkJmRlhBOGwrYUxxQTRrTnFLbmU4dHRlTkdkcG5ZN0FMUVZqVHhhbmho?=
 =?utf-8?B?TnI4R0RXYWQvOWdGRCsybXJRSWV4QWFSdExBTzBPWEFJenpZREtnN0ljZ3F3?=
 =?utf-8?B?bXFsaC9tVnplVjJLK0NjYWxXVmxQTkwvSHB6UXArbXRNd3NnOVJ6M3dUUWts?=
 =?utf-8?B?Q1Z0OXRZbWdhMlBxK3M3QzI1K2NjcHVkSnM3S2ZYOGYvK012NUNoL0FXdnZ6?=
 =?utf-8?Q?BjPGQ3/3lsJnTIkuad+c5Zc=3D?=
X-OriginatorOrg: cornelisnetworks.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8242273-d4b3-410a-d1c5-08dc691e5da0
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB6158.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 14:03:52.2273
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4dbdb7da-74ee-4b45-8747-ef5ce5ebe68a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6p0LdBC8oq2vmoqGsnanD8z2vwAmHfj0ZSuPheVp+eLVpfC22M8zeQ2/AVt46zUAzonDQnpu7QB81zrGM6PdIKAGDetb69t6TEBDTJJr8IMHV1SFMFhQzGkoL7dckM9r
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR01MB7815

On 4/30/24 8:50 AM, Leon Romanovsky wrote:
> On Fri, Apr 26, 2024 at 01:56:05AM -0700, Breno Leitao wrote:
>> Embedding net_device into structures prohibits the usage of flexible
>> arrays in the net_device structure. For more details, see the discussion
>> at [1].
>>
>> Un-embed the net_device from struct hfi1_netdev_rx by converting it
>> into a pointer. Then use the leverage alloc_netdev() to allocate the
>> net_device object at hfi1_alloc_rx().
>>
>> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
>>
>> Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
>> Signed-off-by: Breno Leitao <leitao@debian.org>
>> ---
>> Changelog
>>
>> v5:
>> 	* Basically replaced the old alloc_netdev() by the new helper
>> 	  alloc_netdev_dummy().
>> v4:
>> 	* Fix the changelog format
>> v3:
>> 	* Re-worded the comment, by removing the first paragraph.
>> v2:
>> 	* Free struct hfi1_netdev_rx allocation if alloc_netdev() fails
>> 	* Pass zero as the private size for alloc_netdev().
>> 	* Remove wrong reference for iwl in the comments
>> ---
>>
>>  drivers/infiniband/hw/hfi1/netdev.h    | 2 +-
>>  drivers/infiniband/hw/hfi1/netdev_rx.c | 9 +++++++--
>>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> Dennis,
> 
> Do you plan to send anything to rdma-next which can potentially create
> conflicts with netdev in this cycle?
> 
> If not, it will be safe to apply this patch directly to net-next.
> 
> Thanks

Nothing right now. Should be safe to sent to net-next.

FYI, since I talked about it publicly at the OFA Workshop recently. We will be
starting the upstream of support for our new HW, soon.

-Denny