Received-SPF: pass (google.com: domain of linux-kernel+bounces-164094-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 30 Apr 2024 11:06:00 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 4/6] iommu/arm-smmu-v3: Make __arm_smmu_cmdq_skip_err
 reusable
Message-ID: <20240430140600.GP941030@nvidia.com>
References: <cover.1714451595.git.nicolinc@nvidia.com>
 <25150aec77edf5590bca81f4a418ef1ee7b21952.1714451595.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <25150aec77edf5590bca81f4a418ef1ee7b21952.1714451595.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Ot/r774E8O6OQtcO74+Z1BIAAX3gTcYw7rOjKIkqhaV5sHzwzaoPIowhAc2E?=
 =?us-ascii?Q?sbkpxiz9eFdmLY9IYYENOQFiClxKkmXZBnZ0oJ4cr2hse1lQp+fjtdyCmyo0?=
 =?us-ascii?Q?me7brtZKw2Xz1y0d7IlcKeA0OICEFVXgucx5z2myhn9p5YeYL6ruUUQACn4O?=
 =?us-ascii?Q?3xTojfI+penGC6ib6FbDACg0ntuup5JcXjLRJHLH9lMXnf43oIfY7tgNyc2t?=
 =?us-ascii?Q?W/FPODtCAv4ufIwWaNE0beWJc7mQUoFiG7jb2Mfzsme8vLgS+L8ZCaczAP7+?=
 =?us-ascii?Q?YZqHzaVjWwjBBQcBWbkcr8D87u+x1vMSTPvdyQagKz//BJO8JQtUD92WfINB?=
 =?us-ascii?Q?3vVSgop0thlX46feKcsSm0si9JpRbCaqB6S7ckL+2tRfsLuLcQnMwBo/MXNW?=
 =?us-ascii?Q?JWpY/0XA+x+nEKxvSXUOKBprKMuSe5p7KHxiHK+UGBUbbnwL4QzWSHlXV86o?=
 =?us-ascii?Q?Cuc3a0hx5qD6FpG9eq1bmTfYr65o3anpcvZXNZv7zrRdHyfJ7vcLIqFzn/vV?=
 =?us-ascii?Q?SbOc/W8p5qZyRJROQUSFfqWyjQ/88Oa6O9U9B4ywI/VkPt3habcvMjJujMg+?=
 =?us-ascii?Q?qEHyWnqPC9rOQpknNxif1QqLK3CblIBQFFh5OtNdyXDVhFbm9QlNTgwQI5xQ?=
 =?us-ascii?Q?13AIYLyDwineoT5wM+XVhz36yH0OOzbs6j3VNMjRAavtU5I1hGqFacUu8z/s?=
 =?us-ascii?Q?DOtlTnX0ydj7dyWwLIz5efkm2ffiU42/9NOUwzFjzkYHkHUBbjIt0lJo94wR?=
 =?us-ascii?Q?d9a1Zhpu6Xpf9arxpvmyylWmj9uFO+lblDP9hnR7MCKWzlszpCJ4dvjIC3Ls?=
 =?us-ascii?Q?orTfw1RrRfxcOvkb7BZRrNd09C8SL4xUA2/Hkpaxr+Dk2ObBSEnYbtOdfL0L?=
 =?us-ascii?Q?mwi/wRC1Dk7xOytu+A4daC8OW5Td+k9/MFoF5BclLGHgllfR+O3n340/l9lI?=
 =?us-ascii?Q?vGhE2zrxluzOySHrsE31JQM/dXvZOJGbQ2vQt/Y+pCi9b29pnr3Ffn3I4qnz?=
 =?us-ascii?Q?nl8awNPX8v731eisLYYKdVAqtnLpaZmaeVzjrglPSaJDa59Bg2L7mP40dXpO?=
 =?us-ascii?Q?79pll/4cHZJylHruCgdln/QNvFBIOFxglHxeYt+TC/b8qJM8kyQGOazySdAk?=
 =?us-ascii?Q?iyP+pRcmPIcJxbkehAO2Tl5VF4dJPTAa425g8mS8vJSDhzPdXrrfMELPylgl?=
 =?us-ascii?Q?RHM6iMg4ahFdQaHxt04TMRLdeWe/IHxsXmtJ6HlHaSkR6IkBfX3PL4MuUUVW?=
 =?us-ascii?Q?4DLAqWYage0J5abaHvxSF7RmytnSjttAuuN7KDfABNHR8qMZlreQvkNzzrfd?=
 =?us-ascii?Q?nsHOfK4VPA6YgWDhgGwUuwHrDVq83bguMJm20wlWCpxWaZUuBXI6B5rVFOjr?=
 =?us-ascii?Q?v8ZuIiIH8YwVhLn1Wk9VsU0xIz0q5rqQxL/izI9hRhHFz0OrywcqBb8KcYwh?=
 =?us-ascii?Q?o/aAYIazqx4RwBu1b5pr16IRzdaQvBNufYzL710BnXtu3WtvxFpAfZz/ta5j?=
 =?us-ascii?Q?LP/E2ktQZF9rw2Pgl/vgELecIBEtImyJOkjTdrk7sMQ+LO/vqsXcwkcOlCEK?=
 =?us-ascii?Q?kjIsq98Y+eJgJ7QutLIfjfeAau55/lb4r2UIaYK3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1068d6fb-cc19-4b13-ea4e-08dc691eaaff
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 14:06:01.9990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nr6L7Z/2aqCyGn39CpIdgTIeAKfTjoMKLGRG7NFC4YPjNejxk7cmP16ldxG+oiSH
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7165

On Mon, Apr 29, 2024 at 09:43:47PM -0700, Nicolin Chen wrote:
> Allow __arm_smmu_cmdq_skip_err function to be reused by NVIDIA Tegra241
> CMDQV unit since it will use the same data structure for q. And include
> the CMDQ_QUIRK_SYNC_CS_NONE_ONLY quirk when inserting a CMD_SYNC.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 7 +++++--
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 2 ++
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> index 538850059bdd..5111859347d5 100644
> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c
> @@ -379,8 +379,8 @@ static void arm_smmu_cmdq_build_sync_cmd(u64 *cmd, struct arm_smmu_device *smmu,
>  	arm_smmu_cmdq_build_cmd(cmd, &ent);
>  }
>  
> -static void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu,
> -				     struct arm_smmu_queue *q)
> +void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu,
> +			      struct arm_smmu_queue *q)
>  {
>  	static const char * const cerror_str[] = {
>  		[CMDQ_ERR_CERROR_NONE_IDX]	= "No error",
> @@ -428,6 +428,9 @@ static void __arm_smmu_cmdq_skip_err(struct arm_smmu_device *smmu,
>  	for (i = 0; i < ARRAY_SIZE(cmd); ++i)
>  		dev_err(smmu->dev, "\t0x%016llx\n", (unsigned long long)cmd[i]);
>  
> +	if (q->quirks & CMDQ_QUIRK_SYNC_CS_NONE_ONLY)
> +		cmd_sync.sync.cs_none = true;

This hunk should be in "iommu/arm-smmu-v3: Add CS_NONE quirk" ?

Jason