Received-SPF: pass (google.com: domain of linux-kernel+bounces-164115-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 30 Apr 2024 17:10:39 +0300
From: Leon Romanovsky <leon@kernel.org>
To: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
	Jakub Kicinski <kuba@kernel.org>
Cc: Breno Leitao <leitao@debian.org>, Jason Gunthorpe <jgg@ziepe.ca>,
	"open list:HFI1 DRIVER" <linux-rdma@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] IB/hfi1: allocate dummy net_device dynamically
Message-ID: <20240430141039.GH100414@unreal>
References: <20240426085606.1801741-1-leitao@debian.org>
 <20240430125047.GE100414@unreal>
 <49973089-1e5e-48a2-9616-09cf8b8d5a7f@cornelisnetworks.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <49973089-1e5e-48a2-9616-09cf8b8d5a7f@cornelisnetworks.com>

On Tue, Apr 30, 2024 at 10:03:49AM -0400, Dennis Dalessandro wrote:
> On 4/30/24 8:50 AM, Leon Romanovsky wrote:
> > On Fri, Apr 26, 2024 at 01:56:05AM -0700, Breno Leitao wrote:
> >> Embedding net_device into structures prohibits the usage of flexible
> >> arrays in the net_device structure. For more details, see the discussion
> >> at [1].
> >>
> >> Un-embed the net_device from struct hfi1_netdev_rx by converting it
> >> into a pointer. Then use the leverage alloc_netdev() to allocate the
> >> net_device object at hfi1_alloc_rx().
> >>
> >> [1] https://lore.kernel.org/all/20240229225910.79e224cf@kernel.org/
> >>
> >> Acked-by: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
> >> Signed-off-by: Breno Leitao <leitao@debian.org>
> >> ---
> >> Changelog
> >>
> >> v5:
> >> 	* Basically replaced the old alloc_netdev() by the new helper
> >> 	  alloc_netdev_dummy().
> >> v4:
> >> 	* Fix the changelog format
> >> v3:
> >> 	* Re-worded the comment, by removing the first paragraph.
> >> v2:
> >> 	* Free struct hfi1_netdev_rx allocation if alloc_netdev() fails
> >> 	* Pass zero as the private size for alloc_netdev().
> >> 	* Remove wrong reference for iwl in the comments
> >> ---
> >>
> >>  drivers/infiniband/hw/hfi1/netdev.h    | 2 +-
> >>  drivers/infiniband/hw/hfi1/netdev_rx.c | 9 +++++++--
> >>  2 files changed, 8 insertions(+), 3 deletions(-)
> > 
> > Dennis,
> > 
> > Do you plan to send anything to rdma-next which can potentially create
> > conflicts with netdev in this cycle?
> > 
> > If not, it will be safe to apply this patch directly to net-next.
> > 
> > Thanks
> 
> Nothing right now. Should be safe to sent to net-next.

Jakub, can you please take this patch?

> 
> FYI, since I talked about it publicly at the OFA Workshop recently. We will be
> starting the upstream of support for our new HW, soon.

Great, thanks

> 
> -Denny