Received-SPF: pass (google.com: domain of linux-kernel+bounces-164131-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 30 Apr 2024 11:24:08 -0300
From: Jason Gunthorpe <jgg@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org,
	thierry.reding@gmail.com, vdumpa@nvidia.com, jonathanh@nvidia.com,
	linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH v6 3/6] iommu/arm-smmu-v3: Make arm_smmu_cmdq_init
 reusable
Message-ID: <20240430142408.GR941030@nvidia.com>
References: <cover.1714451595.git.nicolinc@nvidia.com>
 <47a2ec844ec42694872d3c3b1a09f1b870712f78.1714451595.git.nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47a2ec844ec42694872d3c3b1a09f1b870712f78.1714451595.git.nicolinc@nvidia.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/U/FhejZM/e8VW260Yd5rTmxPeNfggGGqHltVx2EwyFXivSpEwt9TRcAi9z0?=
 =?us-ascii?Q?EAS747uEgCQVwTa/w1MqQ4VN2NVTe6nKsXe9cEZB0qrvIkIrx/ZHbQ6n4Zkr?=
 =?us-ascii?Q?MM3Vz/Jr8rf+yeHmlZ/CIHLp5t2o4GiEO/6KPaivZo2/P3bIIALEEOUBOOHN?=
 =?us-ascii?Q?O1ZxyJUp3fib/6T5khX7rMWqVWk9IwTLv8zJexkgr1ImdmYwiXin6grXXNe0?=
 =?us-ascii?Q?lxctHEfe0D11ZfLdAKGtM1jD82SVBVwtBUdx5zXh5WxfggJIJ8emYkO48gPN?=
 =?us-ascii?Q?NAMTKaZsH2X0iXlO7iSJc3kIs9MUTLfiIQ8pVyIe76u0IZ6cLezel4sAUvxu?=
 =?us-ascii?Q?ZPlrtOU1uUaq+iYIDcGyPK+Ea+trnywnUNBRrVqZgjvzqeNiSdVPvEJ9KKRg?=
 =?us-ascii?Q?QxswrFQoShFZDA44Kwoe9MttfEXBdzn9S5JrJ4W1HBa+1oA7chNh83x/ZJJ6?=
 =?us-ascii?Q?qPhlrRMZP3ypvZVUh3nuQqmXhMbMUCN03AUIlit7O3NAssMNd/6g5nohOiLD?=
 =?us-ascii?Q?xq4seOdBLgx1rKMabu8f5AD7JLvX0lleVzHJaNgTwyqhyQ/r91S/azVjjJuq?=
 =?us-ascii?Q?9gmmVpr2OuJqJir7bIwLs/lvMBUiIkL/kxlFQxV/bAFGQclow956IBxw7c+L?=
 =?us-ascii?Q?vRpqwkIalNPkriZ4LyIcPeNj6jVzn0t1Y+Hm/7LW29dYs6JR6nD4Mp15cGRn?=
 =?us-ascii?Q?fpQ3PG8jShZRF0isTMJ5ZGJXmqTtJZK94ZSw+MWSu+Nt/ZkpvUSu3MYVlUdu?=
 =?us-ascii?Q?EUu+NhGA/NNnhAFfmRTF2Bzt4eKjQm+6MPWjrvJUkTqgiDICVwBJGN4Zho83?=
 =?us-ascii?Q?KhCemMhhBOudmMSJxz/o5DXMpZzDvT7BkC6CMOU5dXT24goeZ5oMZeffaySz?=
 =?us-ascii?Q?4FRT4V6WFLpZI09SCZ7oJTGZXrQdyYOAOmguaAS/40MkN+47q76+Z5NGuLnX?=
 =?us-ascii?Q?wdcXBdWAzR1qcvBekj7Jhazu25X0iZ2Gsq2nMsw9cn60wCmprx1d1sa3OF6R?=
 =?us-ascii?Q?MUtDW9TW51OMbzcP3wQuwKV8J0R0HoVg5xdUvuAi/gtyGWblS1RRSAfULZWn?=
 =?us-ascii?Q?+n9xSdE26Xvw55h1fRANo+DkT0PSno3h1EQolUp8gHaJdK7KlqLx4F7ZpuDa?=
 =?us-ascii?Q?MqPG3aQT5qfTYL66xxRnVGA7YlE00MDaf9/uJrfagXA7XqHdu5uFzRxWWqRe?=
 =?us-ascii?Q?+QmCMT1GD6qRPjrJRgWKZ5u84c81zYCDoGESirk3f4AcyUfgIea4jss66ajj?=
 =?us-ascii?Q?W56d4yZE/UOm+s7rsFBIUvUDvAk+1FW75w8SNvTDvA6bMJu/j3n26sm6SDiY?=
 =?us-ascii?Q?y/awqvg7LL6uK0K5m4lDOIimDhhy5JHmc51sMNUiiQ9UVIeoeZY6K8r/Uuk+?=
 =?us-ascii?Q?AWjCD/dF23oH9jb9OIfi8GNf1gNuHuKwn6bTn4CeUhr1EwsZ2tyLkvytRueV?=
 =?us-ascii?Q?j402gcSnxa4j2asxe+SKA5EtJFYdmieM3YKk4QbbS0uW6taWextYATUx7GCg?=
 =?us-ascii?Q?aIbZj8c8p2FWLkmZ+nxFOXnzhf66zhtbJSHWSSj/LIDSn3+9sJJfxy9q7/X6?=
 =?us-ascii?Q?dgjGJ7VaPCj7+UqtQgUqrbegFSbIb5j0wurKM0qT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66b57e2a-a8ce-4b07-1e72-08dc6921341a
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 14:24:10.9864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JuEL8XiIL3LtTtq5p14MGqzWdGj4clQFMxPCNtgQO49CcBjqOGiZ7Mza2sJolzDS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7690

On Mon, Apr 29, 2024 at 09:43:46PM -0700, Nicolin Chen wrote:
> The CMDQV extension in NVIDIA Tegra241 SoC resues the arm_smmu_cmdq
> structure while the queue location isn't same as smmu->cmdq.
> 
> Add a cmdq argument to arm_smmu_cmdq_init() function and shares its
> define in the header for CMDQV driver to use.
> 
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 6 +++---
>  drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 3 +++
>  2 files changed, 6 insertions(+), 3 deletions(-)

I would squash this patch and the next together:

iommu/arm-smm-v3: Make symbols public

The symbols arm_smmu_cmdq_init() and __arm_smmu_cmdq_skip_err() need
to be used by the tegra241-cmdqv.c compilation unit in the next
patch. Remove the static and put prototypes in the header.

But the code is fine

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason