Received-SPF: pass (google.com: domain of linux-kernel+bounces-164154-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240428142937.785925-1-peteryin.openbmc@gmail.com>
 <20240428142937.785925-2-peteryin.openbmc@gmail.com> <d231737bfa9f3dd3c0a4370ab2e86557a407980d.camel@codeconstruct.com.au>
 <CAPSyxFRG8mooBg1QWZk8sw=cWzoUQqk=WnyAtgPfRBmQRKtvaQ@mail.gmail.com> <e694ba58197687dce68d568dfcb078ff3a6c6fed.camel@codeconstruct.com.au>
In-Reply-To: <e694ba58197687dce68d568dfcb078ff3a6c6fed.camel@codeconstruct.com.au>
From: Peter Yin <peteryin.openbmc@gmail.com>
Date: Tue, 30 Apr 2024 22:30:43 +0800
Message-ID: <CAPSyxFSVkyKQ2xvg92xqpkL=0WYqt+rP_+TjcM19mEMtu4FPng@mail.gmail.com>
Subject: Re: [PATCH v8 1/1] drivers: watchdog: revise watchdog bootstatus
To: Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: patrick@stwcx.xyz, Wim Van Sebroeck <wim@linux-watchdog.org>, 
	Guenter Roeck <linux@roeck-us.net>, Joel Stanley <joel@jms.id.au>, linux-watchdog@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Andrew,
  Thanks, I am going to fix it in V9.

On Tue, Apr 30, 2024 at 9:38=E2=80=AFAM Andrew Jeffery
<andrew@codeconstruct.com.au> wrote:
>
> On Mon, 2024-04-29 at 22:54 +0800, Peter Yin wrote:
> > Hi Andrew,
> >     I am not sure how to add the Fixes tag, Is it like this?
> >
> > Fixes: 6a6c7b006e5c (watchdog: aspeed: Add support for
> > aspeed,reset-mask DT property).
>
> Approximately, yes, but it must not be wrapped.
>
> Some more info is provided in the submitting-patches documentation:
>
> https://docs.kernel.org/process/submitting-patches.html#describe-your-cha=
nges
>
> > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com>
> >
> > Is it the correct commit ID or should I base on which commit ID?
> >
>
> The correct commit ID to use is the one that introduces the problem.
> Using `git blame drivers/watchdog/aspeed_wdt.c` it appears you're
> changing the behaviour that was introduced in 49d4d277ca54 ("aspeed:
> watchdog: Set bootstatus during probe"):
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/?id=3D49d4d277ca54e04170d39484c8758a0ea9bca37d
>
> Andrew