Received-SPF: pass (google.com: domain of linux-kernel+bounces-164172-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 30 Apr 2024 16:33:16 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Herman van Hazendonk <github.com@herrie.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Ben Wolsieffer <benwolsieffer@gmail.com>, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] power: supply: max8903: configure USUS as output
Message-ID: <ujpdv6fahceaatniy3w4z23dy7q4r5swfqzi2mc4dlarcdavo4@x5fvm5oklohx>
References: <20240417-max8903-v1-1-25d4dbf4ce9b@herrie.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="243jbcowuncudllz"
Content-Disposition: inline
In-Reply-To: <20240417-max8903-v1-1-25d4dbf4ce9b@herrie.org>


--243jbcowuncudllz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Apr 17, 2024 at 03:35:00PM +0200, Herman van Hazendonk wrote:
> The USUS pin was mistakenly configured as an input, when it should be an
> output that specifies whether the USB power input is suspended. In additi=
on
> to fixing the pin mode, this patch also suspends the USB input when a DC
> charger is connected, which should result in a slight reduction in USB
> quiescent current.
>=20
> Signed-off-by: Ben Wolsieffer <benwolsieffer@gmail.com>
> Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
> ---

Thanks for your patch. I think this should get

Fixes: 50da8d04ee52 ("power: supply: max8903: Convert to GPIO descriptors")

Also what's going on with the Signed-off-by? Did you forward the
patch from Ben Wolsieffer (i.e. the author is wrong) or did you
co-develop it (so there should be a "Co-developed-by: Ben Wolsieffer
<benwolsieffer@gmail.com>" tag)?

>  drivers/power/supply/max8903_charger.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/power/supply/max8903_charger.c b/drivers/power/suppl=
y/max8903_charger.c
> index e65d0141f260..15dc3a5239e2 100644
> --- a/drivers/power/supply/max8903_charger.c
> +++ b/drivers/power/supply/max8903_charger.c
> @@ -102,6 +102,10 @@ static irqreturn_t max8903_dcin(int irq, void *_data)
>  	if (data->dcm)
>  		gpiod_set_value(data->dcm, ta_in);
> =20
> +	/* Set USB-Suspend 1:Suspended 0:Active */
> +	if (data->usus)
> +		gpiod_set_value(data->usus, ta_in);
> +
>  	/* Charger Enable / Disable */
>  	if (data->cen) {
>  		int val;
> @@ -310,7 +314,15 @@ static int max8903_setup_gpios(struct platform_devic=
e *pdev)
>  				     "failed to get FLT GPIO");
>  	gpiod_set_consumer_name(data->flt, data->psy_desc.name);
> =20
> -	data->usus =3D devm_gpiod_get_optional(dev, "usus", GPIOD_IN);
> +	/*
> +	 * Suspend the USB input if the DC charger is connected.
> +	 *
> +	 * The USUS line should be marked GPIO_ACTIVE_HIGH in the
> +	 * device tree. Driving it low will enable the USB charger
> +	 * input.

I think the above 3 lines should be dropped. They added more
confusion to me than actually helping and the information is
already in the DT binding file.

Greetings,

-- Sebastian

> +	 */
> +	flags =3D ta_in ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
> +	data->usus =3D devm_gpiod_get_optional(dev, "usus", flags);
>  	if (IS_ERR(data->usus))
>  		return dev_err_probe(dev, PTR_ERR(data->usus),
>  				     "failed to get USUS GPIO");
>=20
> ---
> base-commit: 96fca68c4fbf77a8185eb10f7557e23352732ea2
> change-id: 20240417-max8903-ace97d7d3407
>=20
> Best regards,
> --=20
> Herman van Hazendonk <github.com@herrie.org>
>=20

--243jbcowuncudllz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYxASAACgkQ2O7X88g7
+po8UxAAp2+KFGesRHzAkUVrYxiu1Exye2LwzJjQdFD69x3N1cchUiGVaebshxIU
73MwfOssQndZMS/ice/Ed71XJTtb93EA7MtuHkQQ8MEelEoC5T4N0VER+S1q/Irb
FXHteDS4WDm7pYd6Pf9XQW7eI/WrhqQ2vJMn9BjbQrh79J6XT9GdLCF5XrNgcDdL
nGUZIlCtnE+xce8Q4vpPZ5t3LNqFrkJTMWBOGFZtl1hOaaPqHS3cuJ40mangaZ3u
EGBL3yck5fJVFiUz8e1zibFrDow00j6zXI/7aU6c4sFGadTPea2QmCCPUO0gRMSt
9vTruWzmidtXIIOckrhfcGAlNmN54NFPrl6wibmOdINJ/a/AMixZg3qi33TKHYp5
xNYxc2KEbw9kELlqABBHVw7fdulS+YCVh+iC8iYmNH3SeoKKAStFlUhgog0Ba4JE
ZaWkFxcnIBjmJoAkVZDEAJLigV0xaKDJfECal/EXqREBvtfmX9Y8FLJqXSBdLax2
7QpvmzabW9CRqEGTTBUHinJT4LMuaNuDPdjOlYj0BCALs7is59dVxG4Nc2sCmWL6
2lHWBssg/IOBFp8OqnOsjEe3aq2fBASE2urGreXFpRCMaBVV5vHXm4xLrUQZ9NF+
ypqvN/8GcuGc7B7SnjFAXLeZTMFuNhrrU8/DOlF3g9qsDEd7iZg=
=VF7a
-----END PGP SIGNATURE-----

--243jbcowuncudllz--