Received-SPF: pass (google.com: domain of linux-kernel+bounces-164198-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <3283ce46-86d8-ff87-440e-ee9811c9e77a@loongson.cn>
Date: Tue, 30 Apr 2024 22:49:46 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.0
Subject: Re: [PATCH] firmware: dmi: Change size of dmi_ids_string[] to 256
Content-Language: en-US
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-kernel@vger.kernel.org
References: <1677030901-29326-1-git-send-email-yangtiezhu@loongson.cn>
 <20240429144442.472aa83c@endymion.delvare>
From: Tiezhu Yang <yangtiezhu@loongson.cn>
In-Reply-To: <20240429144442.472aa83c@endymion.delvare>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 4/29/24 20:44, Jean Delvare wrote:
> Hi Tiezhu,
> 
> Sorry for the very late answer, somehow your messages slipped through
> the cracks.

It does not matter, thank you very much for your reply.

> 
> On Wed, 22 Feb 2023 09:55:01 +0800, Tiezhu Yang wrote:
>> The current size of dmi_ids_string[] is 128, the BIOS date
>> can not be seen if the total string length of system vendor,
>> product name, board name, BIOS version and BIOS date is too
>> long to over 128, it is better and enough to change size of
>> dmi_ids_string[] to 256 for most cases.
> 
> In order to convince me that the size of this buffer needs to be
> increased, one would have to provide a real world example with valid
> DMI data where the output doesn't fit. However...
> 
>> Without this patch:
>>
>> [    0.000000] DMI: Loongson Loongson-3A5000-7A1000-1w-A2101/Loongson-LS3A5000-7A1000-1w-A2101, BIOS vUDK2018-LoongArch-V4.0.05132-beta10 12/13/202
>>
>> With this patch:
>>
>> [    0.000000] DMI: Loongson Loongson-3A5000-7A1000-1w-A2101/Loongson-LS3A5000-7A1000-1w-A2101, BIOS vUDK2018-LoongArch-V4.0.05132-beta10 12/13/2022
> 
> This example is apparently taken from an engineering sample with rather
> "low quality" strings or invalid string indexes. Specifically:
> * The product name and the board name are the exact same string.
> * Both duplicate the system vendor name ("Loongson").
> * The BIOS version includes the architecture name "LoongArch", which
>    seems unnecessarily verbose.
> 
> So my feeling is that the issue would be better addressed by fixing the
> DMI data of your board than increasing the buffer size.

I agree with you.

> 
> Do you have any production-grade DMI table with proper strings where
> the buffer is still not large enough?

Not yet.

I did not find the string length of system vendor, product name,
board name, BIOS version and BIOS date in the spec, I only see
"There is no limit on the length of each individual text string."
in "6.1.3 Text strings", so it may be better to increase the size
to avoid the potential problems in theory at least.

https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.7.0.pdf

Thanks,
Tiezhu