Received-SPF: pass (google.com: domain of linux-kernel+bounces-164207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 30 Apr 2024 23:56:46 +0900
From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: use inline function for type safety in
 snd_soc_substream_to_rtd()
Message-ID: <ZjEGrnlQfFeDyLUc@finisterre.sirena.org.uk>
References: <20240430140938.328088-1-krzysztof.kozlowski@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8pV+PWcSobNbNF3R"
Content-Disposition: inline
In-Reply-To: <20240430140938.328088-1-krzysztof.kozlowski@linaro.org>


--8pV+PWcSobNbNF3R
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Apr 30, 2024 at 04:09:38PM +0200, Krzysztof Kozlowski wrote:

> -#define snd_soc_substream_to_rtd(substream) \
> -	(struct snd_soc_pcm_runtime *)snd_pcm_substream_chip(substream)
> +
> +static inline struct snd_soc_pcm_runtime *
> +snd_soc_substream_to_rtd(const struct snd_pcm_substream *substream)
> +{
> +	return substream->private_data;
> +}

This is not an obvious direct substitution, we've skipped the
snd_pcm_subsystem_chip() (which is also a macro, but that just suggests
it could do with it's own cleanup) and the commit log didn't mention it.

--8pV+PWcSobNbNF3R
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYxBq4ACgkQJNaLcl1U
h9Ca7gf/T8ZFoUJmdU+447+36hbeeKvmRjKe/W64VoRyOxKcdgIc4vr9a3P+jkFO
XDOo4DRaC4ODF3piEsAJpT1SiNUxBIOzTD3+t7uv4O0QRQ90SxTPVQLb4dxIRqiP
3QCsgePEYGspRHxlUJkMwPuq/i6bdjX6KiT2jX9MVmLAEfYLzfrc4cjlZtrtmjPS
Nzikju+66l21nQXBFToT4npXQxS9balCz9ruOM+iwSwcKC2trEyYJVnjK1tS6Uhd
6j8JdCPmItOu4ERgVSmBQCuKzjKtJyj1ie7k8alpPzBjbXM5my6/W9uWr81GOhaz
Vq6V0tNBMk2Nose52DHSpiVUIjAPqg==
=pItM
-----END PGP SIGNATURE-----

--8pV+PWcSobNbNF3R--