Received-SPF: pass (google.com: domain of linux-kernel+bounces-164200-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 30 Apr 2024 16:51:42 +0200
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Conor Dooley <conor@kernel.org>
Cc: Herman van Hazendonk <github.com@herrie.org>, benwolsieffer@gmail.com, 
	chris.chapuis@gmail.com, Rob Herring <robh@kernel.org>, 
	Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>, linux-pm@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: max8903: specify
 flt-gpios as input
Message-ID: <n7mahydeipds3zwynt73gpfrujsu54yo7xwztesqrxem7eumqk@7wa6nhm6iyfc>
References: <20240415151645.1986014-1-github.com@herrie.org>
 <20240415-pretty-recite-127842ed9a10@spud>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kbkpobocfrmnoio4"
Content-Disposition: inline
In-Reply-To: <20240415-pretty-recite-127842ed9a10@spud>


--kbkpobocfrmnoio4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Apr 15, 2024 at 05:28:22PM +0100, Conor Dooley wrote:
> On Mon, Apr 15, 2024 at 05:16:45PM +0200, Herman van Hazendonk wrote:
> > The FLT pin was incorrected documented as an output. The MAX8903 uses i=
t to
> > signal to the processor that a charging fault has occurred.
>=20
> I guess this is just a matter of framing? Input to the hardware running
> the OS but an output from the max8903?
>=20
> I'm okay with whatever wording causing less confusion, which may mean
> something that specifics what this is relative to?

well, this definitely improves things, since the other GPIOs
=66rom the same file are all described with the hardware running
the OS being the reference. So this makes things at least
uniform.

> >=20
> > Signed-off-by: Herman van Hazendonk <github.com@herrie.org>
>=20
> The SoB email should match the from email fyi.

It does for this patch, so I took it.

Greetings,

-- Sebastian

> Cheers,
> Conor.
>=20
> > ---
> >  .../devicetree/bindings/power/supply/maxim,max8903.yaml         | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max89=
03.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > index a8d625f285f1..86af38378999 100644
> > --- a/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max8903.yaml
> > @@ -34,7 +34,7 @@ properties:
> > =20
> >    flt-gpios:
> >      maxItems: 1
> > -    description: Fault pin (active low, output)
> > +    description: Fault pin (active low, input)
> > =20
> >    dcm-gpios:
> >      maxItems: 1


--kbkpobocfrmnoio4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYxBXkACgkQ2O7X88g7
+przphAAmaIqDY/WTyoDrG4eVz+4nPwkoXsmLn5DcsIDmsxgNosLseuOK0xOP35a
FyUdDJ9M7gaEMBtfDUdaByTH6hyluAFh3ke5ty8xFKz2PkTXXbnWwApkr3tNWdvB
b9ZwUrrf+8KnJGkZ1WI9vCUIkI6ZKD6++4QIquf2TCBTo8cII1V3czpFw/6yze5O
NJRqK3FOnNLpNqxmJPiohSF0kgQo0gS1qLx2E7lEaxYPMgA9W3OAEQ1gyUOgrgvV
IA0XCvy4diimF9dnkxSHVNU1mxEamisSzPNaV3EPAUEbgVvGNwbmnDnYNrYaRN8Y
Gr+YjQm33HomVAi6oSNr4qx5S2wH52ukCZ2adUdx7tG3vWsl/uMfXYGIKQo+5/Hu
7yQq144WSD4tDv/63yrc9lBQAx8BWvrDjY2iqHworUY+Jqp+57k7teXiCbmhlKCp
bNF6PN//mcdQRjc3JTqavWftaqMOqaGF/WewCu4Ea6a2nWcCY4CDdY5hgVceRVF6
2f0B1qzuMxTpB8X1LQpqXzn6UJZyNlIwDxgh9mXZFXWeA2KjtSOcKS5Z7ilH8iSw
f/BUFqdDXPyWNazhcdvATxLACqftxybTnb6kAYLY1xETjikCQmqfbtQIV6jUKFXm
uaehvHjIFWHiOlED4XKK9s+ymuJVcbidKzpHK8Jpq+lPJItsqPk=
=82dK
-----END PGP SIGNATURE-----

--kbkpobocfrmnoio4--