Received-SPF: pass (google.com: domain of linux-kernel+bounces-164155-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-416-g2c1796742e-fm-20240424.001-g2c179674
Precedence: bulk
MIME-Version: 1.0
Message-Id: <99ef1ba3-155f-47e8-b1a4-e46cb056cbfd@app.fastmail.com>
In-Reply-To: <20240430141609.2244416-1-hca@linux.ibm.com>
References: 
 <CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com>
 <20240430141609.2244416-1-hca@linux.ibm.com>
Date: Tue, 30 Apr 2024 16:30:37 +0200
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Heiko Carstens" <hca@linux.ibm.com>, linux-s390@vger.kernel.org,
 "open list" <linux-kernel@vger.kernel.org>,
 linux-clk <linux-clk@vger.kernel.org>, lkft-triage@lists.linaro.org,
 "Linux Regressions" <regressions@lists.linux.dev>, imx@lists.linux.dev,
 "Abel Vesa" <abelvesa@kernel.org>, "Abel Vesa" <abel.vesa@linaro.org>,
 "Naresh Kamboju" <naresh.kamboju@linaro.org>
Cc: "Shengjiu Wang" <shengjiu.wang@nxp.com>,
 "Shawn Guo" <shawnguo@kernel.org>,
 "Michael Turquette" <mturquette@baylibre.com>,
 "Dan Carpenter" <dan.carpenter@linaro.org>,
 "Anders Roxell" <anders.roxell@linaro.org>, "Peng Fan" <peng.fan@nxp.com>
Subject: Re: [PATCH] clk: imx: imx8mp: Add missing CONFIG_PM ifdefs
Content-Type: text/plain

On Tue, Apr 30, 2024, at 16:16, Heiko Carstens wrote:
> Add missing CONFIG_PM ifdefs to fix this allmodconfig compile error:
>
> drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error:
> 'clk_imx8mp_audiomix_runtime_suspend' defined but not used
> [-Werror=unused-function]
>   356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev)
>       |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> Closes: 
> https://lore.kernel.org/r/CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@mail.gmail.com
> Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for 
> power saving")
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Thanks for your patch. I see the bug as well, but
I think a better fix is to replace the deprecated
SET_RUNTIME_PM_OPS() and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS()
with the modern variants, RUNTIME_PM_OPS() and
RUNTIME_PM_OPS().

      Arnd