Received-SPF: pass (google.com: domain of linux-kernel+bounces-164224-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Zi Yan <ziy@nvidia.com>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>,
 Mark Rutland <mark.rutland@arm.com>,
 Anshuman Khandual <anshuman.khandual@arm.com>,
 Andrew Morton <akpm@linux-foundation.org>, Zi Yan <zi.yan@cs.rutgers.edu>,
 "Aneesh Kumar K.V" <aneesh.kumar@kernel.org>,
 linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
 linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] arm64/mm: pmd_mkinvalid() must handle swap pmds
Date: Tue, 30 Apr 2024 11:00:22 -0400
Message-ID: <32048DBA-EBDA-41DD-A688-8389903DA0EA@nvidia.com>
In-Reply-To: <20240430133138.732088-1-ryan.roberts@arm.com>
References: <20240430133138.732088-1-ryan.roberts@arm.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_D4EB5EDB-B3B5-4372-A6AA-1E40E32999F4_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?/nQYeX2cnObX7uLpd32boQoeX1Q08QEcE8YGCNb9wsgzhjO8FuhW2TKg4Zz+?=
 =?us-ascii?Q?53y9ts2xoCWWxAyWWuRhSPIVlOK/5CpVpr+boNoqTqQ8C8MlhW09HczA4Ivn?=
 =?us-ascii?Q?Zep9L9MDowXzV2jGLtp91QVe3Fs3AmCWZMhnZUys+j6yoNpINCTZXMR43Trd?=
 =?us-ascii?Q?QLyvO9L0kHefMWkQQ9ronURe4TN8hlOpW0SMAd/Fvft8iyJgm4uqMfNb/Q2g?=
 =?us-ascii?Q?z0tBgAkl9FfKg4R4hUxXvwatmy1hoV9krhtguavQnGomIBr63FZ3HxvG3KZs?=
 =?us-ascii?Q?AXF1lqFpMD4mpS1VMfpBt9h5j/nmCWX71VdbQmY1CXuf9wxfHePE+/RMOM6D?=
 =?us-ascii?Q?fnz/lqpjHQxLJKLIfHnx/dvnRidHu1QaUs1pM9z47i1e5mC0bGOj0wCGPk7W?=
 =?us-ascii?Q?u8NPTyvjLlCR6BRLFi9CUhM64fQw04muEmOE2QWa4fFdM92IWPQxjmOQ2Jg9?=
 =?us-ascii?Q?1m53OSa+72P6TizMz2rpc2g7mAda409mBwQu9vQAfR7Ok1RJye5P9azlJSd9?=
 =?us-ascii?Q?ZeBtyOKEEtbooJvUTVoJNLatCRoE/mgbXSbtPaWNyyIG2KeO5VKPSdsUKgpc?=
 =?us-ascii?Q?0VXO9rnjhZCHnLiLr3/X7WdNpDVT9eAbRdO53zTmVdbpZJHfRSWW0dI7zyMs?=
 =?us-ascii?Q?vfpRClSOs4969GEflLNUsD8nloquZShDo5GUjKVEJ0rNEQnn+k4hHXgZPvyC?=
 =?us-ascii?Q?FOsjZn8KmScyZYrUvHpHz3vDYbbJZAL+Z1tFKO0nt+inXyt/dwMZ6ZEEAvux?=
 =?us-ascii?Q?amf93kYBFB0V31d0tXhGh4bYf0kpzx32MwTnEZs5XuT1DlBQvMPA3fENuoq1?=
 =?us-ascii?Q?3c7VuBMqwA+1JASPeSjcd7lYcWdoJoPr1MKGgl5ocCOX4QtncgR5oYbWxWIF?=
 =?us-ascii?Q?vTBSFmRaPg7/vuajHOEJFWCMfnBy2yVS1MN6YPULhAaSQixj5Jm+yFXk9g1h?=
 =?us-ascii?Q?jIRpJCdBMooFy6hAufhDPO6J/rVBTTaGUTEusuQskXvUt/kCEZu1xK0bdrtj?=
 =?us-ascii?Q?fstTb4efRC5acHgb/fgVtVAoxAwIBeSGuDxH9sm/Y84uX7dfbuyynFOSs/8D?=
 =?us-ascii?Q?QtKbDBQQ1Y6/VfCLgUxig2GomD7OB1awZAeJ5UzMu8T5UCRTNK6KSqVIor4Z?=
 =?us-ascii?Q?AlkNv2b16Y9O0sk4iVO9mCgOuaAXduYst8/f+ml2s4oSjplAcYPEXt/pEOmD?=
 =?us-ascii?Q?CF2MvDMmZ6aXaOgC6uxm5uRttI5VKQubTvfm75PVVVsHv/ELiR9F8H8RKWh1?=
 =?us-ascii?Q?e4+wzWM4QCbjA45pX5EFk+KpeCVEOrH5B1DLi4hNJlaWdlHG/kob6mPks4gQ?=
 =?us-ascii?Q?0HR9LgHL9GU4YFq4Gn1/zxIApNrQWvE4d3fwjLD423wzG6/uEDQJnGWDvyl+?=
 =?us-ascii?Q?Uypd4R9sBDhTMiGTOvsr0hqDRUZ9uH39zJtpg/sS3jb5wj95B2sAdD13vP03?=
 =?us-ascii?Q?9KFTsym4/wfECnUi37CUrjbMdXPPVGnl+VB24UW4ih5Nm5qBp71wDcYGtY4S?=
 =?us-ascii?Q?ROcsaRBgatJjoxolJkUeqsH+sdDRMxBRMrlBiciiozWhgilYLmcR88t1Gl6j?=
 =?us-ascii?Q?UA4NZ8YMtsGbME0IS85fE/KjHMyRjyVVQk7gEYnv?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 408500dc-3fa2-45d5-95c6-08dc69264418
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 15:00:25.3725
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4cjTvzjDWqnVNSgjrrrGs+Wot4NYiWn8dFzDs5Th47PgQDV6hHujAv9Q7XtHlO1e
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7191

--=_MailMate_D4EB5EDB-B3B5-4372-A6AA-1E40E32999F4_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On 30 Apr 2024, at 9:31, Ryan Roberts wrote:

> __split_huge_pmd_locked() can be called for a present THP, devmap or
> (non-present) migration entry. It calls pmdp_invalidate()
> unconditionally on the pmdp and only determines if it is present or not=

> based on the returned old pmd.
>
> But arm64's pmd_mkinvalid(), called by pmdp_invalidate(),
> unconditionally sets the PMD_PRESENT_INVALID flag, which causes future
> pmd_present() calls to return true - even for a swap pmd. Therefore any=

> lockless pgtable walker could see the migration entry pmd in this state=

> and start interpretting the fields (e.g. pmd_pfn()) as if it were
> present, leading to BadThings (TM). GUP-fast appears to be one such
> lockless pgtable walker.
>
> While the obvious fix is for core-mm to avoid such calls for non-presen=
t
> pmds (pmdp_invalidate() will also issue TLBI which is not necessary for=

> this case either), all other arches that implement pmd_mkinvalid() do i=
t
> in such a way that it is robust to being called with a non-present pmd.=

> So it is simpler and safer to make arm64 robust too. This approach mean=
s
> we can even add tests to debug_vm_pgtable.c to validate the required
> behaviour.
>
> This is a theoretical bug found during code review. I don't have any
> test case to trigger it in practice.
>
> Cc: stable@vger.kernel.org
> Fixes: 53fa117bb33c ("arm64/mm: Enable THP migration")
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
> ---
>
> Hi all,
>
> v1 of this fix [1] took the approach of fixing core-mm to never call
> pmdp_invalidate() on a non-present pmd. But Zi Yan highlighted that onl=
y arm64
> suffers this problem; all other arches are robust. So his suggestion wa=
s to
> instead make arm64 robust in the same way and add tests to validate it.=
 Despite
> my stated reservations in the context of the v1 discussion, having thou=
ght on it
> for a bit, I now agree with Zi Yan. Hence this post.
>
> Andrew has v1 in mm-unstable at the moment, so probably the best thing =
to do is
> remove it from there and have this go in through the arm64 tree? Assumi=
ng there
> is agreement that this approach is right one.
>
> This applies on top of v6.9-rc5. Passes all the mm selftests on arm64.
>
> [1] https://lore.kernel.org/linux-mm/20240425170704.3379492-1-ryan.robe=
rts@arm.com/
>
> Thanks,
> Ryan
>
>
>  arch/arm64/include/asm/pgtable.h | 12 +++++--
>  mm/debug_vm_pgtable.c            | 61 ++++++++++++++++++++++++++++++++=

>  2 files changed, 71 insertions(+), 2 deletions(-)
>
LGTM. Thanks. Feel free to add Reviewed-by: Zi Yan <ziy@nvidia.com>.

--
Best Regards,
Yan, Zi

--=_MailMate_D4EB5EDB-B3B5-4372-A6AA-1E40E32999F4_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYxB4YPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUX6wP/RiN1STcOZKXdHM57ttW0ZL/Y05QJai6BiO+
mGZ4HZ33Lc2tzulZLkZz1dNScktvDj3MRBBj7d6wivCsZT/uiq9cXiVOZF2QlsJ4
k/5tIJxoH1e98JjNAakTmlsC6xZPv0tYI0fsQdCyNeh41PTaMkadNAyLrb4tSuFR
rjgRwEWSWV3adAngzKNn479NWYpqyTXVLcU9LBIp/uQj2vQ5lC/5Vb7yd9eNMOk/
ls5GUwN5xFlrjVg22cY7QDUzQcorNLmBNQInUitj5visvHzJPcw2p8Lwsbgl6g7z
WqDI/yn+yF+MsyE/DgE7kn9XGWiOMnjUd2qR7lMLbH1Glb9joCaM9YepgaennMdx
eF65hTGtYoTptWvLLUAMhLmteR6fsAAbEOONc/oTbFPtiocGHWiueSoVlx/iwNyr
U4lWdxO9U3c+hT1VwLPJEXS1ZR7t++IqL0BrbxvcOUk7gtbMUzUC9efzQIuzJJhx
0hg8uKzPEFwDctGLdv+EGYj6Q0sKyD0kHTILDixUpntH5mNp6OWMDw9dnP3yZfly
4QEAYy/0IrFgAaaDqaT1pUu+kG6PqwgmKN53Dva3p8H79PnWULxpOuLGlGmtDTNh
vm3YRNRynP/tB9SXxTtzSobYN4l3I6B0Mqmh4ZzrVmaba4XQTJtsaz6M2qhpmjQy
7XtSeH/Y
=fW62
-----END PGP SIGNATURE-----

--=_MailMate_D4EB5EDB-B3B5-4372-A6AA-1E40E32999F4_=--