Received: by 2002:ab2:1689:0:b0:1f7:5705:b850 with SMTP id d9csp2120212lqa; Tue, 30 Apr 2024 08:38:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWO8LnPNfBWcZjFYDe+iLT9v3l8Flw9jNLg0GNgBdsf1kPNRykwBU/KZoNuCdIRBzLxFPRYOgB/AA/8IvQ+b2jbQejYqqOGkmhhNAjidQ== X-Google-Smtp-Source: AGHT+IGgfjSyq4Kr0TTFLQB8zwhbYm63gkSiqw61gPO6Sy1cCanz+KrlmkWd0rdMssD7jR+MUOic X-Received: by 2002:a05:6358:3a06:b0:18a:c679:39bb with SMTP id g6-20020a0563583a0600b0018ac67939bbmr230110rwe.4.1714491483837; Tue, 30 Apr 2024 08:38:03 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714491483; cv=pass; d=google.com; s=arc-20160816; b=qqxg9++VJzGUP4FB4aV13jLh12m7Xb4G011wQrPa7EPgBAAiYBP19zDyVeFQPXl8Fx Dk3o9OiyMhSEPGf50umFNdTB8Aipm9EUGQveTZKoDJ6SfAXKoFM0IhJV3n1KdD9ze7V+ P8ZEzVgaV2xWpC31I+SnQcU4Y9D9p6fQ5kiscSJL2kKWFU857Ql+qTwWbqIxG/6vCO96 vOJ8ul69/dzckPzDxBeAmBMEh4ZUNuet69PUO+DO7Dp4HBBQVuRExh8jFqkfVZ/YOyA7 atdDNgxBn8D0WTmPHLi2a6BHw9KlXmKs1OEZMSPAM6lWoa5dht+7KCn8C6JU/Mp4d/Md NB2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date; bh=eJpgnUX6Kwc/GgWB3LsJoGPOhl1IUxCKDwLKhJunz8E=; fh=p4doG4iRjRJlQelOpUFI/D5XxuAW3uoGcdUcg8PZxA0=; b=lnqtDmHnxPPVBfFnNLNms4HpMg1pRITwDkSx/zFEdjfgpVV6bfs0wZsqpA7vSte7Kq Bo9Wezw+NK+LucawOmltaNrDL7VyOUhEJw7Zn7WBL8JIjBDDF3h/7VGN/sRwcoasDQRF EnKy9meqeEO+4wkSqTV5X4VLrxeou4FX8oOcr0VaHYelanf+ns/U9Iq4l4R9HrP9vIJT QOpKLdXYokMYMJN3hpKzXUWw3OPoiuiygmDyjBsmUJzHmx9bUOe6ROin+2pybGruCFqG n8KUhPbvf5GmVrDUZGreiMxbe35oaKW9x72fygkiMt558erXBR/eNuM9At3t46QYhfiv u5nA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-164227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164227-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id e26-20020a65689a000000b005dbd83521fasi21036047pgt.883.2024.04.30.08.38.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 08:38:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-164227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-164227-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-164227-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C8B27B255FE for ; Tue, 30 Apr 2024 15:04:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8A4E1172BCA; Tue, 30 Apr 2024 15:03:11 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AD1C7710C; Tue, 30 Apr 2024 15:03:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714489391; cv=none; b=FPIegBhMZm3yd4l6OdPlhO7xI1uwgn4Jn9FuL2Z0b243zzbWM/KzTmhPEikZuC7BudgkegxWMWtof528x6ulM70a9yxd+OIdbD0fLVTlY/toucUDc2txiGfTQc4dH4A/ryCWsztQD7/EWzHy3RBTrTnUdnH3uRqZCCov9qfrkZA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714489391; c=relaxed/simple; bh=a7XKkABB2gMAl6YmsWJisy73NM0mWEPEwg0CoML4T7w=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CxuE/BfLk6Y+BiwCtT/szmXFAnWvZigbRWEgMTtHQ/8HXWTplnN452VmwF/lrFnm4+B+xhNQ8ZlrhfPaClRVLIUPbxqPxU2GFQjpRRcLEKGq0FShUNQFfKljNSalGx3HaDLeP6a+tUdesH6V4GwCdSCLyzMRgF5HZuK3NDgtpTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VTNfh4yYxz6GD7C; Tue, 30 Apr 2024 23:00:28 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 0C296140A08; Tue, 30 Apr 2024 23:03:06 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 30 Apr 2024 16:03:04 +0100 Date: Tue, 30 Apr 2024 16:03:02 +0100 From: Jonathan Cameron To: Robert Richter CC: "Rafael J. Wysocki" , Dave Hansen , Dan Williams , Alison Schofield , , , , kernel test robot , Len Brown Subject: Re: [PATCH v6 4/7] ACPI/NUMA: Squash acpi_numa_memory_affinity_init() into acpi_parse_memory_affinity() Message-ID: <20240430160302.00005fe1@Huawei.com> In-Reply-To: <20240430092200.2335887-5-rrichter@amd.com> References: <20240430092200.2335887-1-rrichter@amd.com> <20240430092200.2335887-5-rrichter@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100006.china.huawei.com (7.191.160.224) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 30 Apr 2024 11:21:57 +0200 Robert Richter wrote: > After removing architectural code the helper function > acpi_numa_memory_affinity_init() is no longer needed. Squash it into > acpi_parse_memory_affinity(). No functional changes intended. > > While at it, fixing checkpatch complaints in code moved. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-lkp/202403220943.96dde419-oliver.sang@intel.com > Reviewed-by: Dan Williams > Signed-off-by: Robert Richter Looks good to me. Printing an SRAT entry we then throw away is a bit odd but it always did that. Reviewed-by: Jonathan Cameron